summaryrefslogtreecommitdiffstats
path: root/chrome/installer/test
diff options
context:
space:
mode:
authorbrettw <brettw@chromium.org>2015-05-20 21:43:40 -0700
committerCommit bot <commit-bot@chromium.org>2015-05-21 04:44:23 +0000
commit74a2a34fce36365a04a50f6b781187b17ae71b73 (patch)
tree65b8316ef7ff70ed297811cc2b6d5158481d2339 /chrome/installer/test
parent8f279b4c8ad2374ba272f4c3a3446495fbfabc86 (diff)
downloadchromium_src-74a2a34fce36365a04a50f6b781187b17ae71b73.zip
chromium_src-74a2a34fce36365a04a50f6b781187b17ae71b73.tar.gz
chromium_src-74a2a34fce36365a04a50f6b781187b17ae71b73.tar.bz2
Remove dependency on resources from installer_util
chrome/installer/util used to depend on chrome:resources but was apparently never used. This causes a problem because chrome_watcher.dll depends on installer_util, and chrome:resources depends on the omnibox mojo target. To get this dependency "right" we would have to link all of mojo system into chrome_watcher.dll. It is properly dead-code stripped (I checked) but this still seems undesirable. I removed the dependency and also made //chrome/installer/* "gn check" clean. There were some other unnecessary deps and header file uses. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1148173002 Cr-Commit-Position: refs/heads/master@{#330895}
Diffstat (limited to 'chrome/installer/test')
-rw-r--r--chrome/installer/test/BUILD.gn1
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/installer/test/BUILD.gn b/chrome/installer/test/BUILD.gn
index ac4ef59..97c3c66 100644
--- a/chrome/installer/test/BUILD.gn
+++ b/chrome/installer/test/BUILD.gn
@@ -36,6 +36,7 @@ source_set("alternate_version_generator_lib") {
]
deps = [
"//base",
+ "//base:base_static",
"//chrome/installer/util",
"//chrome/common:constants",
]