diff options
| author | rickyz <rickyz@chromium.org> | 2015-04-30 14:55:06 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-30 21:56:21 +0000 |
| commit | b356c585d9f6841dcc7df05b8e7cfad0a2b4bdf6 (patch) | |
| tree | 600ee2cda53749188ccd29f80af44abd669f243a /chrome/installer/upgrade_test.gyp | |
| parent | f02f0cc4ee8f12e53cd57a97bd2d6ef4c3af87ff (diff) | |
| download | chromium_src-b356c585d9f6841dcc7df05b8e7cfad0a2b4bdf6.zip chromium_src-b356c585d9f6841dcc7df05b8e7cfad0a2b4bdf6.tar.gz chromium_src-b356c585d9f6841dcc7df05b8e7cfad0a2b4bdf6.tar.bz2 | |
Revert of Add installer_util_unittests to the GN windows build (patchset #5 id:80001 of https://codereview.chromium.org/1062743006/)
Reason for revert:
Compilation errors that look related to the installer_util_strings.rc move: http://build.chromium.org/p/chromium/builders/Win/builds/31460
Original issue's description:
> Add installer_util_unittests to the GN windows build
>
> This fixes some C++ Warnings on Windows to avoid having to add suppressions to the GN build.
>
> Moves the generated strings header to the same place in the gen tree as it is in the source tree. Update includes.
>
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
>
> Committed: https://crrev.com/cb55755a09b9e2d8c5b05b7a4ad2ff8631e15b13
> Cr-Commit-Position: refs/heads/master@{#327790}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1116263002
Cr-Commit-Position: refs/heads/master@{#327799}
Diffstat (limited to 'chrome/installer/upgrade_test.gyp')
| -rw-r--r-- | chrome/installer/upgrade_test.gyp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/installer/upgrade_test.gyp b/chrome/installer/upgrade_test.gyp index 07b283e..bccc94d 100644 --- a/chrome/installer/upgrade_test.gyp +++ b/chrome/installer/upgrade_test.gyp @@ -19,7 +19,6 @@ ['OS=="win"', { 'targets': [ { - # GN version: //chrome/installer/test:alternate_version_generator_lib 'target_name': 'alternate_version_generator_lib', 'type': 'static_library', 'dependencies': [ @@ -44,7 +43,6 @@ 'msvs_disabled_warnings': [4267, ], }, { - # GN version: //chrome/installer/test:upgrade_test 'target_name': 'upgrade_test', 'type': 'executable', 'dependencies': [ @@ -70,7 +68,6 @@ ], }, { - # GN version: //chrome/installer/test:alternate_version_generator 'target_name': 'alternate_version_generator', 'type': 'executable', 'dependencies': [ |