diff options
author | grt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-03 19:51:29 +0000 |
---|---|---|
committer | grt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-03 19:51:29 +0000 |
commit | d33cf4d9172096757459781713b5cdf24d78cde5 (patch) | |
tree | 760ce1aedd936ad3c4df0b9084956ea3c3394062 /chrome/installer/util/chrome_frame_distribution.cc | |
parent | 5d26cf9520236ea4a9258abe5ca65b98861e2e70 (diff) | |
download | chromium_src-d33cf4d9172096757459781713b5cdf24d78cde5.zip chromium_src-d33cf4d9172096757459781713b5cdf24d78cde5.tar.gz chromium_src-d33cf4d9172096757459781713b5cdf24d78cde5.tar.bz2 |
Unconditionally remove "-multifail" from "ap" values. Previously, "-multifail" was added if a --multi-install run failed for any reason. Now, setup.exe always removes it. As a result, it is only left behind when setup.exe crashes (it is added by mini_installer.exe).
BUG=70878
TEST=run a mini_installer.exe with --multi-install (e.g., --multi-install --system-level --chrome --verbose-logging) and try two things: 1) kill setup.exe and make sure that -multifail is left in an "ap" value; 2) cause setup.exe to fail in a non-crash way (e.g., bump up "pv" in Chrome's Clients key so that setup.exe exits with HIGHER_VERSION_EXISTS) then make sure that -multifail is not left in any "ap" value.
Review URL: http://codereview.chromium.org/6286044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73648 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/util/chrome_frame_distribution.cc')
-rw-r--r-- | chrome/installer/util/chrome_frame_distribution.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/installer/util/chrome_frame_distribution.cc b/chrome/installer/util/chrome_frame_distribution.cc index 86a1abc..6dc84ea 100644 --- a/chrome/installer/util/chrome_frame_distribution.cc +++ b/chrome/installer/util/chrome_frame_distribution.cc @@ -106,11 +106,11 @@ bool ChromeFrameDistribution::CanSetAsDefault() { } void ChromeFrameDistribution::UpdateInstallStatus(bool system_install, - bool incremental_install, bool multi_install, + installer::ArchiveType archive_type, installer::InstallStatus install_status) { #if defined(GOOGLE_CHROME_BUILD) GoogleUpdateSettings::UpdateInstallStatus(system_install, - incremental_install, multi_install, - InstallUtil::GetInstallReturnCode(install_status), kChromeFrameGuid); + archive_type, InstallUtil::GetInstallReturnCode(install_status), + kChromeFrameGuid); #endif } |