diff options
| author | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-24 20:58:35 +0000 |
|---|---|---|
| committer | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-24 20:58:35 +0000 |
| commit | cd9a8e7e38c98a91d86c92084b3f7dd59c9bfa67 (patch) | |
| tree | 9ee73b0107de33999df45c83c5e3a2d99d76516e /chrome/installer/util/copy_tree_work_item.h | |
| parent | 9b444619c6a49b3798a85ee95eb93cd5eca65694 (diff) | |
| download | chromium_src-cd9a8e7e38c98a91d86c92084b3f7dd59c9bfa67.zip chromium_src-cd9a8e7e38c98a91d86c92084b3f7dd59c9bfa67.tar.gz chromium_src-cd9a8e7e38c98a91d86c92084b3f7dd59c9bfa67.tar.bz2 | |
Add a new type of WorkItemList: NoRollbackWorkItemList.
This list does a best-effort execution of the items in the work list
and always executes all items even if one of the items fails.
Because of this, the list does also not support Rollback.
The usage for this list is intended for uninstallation actions
such as when unregistering a COM dll fails and we cannot "rollback"
from it since we don't know what went wrong, what is the current state,
etc and rolling back would really mean to re-register the DLL.
Same applies for registry keys and files that might have been removed
by the user.
I also added a basic implementation of the Dump() method to all WorkItem
derived classes for better diagnostics in the future.
BUG=61609
TEST=The class is only used in a pending change list, so there should be no change in current behavior.
Review URL: http://codereview.chromium.org/5260002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67309 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/util/copy_tree_work_item.h')
| -rw-r--r-- | chrome/installer/util/copy_tree_work_item.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/installer/util/copy_tree_work_item.h b/chrome/installer/util/copy_tree_work_item.h index 4d9a984..2c77237 100644 --- a/chrome/installer/util/copy_tree_work_item.h +++ b/chrome/installer/util/copy_tree_work_item.h @@ -6,9 +6,10 @@ #define CHROME_INSTALLER_UTIL_COPY_TREE_WORK_ITEM_H_ #pragma once -#include <string> #include <windows.h> +#include <string> + #include "base/file_path.h" #include "chrome/installer/util/work_item.h" @@ -31,7 +32,7 @@ class CopyTreeWorkItem : public WorkItem { private: friend class WorkItem; - // See comments on corresponding member varibles for the semantics of + // See comments on corresponding member variables for the semantics of // arguments. // Notes on temp_path: to facilitate rollback, the caller needs to supply // a temporary directory to save the original files if they exist under |