diff options
| author | kuan@chromium.org <kuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-23 18:52:15 +0000 |
|---|---|---|
| committer | kuan@chromium.org <kuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-23 18:52:15 +0000 |
| commit | ad22af288a188fda9ae3da630c001e628b941857 (patch) | |
| tree | ef778568d4005d11fe6f027df9f14a11e814c52e /chrome/installer/util/google_chrome_sxs_distribution.cc | |
| parent | 3cb00e373544aacbd269ba82f90147bf8db3c0d0 (diff) | |
| download | chromium_src-ad22af288a188fda9ae3da630c001e628b941857.zip chromium_src-ad22af288a188fda9ae3da630c001e628b941857.tar.gz chromium_src-ad22af288a188fda9ae3da630c001e628b941857.tar.bz2 | |
RecentTabs submenu: fix crash when getting favicon for recently closed tab.
cause:
favicons for both recently closed tabs and tabs from other devices were fetched the same way:
1) via synchronous SessionModelAssociator::GetSyncedFaviconForPageURL().
2) if (1) fails, via asynchronous FaviconService::GetFaviconImageForURL().
TabRestoreServiceChanged() is called on every tab close, triggering the recently closed menu entries to be regenerated.
in some scenarios, e.g. if tab close is triggered from renderer, using (1) to retrieve favicon results in a crash.
fix:
- since (1) is really only for synced tabs, use it only for tabs from other devices.
- (2) is used for recently closed tabs and if (1) fails for tabs from other devices.
BUG=310245
TEST=crash in bug rpt doesn't happen.
Review URL: https://codereview.chromium.org/32823014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230482 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/util/google_chrome_sxs_distribution.cc')
0 files changed, 0 insertions, 0 deletions