diff options
author | atwilson@chromium.org <atwilson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-08 19:42:54 +0000 |
---|---|---|
committer | atwilson@chromium.org <atwilson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-08 19:42:54 +0000 |
commit | 404df1613316a15634d5ba70fdbf32c85c0032e4 (patch) | |
tree | f6bab7adf02b7f785aa2101466a32b5eee8404df /chrome/installer/util | |
parent | fc33e999e1c6426050e231d8dfcc38ddd3deb375 (diff) | |
download | chromium_src-404df1613316a15634d5ba70fdbf32c85c0032e4.zip chromium_src-404df1613316a15634d5ba70fdbf32c85c0032e4.tar.gz chromium_src-404df1613316a15634d5ba70fdbf32c85c0032e4.tar.bz2 |
This is a new version of the older patch. Main changes include:
1. Rebased to a never Git revision to make things easier to land.
2. Chrome will now preserve the command line switches except for those that are
blacklisted.
3. Fixed a race condition that would cause the browser to think it didn't exit
cleanly after it's been restarted.
4. Fixed minor nits and omissions (indentation, etc).
This patch adds a timer which fires every 6 hours and checks whether the
browser is in the "persistent" (background) mode, and whether there's an
update pending restart. If both conditions are true, the browser is
restarted with blacklisted command line keys and all loose values stripped. In order to
restart the browser in the background mode, the --long-lived-extensions
key is also added to the command line.
This change is Windows-only, and it won't become fully functional until
Drew (atwilson) checks in his work that enables Chrome to go into background.
Review URL: http://codereview.chromium.org/1617001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43989 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/util')
-rw-r--r-- | chrome/installer/util/google_update_constants.cc | 5 | ||||
-rw-r--r-- | chrome/installer/util/google_update_constants.h | 4 |
2 files changed, 8 insertions, 1 deletions
diff --git a/chrome/installer/util/google_update_constants.cc b/chrome/installer/util/google_update_constants.cc index 5455aff..496c530 100644 --- a/chrome/installer/util/google_update_constants.cc +++ b/chrome/installer/util/google_update_constants.cc @@ -31,4 +31,7 @@ const wchar_t kRegReferralField[] = L"referral"; const wchar_t kRegEULAAceptedField[] = L"eulaaccepted"; const wchar_t kEnvProductVersionKey[] = L"CHROME_VERSION"; const wchar_t kRegLastRunTimeField[] = L"lastrun"; -} // namespace installer + +const int kUpdateCheckInvervalHours = 6; + +} // namespace google_update diff --git a/chrome/installer/util/google_update_constants.h b/chrome/installer/util/google_update_constants.h index 45d3996..4479d66 100644 --- a/chrome/installer/util/google_update_constants.h +++ b/chrome/installer/util/google_update_constants.h @@ -45,6 +45,10 @@ extern const wchar_t kEnvProductVersionKey[]; // last time that chrome ran in the Time internal format. extern const wchar_t kRegLastRunTimeField[]; +// How often to check if the persistent instance of Chrome needs to restart +// to install an update. +extern const int kUpdateCheckInvervalHours; + } // namespace google_update #endif // CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_CONSTANTS_H_ |