diff options
author | ryanmyers@chromium.org <ryanmyers@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-21 09:41:12 +0000 |
---|---|---|
committer | ryanmyers@chromium.org <ryanmyers@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-21 09:41:12 +0000 |
commit | 970749f3bc5578d8aeb25ad2f09a487481562b8c (patch) | |
tree | 95858bf2694446ec99af116ca2c5edf12f706dee /chrome/installer/util | |
parent | 09c6050a0834210d8c9973fb836aad4eb90003c4 (diff) | |
download | chromium_src-970749f3bc5578d8aeb25ad2f09a487481562b8c.zip chromium_src-970749f3bc5578d8aeb25ad2f09a487481562b8c.tar.gz chromium_src-970749f3bc5578d8aeb25ad2f09a487481562b8c.tar.bz2 |
Add support to Google Update wrappers for the "automatic updates only" group policy setting.
BUG=251972
Review URL: https://chromiumcodereview.appspot.com/17261014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207766 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/util')
-rw-r--r-- | chrome/installer/util/google_update_settings.cc | 1 | ||||
-rw-r--r-- | chrome/installer/util/google_update_settings.h | 1 | ||||
-rw-r--r-- | chrome/installer/util/google_update_settings_unittest.cc | 24 |
3 files changed, 24 insertions, 2 deletions
diff --git a/chrome/installer/util/google_update_settings.cc b/chrome/installer/util/google_update_settings.cc index 3b985b2..338d499 100644 --- a/chrome/installer/util/google_update_settings.cc +++ b/chrome/installer/util/google_update_settings.cc @@ -147,6 +147,7 @@ bool GetUpdatePolicyFromDword( case GoogleUpdateSettings::UPDATES_DISABLED: case GoogleUpdateSettings::AUTOMATIC_UPDATES: case GoogleUpdateSettings::MANUAL_UPDATES_ONLY: + case GoogleUpdateSettings::AUTO_UPDATES_ONLY: *update_policy = static_cast<GoogleUpdateSettings::UpdatePolicy>(value); return true; default: diff --git a/chrome/installer/util/google_update_settings.h b/chrome/installer/util/google_update_settings.h index 7ca9f7c..47b6f36 100644 --- a/chrome/installer/util/google_update_settings.h +++ b/chrome/installer/util/google_update_settings.h @@ -30,6 +30,7 @@ class GoogleUpdateSettings { UPDATES_DISABLED = 0, AUTOMATIC_UPDATES = 1, MANUAL_UPDATES_ONLY = 2, + AUTO_UPDATES_ONLY = 3, }; // Defines product data that is tracked/used by Google Update. diff --git a/chrome/installer/util/google_update_settings_unittest.cc b/chrome/installer/util/google_update_settings_unittest.cc index 4b665b4..17d64a6 100644 --- a/chrome/installer/util/google_update_settings_unittest.cc +++ b/chrome/installer/util/google_update_settings_unittest.cc @@ -544,12 +544,22 @@ TEST_F(GoogleUpdateSettingsTest, GetAppUpdatePolicyDefaultOverride) { &is_overridden)); EXPECT_FALSE(is_overridden); - // The default policy should be in force for bogus values. EXPECT_EQ(ERROR_SUCCESS, RegKey(HKEY_LOCAL_MACHINE, kGoogleUpdatePoliciesKey, KEY_SET_VALUE).WriteValue(kGoogleUpdateUpdateDefault, static_cast<DWORD>(3))); is_overridden = true; + EXPECT_EQ(GoogleUpdateSettings::AUTO_UPDATES_ONLY, + GoogleUpdateSettings::GetAppUpdatePolicy(kTestProductGuid, + &is_overridden)); + EXPECT_FALSE(is_overridden); + + // The default policy should be in force for bogus values. + EXPECT_EQ(ERROR_SUCCESS, + RegKey(HKEY_LOCAL_MACHINE, kGoogleUpdatePoliciesKey, + KEY_SET_VALUE).WriteValue(kGoogleUpdateUpdateDefault, + static_cast<DWORD>(4))); + is_overridden = true; EXPECT_EQ(kDefaultUpdatePolicy, GoogleUpdateSettings::GetAppUpdatePolicy(kTestProductGuid, &is_overridden)); @@ -599,11 +609,21 @@ TEST_F(GoogleUpdateSettingsTest, GetAppUpdatePolicyAppOverride) { &is_overridden)); EXPECT_TRUE(is_overridden); - // The default policy should be in force for bogus values. EXPECT_EQ(ERROR_SUCCESS, RegKey(HKEY_LOCAL_MACHINE, kGoogleUpdatePoliciesKey, KEY_SET_VALUE).WriteValue(app_policy_value.c_str(), static_cast<DWORD>(3))); + is_overridden = false; + EXPECT_EQ(GoogleUpdateSettings::AUTO_UPDATES_ONLY, + GoogleUpdateSettings::GetAppUpdatePolicy(kTestProductGuid, + &is_overridden)); + EXPECT_TRUE(is_overridden); + + // The default policy should be in force for bogus values. + EXPECT_EQ(ERROR_SUCCESS, + RegKey(HKEY_LOCAL_MACHINE, kGoogleUpdatePoliciesKey, + KEY_SET_VALUE).WriteValue(app_policy_value.c_str(), + static_cast<DWORD>(4))); is_overridden = true; EXPECT_EQ(GoogleUpdateSettings::UPDATES_DISABLED, GoogleUpdateSettings::GetAppUpdatePolicy(kTestProductGuid, |