diff options
| author | brettw <brettw@chromium.org> | 2015-07-28 11:24:42 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-28 18:25:26 +0000 |
| commit | bc8b2a244ab981b264a86f5f2a64464089e05e32 (patch) | |
| tree | e2e70581f1d4bee76a0e0535791c0c90bfb59929 /chrome/installer/util | |
| parent | 9e85b9478bb4eebe150d1f896aaf568fe951eade (diff) | |
| download | chromium_src-bc8b2a244ab981b264a86f5f2a64464089e05e32.zip chromium_src-bc8b2a244ab981b264a86f5f2a64464089e05e32.tar.gz chromium_src-bc8b2a244ab981b264a86f5f2a64464089e05e32.tar.bz2 | |
Annotate large GN targets for precompiled headers
Adds the precompiled header config to most large-ish targets in the build, but keeps the config a no-op (so no precompiled headers will be used but this can bw switched with a one-line change).
Removes Windows files from the precompiled header. This does not seem to affect the build speed much because most Chrome files don't depend on Windows any more. And windows.h injects typedefs and defines that conflict with some third party libraries and prevent using precompiled headers for those targets or any target that includes them.
I counted ~50 files or bigger as large. The 50 file threshold is based on some previous approximate measurements (since the precompile step is an extra per-target compile, it can actually make small targets compile slower).
For borderline cases, I added the precompiled header flag if I thought it was likely to have more files added, and didn't add it if I thought the target was likely to be static.
This is a reland of https://codereview.chromium.org/1250273002/ with the config disabled for easier re-landing and iterating
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=dpranke
Review URL: https://codereview.chromium.org/1258273004
Cr-Commit-Position: refs/heads/master@{#340728}
Diffstat (limited to 'chrome/installer/util')
| -rw-r--r-- | chrome/installer/util/BUILD.gn | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/chrome/installer/util/BUILD.gn b/chrome/installer/util/BUILD.gn index e21ff8c..ceedefd 100644 --- a/chrome/installer/util/BUILD.gn +++ b/chrome/installer/util/BUILD.gn @@ -68,8 +68,12 @@ static_library("util") { "//third_party/lzma_sdk", ] - # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. - configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] + configs += [ + "//build/config:precompiled_headers", + + # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. + "//build/config/compiler:no_size_t_to_int_warning", + ] # TODO(GYP) hook up corresponding version of installer_util_nacl_win64 in GN sources += [ |