Replace ToLower calls to the new format

Replaces
  base::StringToLowerASCII(string)
with
  base::ToLowerASCII(string)
This form is 1:1 search and replace.

A bunch of places did something like this:
  std::string foo(something_else);
  base::StringToLowerASCII(&foo);
which became:
  foo = base::ToLowerASCII(something_else);

A couple places really wanted in-place changing and they became:
  foo = base::ToLowerASCII(foo);

There was pretty trivial cleanup in chrome_main_delegate.cc chrome/test/chromedriver/server/http_handler.cc (fix indenting).

There was more cleanup in:
chrome/installer/util/language_selector.cc and components/plugins/renderer/mobile_youtube_plugin.cc

In components/history/core/browser/url_utils.cc I removed the call since it was calling ToLower on the host name out of a GURL, which is already guaranteed to be lower-case.

NOPRESUBMIT=true
(due to touching code with wstrings)

Review URL: https://codereview.chromium.org/1279123004

Cr-Commit-Position: refs/heads/master@{#342659}

1 files changed, 3 insertions, 7 deletions

diff --git a/chrome/installer/util/language_selector.cc b/chrome/installer/util/language_selector.cc
index 1c1a582..aa8555f 100644
--- a/chrome/installer/util/language_selector.cc
+++ b/chrome/installer/util/language_selector.cc
@@ -243,13 +243,9 @@ bool LanguageSelector::SelectIf(const std::vector<std::wstring>& candidates,
                                 SelectPred_Fn select_predicate,
                                 std::wstring* matched_name,
                                 int* matched_offset) {
-  std::wstring candidate;
-  for (std::vector<std::wstring>::const_iterator scan = candidates.begin(),
-          end = candidates.end(); scan != end; ++scan) {
-    candidate.assign(*scan);
-    base::StringToLowerASCII(&candidate);
-    if (select_predicate(candidate, matched_offset)) {
-      matched_name->assign(*scan);
+  for (const std::wstring& scan : candidates) {
+    if (select_predicate(base::ToLowerASCII(scan), matched_offset)) {
+      matched_name->assign(scan);
       return true;
     }
   }