diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-25 22:37:14 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-25 22:37:14 +0000 |
commit | 77c9ce91fe094be265b3dc9312970a1323b5375c (patch) | |
tree | 6994371ffadc46433c15e52b4143185fad3e61e6 /chrome/plugin/npobject_proxy.cc | |
parent | c5d39118d6c0fc173526c8ea7a0581a60b0f23ae (diff) | |
download | chromium_src-77c9ce91fe094be265b3dc9312970a1323b5375c.zip chromium_src-77c9ce91fe094be265b3dc9312970a1323b5375c.tar.gz chromium_src-77c9ce91fe094be265b3dc9312970a1323b5375c.tar.bz2 |
Revert 57403 - Merge 57372 - Fix for the missing plugin message displayed at times on sites like youtube while playing
playlists, etc. The message is displayed when we fail to create a channel for the plugin
process.
The problem occurs because of a race condition between the plugin channel information being
deleted from the channel map and the actual channel being deleted. This race occurs if
the plugin is in the context of a sync call to the renderer which results in the plugin
instance being deleted and the new one getting created in the same context. This results
in the plugin channel information getting deleted from the map. The actual channel gets
deleted only when the plugin sync call unwinds which occurs after the browser sends in
a request to create the channel for the new plugin instance.
Fix is to create the channel name with an incrementing number in the plugin process, if
the mode is server. The channel map is still keyed off the process id and renderer id
as before.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=43595
Bug=43595
Test=Covered by new ui test SelfDeleteCreatePluginInNPNEvaluate.
The other change is a fix in the test plugin to delete a windows timer correctly and
to add support for a new plugin test case.
Review URL: http://codereview.chromium.org/3142039
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/3140031
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/3197021
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@57406 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/plugin/npobject_proxy.cc')
0 files changed, 0 insertions, 0 deletions