diff options
| author | andrewhayden@chromium.org <andrewhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-24 15:54:26 +0000 |
|---|---|---|
| committer | andrewhayden@chromium.org <andrewhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-24 15:54:26 +0000 |
| commit | cf78eecf38ea51a8a4c0b78974d7a5d88bbb0b54 (patch) | |
| tree | 414ed885eafebf252c99cef6ccbdb72f9a3198fe /chrome/renderer/DEPS | |
| parent | f3918a49017af1015fe4256f80b35eb6577a67b8 (diff) | |
| download | chromium_src-cf78eecf38ea51a8a4c0b78974d7a5d88bbb0b54.zip chromium_src-cf78eecf38ea51a8a4c0b78974d7a5d88bbb0b54.tar.gz chromium_src-cf78eecf38ea51a8a4c0b78974d7a5d88bbb0b54.tar.bz2 | |
This patch defines three mechanisms for acquiring CLD2's data:
1. Static linking (the way it is done today)
2. Standalone dynamic data file bundled with the application
3. Dynamic data file downloaded via the Component Updater
This change does NOT switch any implementation to a different cld data source.
Android/iOS remain pinned to CLD1, and all platforms continue to statically
link the data with cld2_data_source="static".
This change has several important side effects:
1. The gyp variables "cld2_dynamic" and "cld2_is_component" have been removed.
There is now a single variable, "cld2_data_source", that defines which
implementation is to be used.
2. cld_component_installer.[h,cc] and cld_component_installer_unittest.cc are
now conditionally built if and only if cld2_data_source=="component" and
have direct dependencies upon components/translate/content/browser.
3. Almost all preprocesser checks for the CLD data source have been removed,
greatly simplifying code flow. The logic previously gated by these checks
has been split into separate implementation classes whose inclusion is
controlled by the cld2_data_source gyp variable.
For more information, refer to crbug/383769.
BUG=383769
Review URL: https://codereview.chromium.org/333603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279415 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/DEPS')
| -rw-r--r-- | chrome/renderer/DEPS | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/renderer/DEPS b/chrome/renderer/DEPS index d806f30..0eac425 100644 --- a/chrome/renderer/DEPS +++ b/chrome/renderer/DEPS @@ -9,6 +9,7 @@ include_rules = [ "+components/plugins/renderer", "+components/signin/core/common", "+components/translate/content/common", + "+components/translate/content/renderer", "+components/translate/core/common", "+components/translate/core/language_detection", "+components/visitedlink/renderer", |