diff options
author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-01 04:38:24 +0000 |
---|---|---|
committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-01 04:38:24 +0000 |
commit | 3fda6cda9e170c4f75c8c15cc1082b4f6e42cfdb (patch) | |
tree | 1041d6b8e4055ac5fab8d09db216048b44d58f0c /chrome/renderer/extensions/event_bindings.cc | |
parent | 014010e750ac79058bd94b03caf9a6f7a5166e99 (diff) | |
download | chromium_src-3fda6cda9e170c4f75c8c15cc1082b4f6e42cfdb.zip chromium_src-3fda6cda9e170c4f75c8c15cc1082b4f6e42cfdb.tar.gz chromium_src-3fda6cda9e170c4f75c8c15cc1082b4f6e42cfdb.tar.bz2 |
Rename ExtensionBase to ChromeV8Extension and simplify.
Remove JsOnlyV8Extensions since we can just create instances of ChromeV8Extension where necessary.
Instead of using made-up names like "chrome/extensionprocessbindings", standardize on the path to the file as the name of an extension.
Review URL: http://codereview.chromium.org/8100014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103624 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/extensions/event_bindings.cc')
-rw-r--r-- | chrome/renderer/extensions/event_bindings.cc | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/chrome/renderer/extensions/event_bindings.cc b/chrome/renderer/extensions/event_bindings.cc index ed65e3f..f4f9b66 100644 --- a/chrome/renderer/extensions/event_bindings.cc +++ b/chrome/renderer/extensions/event_bindings.cc @@ -12,12 +12,11 @@ #include "chrome/common/extensions/extension_messages.h" #include "chrome/common/extensions/extension_set.h" #include "chrome/common/url_constants.h" +#include "chrome/renderer/extensions/chrome_v8_extension.h" #include "chrome/renderer/extensions/event_bindings.h" -#include "chrome/renderer/extensions/extension_base.h" #include "chrome/renderer/extensions/extension_bindings_context.h" #include "chrome/renderer/extensions/extension_dispatcher.h" #include "chrome/renderer/extensions/extension_process_bindings.h" -#include "chrome/renderer/extensions/js_only_v8_extensions.h" #include "chrome/renderer/extensions/user_script_slave.h" #include "content/renderer/render_thread.h" #include "content/renderer/render_view.h" @@ -57,12 +56,12 @@ static EventListenerCounts& GetListenerCounts(const std::string& extension_id) { return g_singleton_data.Get().listener_counts_[extension_id]; } -class ExtensionImpl : public ExtensionBase { +class ExtensionImpl : public ChromeV8Extension { public: explicit ExtensionImpl(ExtensionDispatcher* dispatcher) - : ExtensionBase(EventBindings::kName, - GetStringResource(IDR_EVENT_BINDINGS_JS), - 0, NULL, dispatcher) { + : ChromeV8Extension("extensions/event.js", + IDR_EVENT_BINDINGS_JS, + dispatcher) { } ~ExtensionImpl() {} @@ -75,7 +74,7 @@ class ExtensionImpl : public ExtensionBase { } else if (name->Equals(v8::String::New("GetExternalFileEntry"))) { return v8::FunctionTemplate::New(GetExternalFileEntry); } - return ExtensionBase::GetNativeFunction(name); + return ChromeV8Extension::GetNativeFunction(name); } // Attach an event name to an object. @@ -165,8 +164,6 @@ class ExtensionImpl : public ExtensionBase { } // namespace -const char* EventBindings::kName = "chrome/EventBindings"; - v8::Extension* EventBindings::Get(ExtensionDispatcher* dispatcher) { static v8::Extension* extension = new ExtensionImpl(dispatcher); return extension; |