This is the second side of a multi-sided webkit patch that will allow experimental window.open feature strings to be captured and passed to the client.

It should wait for: https://bugs.webkit.org/show_bug.cgi?id=38013 to land. This is required because this patch needs to use the WebWindowFeature binding struct in WebKit.

Once this is landed, a webkit patch to change the call signature for WebViewClient::createView to include the WebWindowFeatures will be submitted (and after that another chromium patch to remove the old call signature).

This patch implements old and new WebViewClient::createView signatures, and additionally passes the vector all the way to RenderViewHostDelegateHelper who will eventually use it to observe the 'background' feature.

BUG=41275
TEST=all tests should pass

Review URL: http://codereview.chromium.org/1758004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45877 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 0 deletions

diff --git a/chrome/renderer/render_view.h b/chrome/renderer/render_view.h
index e04a404..1eda03e 100644
--- a/chrome/renderer/render_view.h
+++ b/chrome/renderer/render_view.h
@@ -111,6 +111,7 @@ class WebURLRequest;
 struct WebFileChooserParams;
 struct WebFindOptions;
 struct WebPoint;
+struct WebWindowFeatures;
 }
 
 // We need to prevent a page from trying to create infinite popups. It is not
@@ -202,7 +203,12 @@ class RenderView : public RenderWidget,
   virtual void DnsPrefetch(const std::vector<std::string>& host_names);
 
   // WebKit::WebViewClient
+  // TODO(rafaelw): Remove this when
+  // WebViewClient::createView(WebFrame,WebWindowFeatures&) lands.
   virtual WebKit::WebView* createView(WebKit::WebFrame* creator);
+  virtual WebKit::WebView* createView(
+      WebKit::WebFrame* creator,
+      const WebKit::WebWindowFeatures& features);
   virtual WebKit::WebWidget* createPopupMenu(WebKit::WebPopupType popup_type);
   virtual WebKit::WebWidget* createPopupMenu(
       const WebKit::WebPopupMenuInfo& info);