diff options
| author | jshin@chromium.org <jshin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-19 20:57:14 +0000 |
|---|---|---|
| committer | jshin@chromium.org <jshin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-19 20:57:14 +0000 |
| commit | d54713426ab132a5ca95d6239641aad580fcf799 (patch) | |
| tree | 247a70bc7609eba200c5f1760b8ab0ea56877982 /chrome/renderer/render_view.h | |
| parent | 35ee9505314a11dadac1bdfd41612f2984448af9 (diff) | |
| download | chromium_src-d54713426ab132a5ca95d6239641aad580fcf799.zip chromium_src-d54713426ab132a5ca95d6239641aad580fcf799.tar.gz chromium_src-d54713426ab132a5ca95d6239641aad580fcf799.tar.bz2 | |
Review URL: http://codereview.chromium.org/545123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36541 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_view.h')
| -rw-r--r-- | chrome/renderer/render_view.h | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/chrome/renderer/render_view.h b/chrome/renderer/render_view.h index 4d3a4e9..036cb0b 100644 --- a/chrome/renderer/render_view.h +++ b/chrome/renderer/render_view.h @@ -436,9 +436,15 @@ class RenderView : public RenderWidget, PageTranslator* page_translator() const { return page_translator_.get(); } - // Returns the ISO 639_1 language code of the current page - // (ex: en, fr, zh...). Returns 'unknown' if the language could not be - // determined. + // Returns the ISO 639 language code of the current page (e.g. en, fr, zh). + // If ISO 639-1 code is not available for the language, ISO 639-2 3-letter code + // will be returned (e.g. kha for Khasi and und for undtermined). For traditional + // Chinse, 'zh-TW' will be returned while for simplified Chinse, 'zh' will be + // returned. + // TODO(jungshik): Make it return 'he' (the correct ISO 639 code for Hebrew) + // instead of the obsolete 'iw'. Perhaps, it's also better to return 'zh-Hans' + // (or 'zh-CN') for Simplified Chinese instead of 'zh' to be aligned with + // 'zh-TW' for Traditional Chinse. std::string DetectLanguage(); protected: |