Refactor version-getting info into a chrome::VersionInfo object.

I was trying to replace wstring usage in base::FileVersionInfo, but
that class is rather Windows-specific with strange fields like
"private_build()" where the value and encoding aren't clear.  95%
of the users of FileVersionInfo actually just care about the current
Chrome version, so we can provide a much simpler interface for them.

We still use FileVersionInfo for retrieving information from e.g.
plugin DLLs, but in those cases the usage is clearer.

Review URL: http://codereview.chromium.org/3135028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57725 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 3 insertions, 4 deletions

diff --git a/chrome/renderer/renderer_glue.cc b/chrome/renderer/renderer_glue.cc
index 9691d58..9469e8c 100644
--- a/chrome/renderer/renderer_glue.cc
+++ b/chrome/renderer/renderer_glue.cc
@@ -15,7 +15,6 @@
 #include "app/clipboard/clipboard.h"
 #include "app/resource_bundle.h"
 #include "base/command_line.h"
-#include "base/file_version_info.h"
 #include "base/ref_counted.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ -301,10 +300,10 @@ void ClearCache() {
 }
 
 std::string GetProductVersion() {
-  scoped_ptr<FileVersionInfo> version_info(chrome::GetChromeVersionInfo());
+  chrome::VersionInfo version_info;
   std::string product("Chrome/");
-  product += version_info.get() ? WideToASCII(version_info->product_version())
-                                : "0.0.0.0";
+  product += version_info.is_valid() ? version_info.Version()
+                                     : "0.0.0.0";
   return product;
 }