summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/resources/extensions/extension_options.js
diff options
context:
space:
mode:
authortapted <tapted@chromium.org>2014-10-01 17:46:54 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-02 00:47:26 +0000
commit7f79ce28848eb40d4ec6d2d335e2996ff02362e5 (patch)
tree97186f2d3aff09d6bb92fedad0dc1614940ac6a2 /chrome/renderer/resources/extensions/extension_options.js
parent098a0704f38b27045aa165a535cb86c9aea7fdb7 (diff)
downloadchromium_src-7f79ce28848eb40d4ec6d2d335e2996ff02362e5.zip
chromium_src-7f79ce28848eb40d4ec6d2d335e2996ff02362e5.tar.gz
chromium_src-7f79ce28848eb40d4ec6d2d335e2996ff02362e5.tar.bz2
Revert of Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize() (patchset #3 id:120001 of https://codereview.chromium.org/613563002/)
Reason for revert: Suspected for failures on Linux ChromiumOS Tests (dbg)(1) link: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/32143 browser_test LoginWebDialogTest.CannotMinimize failing with: [12496:12496:1001/170357:FATAL:login_web_dialog.cc(148)] Check failed: false. #2 0x0000026179dd chromeos::LoginWebDialog::OnCloseContents() #3 0x7f542cba9b00 views::WebDialogView::OnCloseContents() /* snip */ #24 0x7f5422726679 aura::Window::~Window() #25 0x7f54244db0f8 ash::RootWindowController::CloseChildWindows() #26 0x7f5424444bad ash::DisplayController::CloseChildWindows() #27 0x7f542452db9b ash::Shell::~Shell() #28 0x7f542452e869 ash::Shell::~Shell() #29 0x7f542452a16f ash::Shell::DeleteInstance() #30 0x000002dac13b chrome::CloseAsh() #31 0x000002a0e111 ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() Original issue's description: > Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize() > > This has the side effect of disallowing minimizing bubbles (e.g. the bookmark > bubble) via a gesture > > BUG=328241 > TEST=Manual, see bug > > Committed: https://crrev.com/ffacfd8c2841480e1e5775c124b63b351bddca69 > Cr-Commit-Position: refs/heads/master@{#297732} TBR=oshima@chromium.org,sky@chromium.org,pkotwicz@chromium.org NOTREECHECKS=true NOTRY=true BUG=328241 Review URL: https://codereview.chromium.org/623613004 Cr-Commit-Position: refs/heads/master@{#297750}
Diffstat (limited to 'chrome/renderer/resources/extensions/extension_options.js')
0 files changed, 0 insertions, 0 deletions