diff options
| author | sreeram@chromium.org <sreeram@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-16 06:54:20 +0000 |
|---|---|---|
| committer | sreeram@chromium.org <sreeram@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-16 06:54:20 +0000 |
| commit | a6fdd5eb2eb38f12d116f48c892c077bb3be852d (patch) | |
| tree | 2e15e280ec5c5e1ee4e6c078cef1ac43c314d2f9 /chrome/renderer/searchbox | |
| parent | 1bcd7f95d88aa468a8a7e564312fb29835276c06 (diff) | |
| download | chromium_src-a6fdd5eb2eb38f12d116f48c892c077bb3be852d.zip chromium_src-a6fdd5eb2eb38f12d116f48c892c077bb3be852d.tar.gz chromium_src-a6fdd5eb2eb38f12d116f48c892c077bb3be852d.tar.bz2 | |
Instant: Clear autocomplete results on a "blank query onchange".
BUG=231738
R=samarth@chromium.org
TEST=See bug.
Review URL: https://codereview.chromium.org/14265016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194313 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/searchbox')
| -rw-r--r-- | chrome/renderer/searchbox/searchbox.cc | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc index def746d..b48c383 100644 --- a/chrome/renderer/searchbox/searchbox.cc +++ b/chrome/renderer/searchbox/searchbox.cc @@ -226,6 +226,18 @@ void SearchBox::OnChange(const string16& query, verbatim_ = verbatim; selection_start_ = selection_start; selection_end_ = selection_end; + + // If |query| is empty, this is due to the user backspacing away all the text + // in the omnibox, or hitting Escape to restore the "permanent URL", or + // switching tabs, etc. In all these cases, there will be no corresponding + // OnAutocompleteResults(), so clear the autocomplete results ourselves, by + // adding an empty set. Don't notify the page using an "onnativesuggestions" + // event, though. + if (query.empty()) { + autocomplete_results_cache_.AddItems( + std::vector<InstantAutocompleteResult>()); + } + if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) { DVLOG(1) << render_view() << " OnChange"; extensions_v8::SearchBoxExtension::DispatchChange( |