summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/spellchecker/custom_dictionary_engine_unittest.cc
diff options
context:
space:
mode:
authorrouslan@chromium.org <rouslan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-29 00:47:54 +0000
committerrouslan@chromium.org <rouslan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-29 00:47:54 +0000
commit6da98fc10000c9eb47b9552ea2b3a6ed9f07eff2 (patch)
treeb80be8edaeae352bcdfe0b15e9cfc70b17531ef6 /chrome/renderer/spellchecker/custom_dictionary_engine_unittest.cc
parent68d56418aaeaf2abf5f69935b7f95f7c6e519048 (diff)
downloadchromium_src-6da98fc10000c9eb47b9552ea2b3a6ed9f07eff2.zip
chromium_src-6da98fc10000c9eb47b9552ea2b3a6ed9f07eff2.tar.gz
chromium_src-6da98fc10000c9eb47b9552ea2b3a6ed9f07eff2.tar.bz2
Add HasWord(string) method to SpellcheckCustomDictionary
This CL adds a method HasWord(string) to SpellcheckCustomDictionary and changes the internal data structure in SpellcheckCustomDictionary from a vector to a set for more efficient querying. Spelling service client will use the new method to send IN_DICTIONARY feedback to spelling service for words that are in user's custom spellcheck dictionary. Spelling service client will use this method in upcoming CLs. This CL also modifies IPC message "SpellCheckMsg_Init" to pass a set instead of a vector of custom dictionary words. The browser sends this message to the renderer to initialize spellcheck. BUG=170514 Review URL: https://chromiumcodereview.appspot.com/15940004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202722 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/spellchecker/custom_dictionary_engine_unittest.cc')
-rw-r--r--chrome/renderer/spellchecker/custom_dictionary_engine_unittest.cc14
1 files changed, 11 insertions, 3 deletions
diff --git a/chrome/renderer/spellchecker/custom_dictionary_engine_unittest.cc b/chrome/renderer/spellchecker/custom_dictionary_engine_unittest.cc
index 440d110..3a6ea8a 100644
--- a/chrome/renderer/spellchecker/custom_dictionary_engine_unittest.cc
+++ b/chrome/renderer/spellchecker/custom_dictionary_engine_unittest.cc
@@ -1,15 +1,23 @@
// Copyright (c) 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/renderer/spellchecker/custom_dictionary_engine.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/renderer/spellchecker/custom_dictionary_engine.h"
#include "testing/gtest/include/gtest/gtest.h"
TEST(CustomDictionaryTest, HandlesEmptyWordWithInvalidSubstring) {
CustomDictionaryEngine engine;
- std::vector<std::string> custom_words;
-
+ std::set<std::string> custom_words;
engine.Init(custom_words);
EXPECT_FALSE(engine.SpellCheckWord(string16().c_str(), 15, 23));
}
+TEST(CustomDictionaryTest, Basic) {
+ CustomDictionaryEngine engine;
+ EXPECT_FALSE(engine.SpellCheckWord(ASCIIToUTF16("helllo").c_str(), 0, 6));
+ std::set<std::string> custom_words;
+ custom_words.insert("helllo");
+ engine.Init(custom_words);
+ EXPECT_TRUE(engine.SpellCheckWord(ASCIIToUTF16("helllo").c_str(), 0, 6));
+}