diff options
author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-19 22:44:29 +0000 |
---|---|---|
committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-19 22:44:29 +0000 |
commit | c27324bdb7b9ee448a0c73d5c005c709282c8cbc (patch) | |
tree | d7ec31ab43e6493ef3f00eb81faeca0c79a793c3 /chrome/renderer/spellchecker | |
parent | 5ef3748a651d073bf12928e880a042bf450e1aa8 (diff) | |
download | chromium_src-c27324bdb7b9ee448a0c73d5c005c709282c8cbc.zip chromium_src-c27324bdb7b9ee448a0c73d5c005c709282c8cbc.tar.gz chromium_src-c27324bdb7b9ee448a0c73d5c005c709282c8cbc.tar.bz2 |
Move Mac to using renderer spellchecker.
BUG=25677
Review URL: http://codereview.chromium.org/395007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32561 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/spellchecker')
-rw-r--r-- | chrome/renderer/spellchecker/spellcheck.cc | 39 | ||||
-rw-r--r-- | chrome/renderer/spellchecker/spellcheck.h | 3 | ||||
-rw-r--r-- | chrome/renderer/spellchecker/spellcheck_unittest.cc | 653 |
3 files changed, 680 insertions, 15 deletions
diff --git a/chrome/renderer/spellchecker/spellcheck.cc b/chrome/renderer/spellchecker/spellcheck.cc index 3b02b54..3fa20f8 100644 --- a/chrome/renderer/spellchecker/spellcheck.cc +++ b/chrome/renderer/spellchecker/spellcheck.cc @@ -7,18 +7,16 @@ #include "base/file_util.h" #include "base/histogram.h" #include "base/time.h" +#include "chrome/common/render_messages.h" +#include "chrome/common/spellcheck_common.h" #include "chrome/renderer/render_thread.h" #include "third_party/hunspell/src/hunspell/hunspell.hxx" -static const int kMaxAutoCorrectWordSize = 8; -static const int kMaxSuggestions = 5; - using base::TimeTicks; SpellCheck::SpellCheck() : file_(base::kInvalidPlatformFileValue), auto_spell_correct_turned_on_(false), - // TODO(estade): initialize this properly. is_using_platform_spelling_engine_(false), initialized_(false) { // Wait till we check the first word before doing any initializing. @@ -34,6 +32,9 @@ void SpellCheck::Init(base::PlatformFile file, hunspell_.reset(); bdict_file_.reset(); file_ = file; + is_using_platform_spelling_engine_ = + file == base::kInvalidPlatformFileValue && !language.empty(); + character_attributes_.SetDefaultLanguage(language); custom_words_.insert(custom_words_.end(), @@ -58,8 +59,10 @@ bool SpellCheck::SpellCheckWord( return true; // Do nothing if spell checking is disabled. - if (initialized_ && file_ == base::kInvalidPlatformFileValue) + if (initialized_ && file_ == base::kInvalidPlatformFileValue && + !is_using_platform_spelling_engine_) { return true; + } *misspelling_start = 0; *misspelling_len = 0; @@ -100,15 +103,15 @@ string16 SpellCheck::GetAutoCorrectionWord(const string16& word, int tag) { return autocorrect_word; // Return the empty string. int word_length = static_cast<int>(word.size()); - if (word_length < 2 || word_length > kMaxAutoCorrectWordSize) + if (word_length < 2 || word_length > SpellCheckCommon::kMaxAutoCorrectWordSize) return autocorrect_word; if (InitializeIfNeeded()) return autocorrect_word; - char16 misspelled_word[kMaxAutoCorrectWordSize + 1]; + char16 misspelled_word[SpellCheckCommon::kMaxAutoCorrectWordSize + 1]; const char16* word_char = word.c_str(); - for (int i = 0; i <= kMaxAutoCorrectWordSize; i++) { + for (int i = 0; i <= SpellCheckCommon::kMaxAutoCorrectWordSize; i++) { if (i >= word_length) misspelled_word[i] = NULL; else @@ -188,15 +191,18 @@ void SpellCheck::AddWordToHunspell(const std::string& word) { } bool SpellCheck::InitializeIfNeeded() { + if (is_using_platform_spelling_engine_) + return false; + if (!initialized_) { - RenderThread::current()->RequestSpellCheckDictionary(); + RenderThread::current()->Send( + new ViewHostMsg_SpellChecker_RequestDictionary); initialized_ = true; return true; } // Check if the platform spellchecker is being used. - if (!is_using_platform_spelling_engine_ && - file_ != base::kInvalidPlatformFileValue) { + if (file_ != base::kInvalidPlatformFileValue) { // If it isn't, init hunspell. InitializeHunspell(); } @@ -210,8 +216,9 @@ bool SpellCheck::CheckSpelling(const string16& word_to_check, int tag) { bool word_correct = false; if (is_using_platform_spelling_engine_) { - // TODO(estade): sync IPC to browser. - word_correct = true; + RenderThread::current()->Send( + new ViewHostMsg_SpellChecker_PlatformCheckSpelling(word_to_check, tag, + &word_correct)); } else { std::string word_to_check_utf8(UTF16ToUTF8(word_to_check)); // Hunspell shouldn't let us exceed its max, but check just in case @@ -229,7 +236,9 @@ void SpellCheck::FillSuggestionList( const string16& wrong_word, std::vector<string16>* optional_suggestions) { if (is_using_platform_spelling_engine_) { - // TODO(estade): sync IPC to browser. + RenderThread::current()->Send( + new ViewHostMsg_SpellChecker_PlatformFillSuggestionList( + wrong_word, optional_suggestions)); return; } char** suggestions; @@ -238,7 +247,7 @@ void SpellCheck::FillSuggestionList( // Populate the vector of WideStrings. for (int i = 0; i < number_of_suggestions; i++) { - if (i < kMaxSuggestions) + if (i < SpellCheckCommon::kMaxSuggestions) optional_suggestions->push_back(UTF8ToUTF16(suggestions[i])); free(suggestions[i]); } diff --git a/chrome/renderer/spellchecker/spellcheck.h b/chrome/renderer/spellchecker/spellcheck.h index ef194bd..94b9a07 100644 --- a/chrome/renderer/spellchecker/spellcheck.h +++ b/chrome/renderer/spellchecker/spellcheck.h @@ -52,6 +52,9 @@ class SpellCheck { // Find a possible correctly spelled word for a misspelled word. Computes an // empty string if input misspelled word is too long, there is ambiguity, or // the correct spelling cannot be determined. + // NOTE: If using the platform spellchecker, this will send a *lot* of sync + // IPCs. We should probably refactor this if we ever plan to take it out from + // behind its command line flag. string16 GetAutoCorrectionWord(const string16& word, int tag); // Turn auto spell correct support ON or OFF. diff --git a/chrome/renderer/spellchecker/spellcheck_unittest.cc b/chrome/renderer/spellchecker/spellcheck_unittest.cc new file mode 100644 index 0000000..2ed20a6 --- /dev/null +++ b/chrome/renderer/spellchecker/spellcheck_unittest.cc @@ -0,0 +1,653 @@ +// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "webkit/glue/webkit_glue.h" + +#include "base/file_util.h" +#include "base/message_loop.h" +#include "base/path_service.h" +#include "base/platform_file.h" +#include "base/sys_string_conversions.h" +#include "chrome/renderer/spellchecker/spellcheck.h" +#include "chrome/common/chrome_paths.h" +#include "chrome/common/spellcheck_common.h" +#include "testing/gtest/include/gtest/gtest.h" + +namespace { + +// Represents a special initialization function used only for the unit tests +// in this file. +extern void InitHunspellWithFiles(FILE* file_aff_hunspell, + FILE* file_dic_hunspell); + +FilePath GetHunspellDirectory() { + FilePath hunspell_directory; + if (!PathService::Get(base::DIR_SOURCE_ROOT, &hunspell_directory)) + return FilePath(); + + hunspell_directory = hunspell_directory.AppendASCII("third_party"); + hunspell_directory = hunspell_directory.AppendASCII("hunspell"); + hunspell_directory = hunspell_directory.AppendASCII("dictionaries"); + return hunspell_directory; +} + +class SpellCheckTest : public testing::Test { + public: + SpellCheckTest() { + ReinitializeSpellCheck("en-US"); + } + + void ReinitializeSpellCheck(const std::string& language) { + spell_check_.reset(new SpellCheck()); + + FilePath hunspell_directory = GetHunspellDirectory(); + EXPECT_FALSE(hunspell_directory.empty()); + base::PlatformFile file = base::CreatePlatformFile( + SpellCheckCommon::GetVersionedFileName(language, hunspell_directory), + base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_READ, NULL); + spell_check_->Init( + file, std::vector<std::string>(), language); + } + + virtual ~SpellCheckTest() { + } + + SpellCheck* spell_check() { return spell_check_.get(); } + + private: + scoped_ptr<SpellCheck> spell_check_; +}; + +// Operates unit tests for the webkit_glue::SpellCheckWord() function +// with the US English dictionary. +// The unit tests in this function consist of: +// * Tests for the function with empty strings; +// * Tests for the function with a valid English word; +// * Tests for the function with a valid non-English word; +// * Tests for the function with a valid English word with a preceding +// space character; +// * Tests for the function with a valid English word with a preceding +// non-English word; +// * Tests for the function with a valid English word with a following +// space character; +// * Tests for the function with a valid English word with a following +// non-English word; +// * Tests for the function with two valid English words concatenated +// with space characters or non-English words; +// * Tests for the function with an invalid English word; +// * Tests for the function with an invalid English word with a preceding +// space character; +// * Tests for the function with an invalid English word with a preceding +// non-English word; +// * Tests for the function with2 an invalid English word with a following +// space character; +// * Tests for the function with an invalid English word with a following +// non-English word, and; +// * Tests for the function with two invalid English words concatenated +// with space characters or non-English words. +// A test with a "[ROBUSTNESS]" mark shows it is a robustness test and it uses +// grammartically incorrect string. +// TODO(hbono): Please feel free to add more tests. +TEST_F(SpellCheckTest, SpellCheckStrings_EN_US) { + static const struct { + // A string to be tested. + const wchar_t* input; + // An expected result for this test case. + // * true: the input string does not have any invalid words. + // * false: the input string has one or more invalid words. + bool expected_result; + // The position and the length of the first invalid word. + int misspelling_start; + int misspelling_length; + } kTestCases[] = { + // Empty strings. + {L"", true, 0, 0}, + {L" ", true, 0, 0}, + {L"\xA0", true, 0, 0}, + {L"\x3000", true, 0, 0}, + + // A valid English word "hello". + {L"hello", true, 0, 0}, + // A valid Chinese word (meaning "hello") consisiting of two CJKV + // ideographs + {L"\x4F60\x597D", true, 0, 0}, + // A valid Korean word (meaning "hello") consisting of five hangul + // syllables + {L"\xC548\xB155\xD558\xC138\xC694", true, 0, 0}, + // A valid Japanese word (meaning "hello") consisting of five Hiragana + // letters + {L"\x3053\x3093\x306B\x3061\x306F", true, 0, 0}, + // A valid Hindi word (meaning ?) consisting of six Devanagari letters + // (This word is copied from "http://b/issue?id=857583".) + {L"\x0930\x093E\x091C\x0927\x093E\x0928", true, 0, 0}, + // A valid English word "affix" using a Latin ligature 'ffi' + {L"a\xFB03x", true, 0, 0}, + // A valid English word "hello" (fullwidth version) + {L"\xFF28\xFF45\xFF4C\xFF4C\xFF4F", true, 0, 0}, + // Two valid Greek words (meaning "hello") consisting of seven Greek + // letters + {L"\x03B3\x03B5\x03B9\x03AC" L" " L"\x03C3\x03BF\x03C5", true, 0, 0}, + // A valid Russian word (meainng "hello") consisting of twelve Cyrillic + // letters + {L"\x0437\x0434\x0440\x0430\x0432\x0441" + L"\x0442\x0432\x0443\x0439\x0442\x0435", true, 0, 0}, + // A valid English contraction + {L"isn't", true, 0, 0}, + // A valid English word enclosed with underscores. + {L"_hello_", true, 0, 0}, + + // A valid English word with a preceding whitespace + {L" " L"hello", true, 0, 0}, + // A valid English word with a preceding no-break space + {L"\xA0" L"hello", true, 0, 0}, + // A valid English word with a preceding ideographic space + {L"\x3000" L"hello", true, 0, 0}, + // A valid English word with a preceding Chinese word + {L"\x4F60\x597D" L"hello", true, 0, 0}, + // [ROBUSTNESS] A valid English word with a preceding Korean word + {L"\xC548\xB155\xD558\xC138\xC694" L"hello", true, 0, 0}, + // A valid English word with a preceding Japanese word + {L"\x3053\x3093\x306B\x3061\x306F" L"hello", true, 0, 0}, + // [ROBUSTNESS] A valid English word with a preceding Hindi word + {L"\x0930\x093E\x091C\x0927\x093E\x0928" L"hello", true, 0, 0}, + // [ROBUSTNESS] A valid English word with two preceding Greek words + {L"\x03B3\x03B5\x03B9\x03AC" L" " L"\x03C3\x03BF\x03C5" + L"hello", true, 0, 0}, + // [ROBUSTNESS] A valid English word with a preceding Russian word + {L"\x0437\x0434\x0440\x0430\x0432\x0441" + L"\x0442\x0432\x0443\x0439\x0442\x0435" L"hello", true, 0, 0}, + + // A valid English word with a following whitespace + {L"hello" L" ", true, 0, 0}, + // A valid English word with a following no-break space + {L"hello" L"\xA0", true, 0, 0}, + // A valid English word with a following ideographic space + {L"hello" L"\x3000", true, 0, 0}, + // A valid English word with a following Chinese word + {L"hello" L"\x4F60\x597D", true, 0, 0}, + // [ROBUSTNESS] A valid English word with a following Korean word + {L"hello" L"\xC548\xB155\xD558\xC138\xC694", true, 0, 0}, + // A valid English word with a following Japanese word + {L"hello" L"\x3053\x3093\x306B\x3061\x306F", true, 0, 0}, + // [ROBUSTNESS] A valid English word with a following Hindi word + {L"hello" L"\x0930\x093E\x091C\x0927\x093E\x0928", true, 0, 0}, + // [ROBUSTNESS] A valid English word with two following Greek words + {L"hello" + L"\x03B3\x03B5\x03B9\x03AC" L" " L"\x03C3\x03BF\x03C5", true, 0, 0}, + // [ROBUSTNESS] A valid English word with a following Russian word + {L"hello" L"\x0437\x0434\x0440\x0430\x0432\x0441" + L"\x0442\x0432\x0443\x0439\x0442\x0435", true, 0, 0}, + + // Two valid English words concatenated with a whitespace + {L"hello" L" " L"hello", true, 0, 0}, + // Two valid English words concatenated with a no-break space + {L"hello" L"\xA0" L"hello", true, 0, 0}, + // Two valid English words concatenated with an ideographic space + {L"hello" L"\x3000" L"hello", true, 0, 0}, + // Two valid English words concatenated with a Chinese word + {L"hello" L"\x4F60\x597D" L"hello", true, 0, 0}, + // [ROBUSTNESS] Two valid English words concatenated with a Korean word + {L"hello" L"\xC548\xB155\xD558\xC138\xC694" L"hello", true, 0, 0}, + // Two valid English words concatenated with a Japanese word + {L"hello" L"\x3053\x3093\x306B\x3061\x306F" L"hello", true, 0, 0}, + // [ROBUSTNESS] Two valid English words concatenated with a Hindi word + {L"hello" L"\x0930\x093E\x091C\x0927\x093E\x0928" L"hello" , true, 0, 0}, + // [ROBUSTNESS] Two valid English words concatenated with two Greek words + {L"hello" L"\x03B3\x03B5\x03B9\x03AC" L" " L"\x03C3\x03BF\x03C5" + L"hello", true, 0, 0}, + // [ROBUSTNESS] Two valid English words concatenated with a Russian word + {L"hello" L"\x0437\x0434\x0440\x0430\x0432\x0441" + L"\x0442\x0432\x0443\x0439\x0442\x0435" L"hello", true, 0, 0}, + // [ROBUSTNESS] Two valid English words concatenated with a contraction + // character. + {L"hello:hello", true, 0, 0}, + + // An invalid English word + {L"ifmmp", false, 0, 5}, + // An invalid English word "bffly" containing a Latin ligature 'ffl' + {L"b\xFB04y", false, 0, 3}, + // An invalid English word "ifmmp" (fullwidth version) + {L"\xFF29\xFF46\xFF4D\xFF4D\xFF50", false, 0, 5}, + // An invalid English contraction + {L"jtm'u", false, 0, 5}, + // An invalid English word enclosed with underscores. + {L"_ifmmp_", false, 1, 5}, + + // An invalid English word with a preceding whitespace + {L" " L"ifmmp", false, 1, 5}, + // An invalid English word with a preceding no-break space + {L"\xA0" L"ifmmp", false, 1, 5}, + // An invalid English word with a preceding ideographic space + {L"\x3000" L"ifmmp", false, 1, 5}, + // An invalid English word with a preceding Chinese word + {L"\x4F60\x597D" L"ifmmp", false, 2, 5}, + // [ROBUSTNESS] An invalid English word with a preceding Korean word + {L"\xC548\xB155\xD558\xC138\xC694" L"ifmmp", false, 5, 5}, + // An invalid English word with a preceding Japanese word + {L"\x3053\x3093\x306B\x3061\x306F" L"ifmmp", false, 5, 5}, + // [ROBUSTNESS] An invalid English word with a preceding Hindi word + {L"\x0930\x093E\x091C\x0927\x093E\x0928" L"ifmmp", false, 6, 5}, + // [ROBUSTNESS] An invalid English word with two preceding Greek words + {L"\x03B3\x03B5\x03B9\x03AC" L" " L"\x03C3\x03BF\x03C5" + L"ifmmp", false, 8, 5}, + // [ROBUSTNESS] An invalid English word with a preceding Russian word + {L"\x0437\x0434\x0440\x0430\x0432\x0441" + L"\x0442\x0432\x0443\x0439\x0442\x0435" L"ifmmp", false, 12, 5}, + + // An invalid English word with a following whitespace + {L"ifmmp" L" ", false, 0, 5}, + // An invalid English word with a following no-break space + {L"ifmmp" L"\xA0", false, 0, 5}, + // An invalid English word with a following ideographic space + {L"ifmmp" L"\x3000", false, 0, 5}, + // An invalid English word with a following Chinese word + {L"ifmmp" L"\x4F60\x597D", false, 0, 5}, + // [ROBUSTNESS] An invalid English word with a following Korean word + {L"ifmmp" L"\xC548\xB155\xD558\xC138\xC694", false, 0, 5}, + // An invalid English word with a following Japanese word + {L"ifmmp" L"\x3053\x3093\x306B\x3061\x306F", false, 0, 5}, + // [ROBUSTNESS] An invalid English word with a following Hindi word + {L"ifmmp" L"\x0930\x093E\x091C\x0927\x093E\x0928", false, 0, 5}, + // [ROBUSTNESS] An invalid English word with two following Greek words + {L"ifmmp" + L"\x03B3\x03B5\x03B9\x03AC" L" " L"\x03C3\x03BF\x03C5", false, 0, 5}, + // [ROBUSTNESS] An invalid English word with a following Russian word + {L"ifmmp" L"\x0437\x0434\x0440\x0430\x0432\x0441" + L"\x0442\x0432\x0443\x0439\x0442\x0435", false, 0, 5}, + + // Two invalid English words concatenated with a whitespace + {L"ifmmp" L" " L"ifmmp", false, 0, 5}, + // Two invalid English words concatenated with a no-break space + {L"ifmmp" L"\xA0" L"ifmmp", false, 0, 5}, + // Two invalid English words concatenated with an ideographic space + {L"ifmmp" L"\x3000" L"ifmmp", false, 0, 5}, + // Two invalid English words concatenated with a Chinese word + {L"ifmmp" L"\x4F60\x597D" L"ifmmp", false, 0, 5}, + // [ROBUSTNESS] Two invalid English words concatenated with a Korean word + {L"ifmmp" L"\xC548\xB155\xD558\xC138\xC694" L"ifmmp", false, 0, 5}, + // Two invalid English words concatenated with a Japanese word + {L"ifmmp" L"\x3053\x3093\x306B\x3061\x306F" L"ifmmp", false, 0, 5}, + // [ROBUSTNESS] Two invalid English words concatenated with a Hindi word + {L"ifmmp" L"\x0930\x093E\x091C\x0927\x093E\x0928" L"ifmmp" , false, 0, 5}, + // [ROBUSTNESS] Two invalid English words concatenated with two Greek words + {L"ifmmp" L"\x03B3\x03B5\x03B9\x03AC" L" " L"\x03C3\x03BF\x03C5" + L"ifmmp", false, 0, 5}, + // [ROBUSTNESS] Two invalid English words concatenated with a Russian word + {L"ifmmp" L"\x0437\x0434\x0440\x0430\x0432\x0441" + L"\x0442\x0432\x0443\x0439\x0442\x0435" L"ifmmp", false, 0, 5}, + // [ROBUSTNESS] Two invalid English words concatenated with a contraction + // character. + {L"ifmmp:ifmmp", false, 0, 11}, + + // [REGRESSION] Issue 13432: "Any word of 13 or 14 characters is not + // spellcheck" <http://crbug.com/13432>. + {L"qwertyuiopasd", false, 0, 13}, + {L"qwertyuiopasdf", false, 0, 14}, + }; + + for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) { + size_t input_length = 0; + if (kTestCases[i].input != NULL) { + input_length = wcslen(kTestCases[i].input); + } + int misspelling_start; + int misspelling_length; + bool result = spell_check()->SpellCheckWord( + WideToUTF16(kTestCases[i].input).c_str(), + static_cast<int>(input_length), + 0, + &misspelling_start, + &misspelling_length, NULL); + + EXPECT_EQ(kTestCases[i].expected_result, result); + EXPECT_EQ(kTestCases[i].misspelling_start, misspelling_start); + EXPECT_EQ(kTestCases[i].misspelling_length, misspelling_length); + } +} + +TEST_F(SpellCheckTest, SpellCheckSuggestions_EN_US) { + static const struct { + // A string to be tested. + const wchar_t* input; + // An expected result for this test case. + // * true: the input string does not have any invalid words. + // * false: the input string has one or more invalid words. + bool expected_result; + // The position and the length of the first invalid word. + int misspelling_start; + int misspelling_length; + + // A suggested word that should occur. + const wchar_t* suggested_word; + } kTestCases[] = { + {L"ello", false, 0, 0, L"hello"}, + {L"ello", false, 0, 0, L"cello"}, + {L"wate", false, 0, 0, L"water"}, + {L"wate", false, 0, 0, L"waste"}, + {L"wate", false, 0, 0, L"sate"}, + {L"wate", false, 0, 0, L"ate"}, + {L"jum", false, 0, 0, L"jump"}, + {L"jum", false, 0, 0, L"hum"}, + {L"jum", false, 0, 0, L"sum"}, + {L"jum", false, 0, 0, L"um"}, + // TODO (Sidchat): add many more examples. + }; + + for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) { + std::vector<string16> suggestions; + size_t input_length = 0; + if (kTestCases[i].input != NULL) { + input_length = wcslen(kTestCases[i].input); + } + int misspelling_start; + int misspelling_length; + bool result = spell_check()->SpellCheckWord( + WideToUTF16(kTestCases[i].input).c_str(), + static_cast<int>(input_length), + 0, + &misspelling_start, + &misspelling_length, + &suggestions); + + // Check for spelling. + EXPECT_EQ(kTestCases[i].expected_result, result); + + // Check if the suggested words occur. + bool suggested_word_is_present = false; + for (int j=0; j < static_cast<int>(suggestions.size()); j++) { + if (suggestions.at(j).compare(WideToUTF16(kTestCases[i].suggested_word)) + == 0) { + suggested_word_is_present = true; + break; + } + } + + EXPECT_TRUE(suggested_word_is_present); + } +} + +// This test verifies our spellchecker can split a text into words and check +// the spelling of each word in the text. +TEST_F(SpellCheckTest, SpellCheckText) { + static const struct { + const char* language; + const wchar_t* input; + } kTestCases[] = { + { + // Catalan + "ca-ES", + L"La missi\x00F3 de Google \x00E9s organitzar la informaci\x00F3 " + L"del m\x00F3n i fer que sigui \x00FAtil i accessible universalment." + }, { + // Czech + "cs-CZ", + L"Posl\x00E1n\x00EDm spole\x010Dnosti Google je " + L"uspo\x0159\x00E1\x0064\x0061t informace z cel\x00E9ho sv\x011Bta " + L"tak, aby byly v\x0161\x0065obecn\x011B p\x0159\x00EDstupn\x00E9 " + L"a u\x017Eite\x010Dn\x00E9." + }, { + // Danish + "da-DK", + L"Googles " + L"mission er at organisere verdens information og g\x00F8re den " + L"almindeligt tilg\x00E6ngelig og nyttig." + }, { + // German + "de-DE", + L"Das Ziel von Google besteht darin, die auf der Welt vorhandenen " + L"Informationen zu organisieren und allgemein zug\x00E4nglich und " + L"nutzbar zu machen." + }, { + // Greek + "el-GR", + L"\x0391\x03C0\x03BF\x03C3\x03C4\x03BF\x03BB\x03AE " + L"\x03C4\x03B7\x03C2 Google \x03B5\x03AF\x03BD\x03B1\x03B9 " + L"\x03BD\x03B1 \x03BF\x03C1\x03B3\x03B1\x03BD\x03CE\x03BD\x03B5\x03B9 " + L"\x03C4\x03B9\x03C2 " + L"\x03C0\x03BB\x03B7\x03C1\x03BF\x03C6\x03BF\x03C1\x03AF\x03B5\x03C2 " + L"\x03C4\x03BF\x03C5 \x03BA\x03CC\x03C3\x03BC\x03BF\x03C5 " + L"\x03BA\x03B1\x03B9 \x03BD\x03B1 \x03C4\x03B9\x03C2 " + L"\x03BA\x03B1\x03B8\x03B9\x03C3\x03C4\x03AC " + L"\x03C0\x03C1\x03BF\x03C3\x03B2\x03AC\x03C3\x03B9\x03BC\x03B5\x03C2 " + L"\x03BA\x03B1\x03B9 \x03C7\x03C1\x03AE\x03C3\x03B9\x03BC\x03B5\x03C2." + }, { + // English (Australia) + "en-AU", + // L"Google's " - to be added. + L"mission is to organise the world's information and make it " + L"universally accessible and useful." + }, { + // English (United Kingdom) + "en-GB", + // L"Google's " - to be added. + L"mission is to organise the world's information and make it " + L"universally accessible and useful." + }, { + // English (United States) + "en-US", + L"Google's mission is to organize the world's information and make it " + L"universally accessible and useful." + }, { + // Spanish + "es-ES", + L"La misi\x00F3n de " + // L"Google" - to be added. + L" es organizar la informaci\x00F3n mundial " + L"para que resulte universalmente accesible y \x00FAtil." + }, { + // Estonian + "et-EE", + // L"Google'ile " - to be added. + L"\x00FClesanne on korraldada maailma teavet ja teeb selle " + L"k\x00F5igile k\x00E4ttesaadavaks ja kasulikuks.", + }, { + // French + "fr-FR", + L"Google a pour mission d'organiser les informations \x00E0 " + L"l'\x00E9\x0063helle mondiale dans le but de les rendre accessibles " + L"et utiles \x00E0 tous." + }, { + // Hebrew + "he-IL", + L"\x05D4\x05DE\x05E9\x05D9\x05DE\x05D4 \x05E9\x05DC Google " + L"\x05D4\x05D9\x05D0 \x05DC\x05D0\x05E8\x05D2\x05DF " + L"\x05D0\x05EA \x05D4\x05DE\x05D9\x05D3\x05E2 " + L"\x05D4\x05E2\x05D5\x05DC\x05DE\x05D9 " + L"\x05D5\x05DC\x05D4\x05E4\x05D5\x05DA \x05D0\x05D5\x05EA\x05D5 " + L"\x05DC\x05D6\x05DE\x05D9\x05DF " + L"\x05D5\x05E9\x05D9\x05DE\x05D5\x05E9\x05D9 \x05D1\x05DB\x05DC " + L"\x05D4\x05E2\x05D5\x05DC\x05DD." + }, { + // Hindi + "hi-IN", + L"Google \x0915\x093E \x092E\x093F\x0936\x0928 " + L"\x0926\x0941\x0928\x093F\x092F\x093E \x0915\x0940 " + L"\x091C\x093E\x0928\x0915\x093E\x0930\x0940 \x0915\x094B " + L"\x0935\x094D\x092F\x0935\x0938\x094D\x0925\x093F\x0924 " + L"\x0915\x0930\x0928\x093E \x0914\x0930 \x0909\x0938\x0947 " + L"\x0938\x093E\x0930\x094D\x0935\x092D\x094C\x092E\x093F\x0915 " + L"\x0930\x0942\x092A \x0938\x0947 \x092A\x0939\x0941\x0901\x091A " + L"\x092E\x0947\x0902 \x0914\x0930 \x0909\x092A\x092F\x094B\x0917\x0940 " + L"\x092C\x0928\x093E\x0928\x093E \x0939\x0948." + }, { + // Croatian + "hr-HR", + // L"Googleova " - to be added. + L"je misija organizirati svjetske informacije i u\x010Diniti ih " + // L"univerzalno " - to be added. + L"pristupa\x010Dnima i korisnima." + }, { + // Indonesian + "id-ID", + L"Misi Google adalah untuk mengelola informasi dunia dan membuatnya " + L"dapat diakses dan bermanfaat secara universal." + }, { + // Italian + "it-IT", + L"La missione di Google \x00E8 organizzare le informazioni a livello " + L"mondiale e renderle universalmente accessibili e fruibili." + }, { + // Lithuanian + "lt-LT", + L"\x201EGoogle\x201C tikslas \x2013 rinkti ir sisteminti pasaulio " + L"informacij\x0105 bei padaryti j\x0105 prieinam\x0105 ir " + L"nauding\x0105 visiems." + }, { + // Latvian + "lv-LV", + L"Google uzdevums ir k\x0101rtot pasaules inform\x0101" + L"ciju un padar\x012Bt to univers\x0101li pieejamu un noder\x012Bgu." + }, { + // Norwegian + "nb-NO", + // L"Googles " - to be added. + L"m\x00E5l er \x00E5 organisere informasjonen i verden og " + L"gj\x00F8re den tilgjengelig og nyttig for alle." + }, { + // Dutch + "nl-NL", + L"Het doel van Google is om alle informatie wereldwijd toegankelijk " + L"en bruikbaar te maken." + }, { + // Polish + "pl-PL", + L"Misj\x0105 Google jest uporz\x0105" L"dkowanie \x015Bwiatowych " + L"zasob\x00F3w informacji, aby sta\x0142y si\x0119 one powszechnie " + L"dost\x0119pne i u\x017Cyteczne." + }, { + // Portuguese (Brazil) + "pt-BR", + L"A miss\x00E3o do " +#if !defined(OS_MACOSX) + L"Google " +#endif + L"\x00E9 organizar as informa\x00E7\x00F5" + L"es do mundo todo e " +#if !defined(OS_MACOSX) + L"torn\x00E1-las " +#endif + L"acess\x00EDveis e " + // L"\x00FAteis " - to be added. + L"em car\x00E1ter universal." + }, { + // Portuguese (Portugal) + "pt-PT", + L"O " +#if !defined(OS_MACOSX) + L"Google " +#endif + L"tem por miss\x00E3o organizar a informa\x00E7\x00E3o do " + L"mundo e " +#if !defined(OS_MACOSX) + L"torn\x00E1-la " +#endif + L"universalmente acess\x00EDvel e \x00FAtil" + }, { + // Romanian + "ro-RO", + L"Misiunea Google este de " + // L"a " - to be added. + L"organiza informa\x0163iile lumii \x015Fi de " + // L"a " - to be added. + L"le face accesibile \x015Fi utile la nivel universal." + }, { + // Russian + "ru-RU", + L"\x041C\x0438\x0441\x0441\x0438\x044F Google " + L"\x0441\x043E\x0441\x0442\x043E\x0438\x0442 \x0432 " + L"\x043E\x0440\x0433\x0430\x043D\x0438\x0437\x0430\x0446\x0438\x0438 " + L"\x043C\x0438\x0440\x043E\x0432\x043E\x0439 " + L"\x0438\x043D\x0444\x043E\x0440\x043C\x0430\x0446\x0438\x0438, " + L"\x043E\x0431\x0435\x0441\x043F\x0435\x0447\x0435\x043D\x0438\x0438 " + L"\x0435\x0435 " + L"\x0434\x043E\x0441\x0442\x0443\x043F\x043D\x043E\x0441\x0442\x0438 " + L"\x0438 \x043F\x043E\x043B\x044C\x0437\x044B \x0434\x043B\x044F " + L"\x0432\x0441\x0435\x0445." + }, { + // Slovak + "sk-SK", + L"Spolo\x010Dnos\x0165 Google si dala za \x00FAlohu usporiada\x0165 " + L"inform\x00E1\x0063ie " + L"z cel\x00E9ho sveta a zabezpe\x010Di\x0165, " + L"aby boli v\x0161eobecne dostupn\x00E9 a u\x017Eito\x010Dn\x00E9." + }, { + // Slovenian + "sl-SI", + // L"Googlovo " - to be added. + L"poslanstvo je organizirati svetovne informacije in " + L"omogo\x010Diti njihovo dostopnost in s tem uporabnost za vse." + }, { + // Swedish + "sv-SE", + L"Googles m\x00E5ls\x00E4ttning \x00E4r att ordna v\x00E4rldens " + L"samlade information och g\x00F6ra den tillg\x00E4nglig f\x00F6r alla." + }, { + // Turkish + "tr-TR", + // L"Google\x2019\x0131n " - to be added. + L"misyonu, d\x00FCnyadaki t\x00FCm bilgileri " + L"organize etmek ve evrensel olarak eri\x015Filebilir ve " + L"kullan\x0131\x015Fl\x0131 k\x0131lmakt\x0131r." + }, { + // Vietnamese + "vi-VN", + L"Nhi\x1EC7m v\x1EE5 c\x1EE7\x0061 " + L"Google la \x0111\x1EC3 t\x1ED5 ch\x1EE9\x0063 " + L"c\x00E1\x0063 th\x00F4ng tin c\x1EE7\x0061 " + L"th\x1EBF gi\x1EDBi va l\x00E0m cho n\x00F3 universal c\x00F3 " + L"th\x1EC3 truy c\x1EADp va h\x1EEFu d\x1EE5ng h\x01A1n." + }, + }; + + for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) { + ReinitializeSpellCheck(kTestCases[i].language); + size_t input_length = 0; + if (kTestCases[i].input != NULL) + input_length = wcslen(kTestCases[i].input); + + int misspelling_start = 0; + int misspelling_length = 0; + bool result = spell_check()->SpellCheckWord( + WideToUTF16(kTestCases[i].input).c_str(), + static_cast<int>(input_length), + 0, + &misspelling_start, + &misspelling_length, NULL); + + EXPECT_EQ(true, result) << kTestCases[i].language; + EXPECT_EQ(0, misspelling_start); + EXPECT_EQ(0, misspelling_length); + } +} + +TEST_F(SpellCheckTest, GetAutoCorrectionWord_EN_US) { + static const struct { + // A misspelled word. + const char* input; + + // An expected result for this test case. + // Should be an empty string if there are no suggestions for auto correct. + const char* expected_result; + } kTestCases[] = { + {"teh", "the"}, + {"moer", "more"}, + {"watre", "water"}, + {"noen", ""}, + {"what", ""}, + }; + spell_check()->EnableAutoSpellCorrect(true); + + for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) { + string16 misspelled_word(UTF8ToUTF16(kTestCases[i].input)); + string16 expected_autocorrect_word( + UTF8ToUTF16(kTestCases[i].expected_result)); + string16 autocorrect_word = spell_check()->GetAutoCorrectionWord( + misspelled_word, 0); + + // Check for spelling. + EXPECT_EQ(expected_autocorrect_word, autocorrect_word); + } +} + +} // namespace |