summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/spellchecker
diff options
context:
space:
mode:
authorgroby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-03 04:43:02 +0000
committergroby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-03 04:43:02 +0000
commitcfadadda51529137a8c9462a1f7247e92208fc92 (patch)
tree33ad23e1772e2f43a093e2ff983565bb0de37515 /chrome/renderer/spellchecker
parent56cc3804359e5e20de19615bd8d591348721e799 (diff)
downloadchromium_src-cfadadda51529137a8c9462a1f7247e92208fc92.zip
chromium_src-cfadadda51529137a8c9462a1f7247e92208fc92.tar.gz
chromium_src-cfadadda51529137a8c9462a1f7247e92208fc92.tar.bz2
[spellcheck] turn on async spellchecking for OSX.
Enabling this path gets us one step closer to server-side spell checking. R=rlp@chromium.org BUG=178241 Review URL: https://chromiumcodereview.appspot.com/12742017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191983 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/spellchecker')
-rw-r--r--chrome/renderer/spellchecker/spellcheck.cc3
-rw-r--r--chrome/renderer/spellchecker/spellcheck_provider.cc7
2 files changed, 6 insertions, 4 deletions
diff --git a/chrome/renderer/spellchecker/spellcheck.cc b/chrome/renderer/spellchecker/spellcheck.cc
index 0fadda7..d17d9e0 100644
--- a/chrome/renderer/spellchecker/spellcheck.cc
+++ b/chrome/renderer/spellchecker/spellcheck.cc
@@ -205,6 +205,9 @@ bool SpellCheck::SpellCheckParagraph(
results->assign(textcheck_results);
return false;
#else
+ // This function is only invoked for spell checker functionality that runs
+ // on the render thread. OSX builds don't have that.
+ NOTREACHED();
return true;
#endif
}
diff --git a/chrome/renderer/spellchecker/spellcheck_provider.cc b/chrome/renderer/spellchecker/spellcheck_provider.cc
index de4adf2..a1820d8 100644
--- a/chrome/renderer/spellchecker/spellcheck_provider.cc
+++ b/chrome/renderer/spellchecker/spellcheck_provider.cc
@@ -159,17 +159,16 @@ void SpellCheckProvider::checkTextOfParagraph(
const WebKit::WebString& text,
WebKit::WebTextCheckingTypeMask mask,
WebKit::WebVector<WebKit::WebTextCheckingResult>* results) {
-#if !defined(OS_MACOSX)
- // Since Mac has its own spell checker, this method will not be used on Mac.
-
if (!results)
return;
if (!(mask & WebKit::WebTextCheckingTypeSpelling))
return;
+ // TODO(groby): As far as I can tell, this method is never invoked.
+ // UMA results seem to support that. Investigate, clean up if true.
+ NOTREACHED();
spellcheck_->SpellCheckParagraph(string16(text), results);
-#endif
UMA_HISTOGRAM_COUNTS("SpellCheck.api.paragraph", text.length());
}