diff options
| author | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-23 04:14:45 +0000 |
|---|---|---|
| committer | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-23 04:14:45 +0000 |
| commit | 661a77d6cc015f395b8ae2f1188cb678364aabb6 (patch) | |
| tree | 8c734f7d80f5d7c47e3085a16d5d1fd81a204c7b /chrome/renderer | |
| parent | d2989ea4e51bdd16e63aca998728869bcf21085b (diff) | |
| download | chromium_src-661a77d6cc015f395b8ae2f1188cb678364aabb6.zip chromium_src-661a77d6cc015f395b8ae2f1188cb678364aabb6.tar.gz chromium_src-661a77d6cc015f395b8ae2f1188cb678364aabb6.tar.bz2 | |
[Coverity] Prevent negative loop bound
GetFrameCount() can return -1, if the DeadCheck on the StackTrace's isolate fails.
Treat that the same way as an empty StackTrace
CID=106037
BUG=none
R=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11188069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163488 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer')
| -rw-r--r-- | chrome/renderer/extensions/dispatcher.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc index eab2397..6ba816f 100644 --- a/chrome/renderer/extensions/dispatcher.cc +++ b/chrome/renderer/extensions/dispatcher.cc @@ -252,7 +252,7 @@ class LoggingNativeHandler : public NativeHandler { v8::Handle<v8::StackTrace> stack_trace = v8::StackTrace::CurrentStackTrace(10); - if (stack_trace.IsEmpty() || stack_trace->GetFrameCount() == 0) { + if (stack_trace.IsEmpty() || stack_trace->GetFrameCount() <= 0) { error_message += "\n <no stack trace>"; } else { for (size_t i = 0; i < (size_t) stack_trace->GetFrameCount(); ++i) { |