diff options
author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-03 04:26:52 +0000 |
---|---|---|
committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-03 04:26:52 +0000 |
commit | c80b8ee2e4a157c905c4ac19b97ac78eb4253b6c (patch) | |
tree | a6bb541a20fd4a2a329ebd8c66b185e65beb4c8d /chrome/renderer | |
parent | fd4f2300ec01e4dbe66c9e91c5d9796db1810641 (diff) | |
download | chromium_src-c80b8ee2e4a157c905c4ac19b97ac78eb4253b6c.zip chromium_src-c80b8ee2e4a157c905c4ac19b97ac78eb4253b6c.tar.gz chromium_src-c80b8ee2e4a157c905c4ac19b97ac78eb4253b6c.tar.bz2 |
Silently swallow exceptions in extension bindings callbacks.
There are better ways to handle this, but I want a really
simple patch for merge.
BUG=106201
TEST=http://code.google.com/p/chromium/issues/detail?id=100401#c18
Review URL: http://codereview.chromium.org/8786008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112869 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer')
-rw-r--r-- | chrome/renderer/extensions/chrome_v8_context.cc | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/chrome/renderer/extensions/chrome_v8_context.cc b/chrome/renderer/extensions/chrome_v8_context.cc index 3e4a709..525c51e 100644 --- a/chrome/renderer/extensions/chrome_v8_context.cc +++ b/chrome/renderer/extensions/chrome_v8_context.cc @@ -83,7 +83,6 @@ bool ChromeV8Context::CallChromeHiddenMethod( v8::Handle<v8::Value>* argv, v8::Handle<v8::Value>* result) const { v8::Context::Scope context_scope(v8_context_); - v8::TryCatch try_catch; // Look up the function name, which may be a sub-property like // "Port.dispatchOnMessage" in the hidden global variable. @@ -97,10 +96,6 @@ bool ChromeV8Context::CallChromeHiddenMethod( if (!value.IsEmpty() && value->IsObject()) { value = v8::Local<v8::Object>::Cast(value)->Get( v8::String::New(components[i].c_str())); - if (try_catch.HasCaught()) { - NOTREACHED() << *v8::String::AsciiValue(try_catch.Exception()); - return false; - } } } @@ -111,10 +106,6 @@ bool ChromeV8Context::CallChromeHiddenMethod( v8::Handle<v8::Value> result_temp = v8::Local<v8::Function>::Cast(value)->Call(v8::Object::New(), argc, argv); - if (try_catch.HasCaught()) { - NOTREACHED() << *v8::String::AsciiValue(try_catch.Exception()); - return false; - } if (result) *result = result_temp; return true; |