diff options
| author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-02 15:31:56 +0000 |
|---|---|---|
| committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-02 15:31:56 +0000 |
| commit | d583c3a30db9474b0dcef5128ec6901c8ff23b98 (patch) | |
| tree | 227db6cd60ac59d5e4990d1afa9de091af5295db /chrome/service | |
| parent | 4bacb82375e04d44967e71afc1fa6e1018f9810b (diff) | |
| download | chromium_src-d583c3a30db9474b0dcef5128ec6901c8ff23b98.zip chromium_src-d583c3a30db9474b0dcef5128ec6901c8ff23b98.tar.gz chromium_src-d583c3a30db9474b0dcef5128ec6901c8ff23b98.tar.bz2 | |
Thread::Stop() must be called before any subclass's destructor completes.
Update base::Thread documentation, fix all subclasses I could find
that had a problem, and remove no-longer-necessary suppressions.
BUG=102134
Review URL: http://codereview.chromium.org/8427007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108296 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/service')
| -rw-r--r-- | chrome/service/service_process.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/service/service_process.cc b/chrome/service/service_process.cc index 03c6296..5088334 100644 --- a/chrome/service/service_process.cc +++ b/chrome/service/service_process.cc @@ -62,8 +62,6 @@ class ServiceIOThread : public base::Thread { ServiceIOThread::ServiceIOThread(const char* name) : base::Thread(name) {} ServiceIOThread::~ServiceIOThread() { - // We cannot rely on our base class to stop the thread since we want our - // CleanUp function to run. Stop(); } |