diff options
author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-25 20:14:29 +0000 |
---|---|---|
committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-25 20:14:29 +0000 |
commit | a4fe67013ea54ca4f550d8c27b55b180fe0c4a70 (patch) | |
tree | a2eb4697a22a3ea49aeece7a395286a6e84fda0f /chrome/test/base/in_process_browser_test.cc | |
parent | f82480eb8c899f51177505494a485587c60e7ad4 (diff) | |
download | chromium_src-a4fe67013ea54ca4f550d8c27b55b180fe0c4a70.zip chromium_src-a4fe67013ea54ca4f550d8c27b55b180fe0c4a70.tar.gz chromium_src-a4fe67013ea54ca4f550d8c27b55b180fe0c4a70.tar.bz2 |
Consolidate Browser Creation.
. Make all instantiators use a single ctor that takes CreateParams.
. Get rid of InitBrowserWindow() and make CreateBrowserWindow() a anonymous namespace function in browser.cc
http://crbug.com/133576
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10692195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148396 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/base/in_process_browser_test.cc')
-rw-r--r-- | chrome/test/base/in_process_browser_test.cc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/chrome/test/base/in_process_browser_test.cc b/chrome/test/base/in_process_browser_test.cc index f3fa9a5..f493a3a 100644 --- a/chrome/test/base/in_process_browser_test.cc +++ b/chrome/test/base/in_process_browser_test.cc @@ -237,22 +237,22 @@ bool InProcessBrowserTest::SetUpUserDataDirectory() { // Creates a browser with a single tab (about:blank), waits for the tab to // finish loading and shows the browser. Browser* InProcessBrowserTest::CreateBrowser(Profile* profile) { - Browser* browser = Browser::Create(profile); + Browser* browser = new Browser(Browser::CreateParams(profile)); AddBlankTabAndShow(browser); return browser; } Browser* InProcessBrowserTest::CreateIncognitoBrowser() { // Create a new browser with using the incognito profile. - Browser* incognito = - Browser::Create(browser()->profile()->GetOffTheRecordProfile()); + Browser* incognito = new Browser( + Browser::CreateParams(browser()->profile()->GetOffTheRecordProfile())); AddBlankTabAndShow(incognito); return incognito; } Browser* InProcessBrowserTest::CreateBrowserForPopup(Profile* profile) { - Browser* browser = Browser::CreateWithParams( - Browser::CreateParams(Browser::TYPE_POPUP, profile)); + Browser* browser = + new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile)); AddBlankTabAndShow(browser); return browser; } @@ -260,7 +260,7 @@ Browser* InProcessBrowserTest::CreateBrowserForPopup(Profile* profile) { Browser* InProcessBrowserTest::CreateBrowserForApp( const std::string& app_name, Profile* profile) { - Browser* browser = Browser::CreateWithParams( + Browser* browser = new Browser( Browser::CreateParams::CreateForApp( Browser::TYPE_POPUP, app_name, gfx::Rect(), profile)); AddBlankTabAndShow(browser); |