diff options
| author | nyquist <nyquist@chromium.org> | 2016-03-08 00:01:50 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-08 08:04:10 +0000 |
| commit | 04f19da143d8d119b781cfa1574c3acc47e4c61c (patch) | |
| tree | 604213642c09c045f2fca164d81835e7ae085eee /chrome/test/base/v8_unit_test.cc | |
| parent | b0c601af8b5c132fa30700842501c19ad2c9583b (diff) | |
| download | chromium_src-04f19da143d8d119b781cfa1574c3acc47e4c61c.zip chromium_src-04f19da143d8d119b781cfa1574c3acc47e4c61c.tar.gz chromium_src-04f19da143d8d119b781cfa1574c3acc47e4c61c.tar.bz2 | |
Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (patchset #5 id:80001 of https://codereview.chromium.org/1743763004/ )
Reason for revert:
Causes content_unittests to fail on GinJavaBridgeValueConverterTest.TypedArrays for Android on a bunch of testers:
Marshmallow Tablet Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/3117
Marshmallow 64 bit Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/1010
Lollipop Tablet Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/2108
Lollipop Phone Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/3403
Lollipop Low-end Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/2681
git bisect succesfully identified this CL as the culprit:
83013584d091473d3a5fee6a823bc63b223a472c is the first bad commit
See http://crbug.com/592906 for details.
Original issue's description:
> Use v8::MicrotasksScope internally in V8RecursionScope.
>
> If this sticks we can just remove V8RecursionScope and WebScopedMicrotaskSuppression,
> along with other cleanups.
>
> BUG=585949
>
> Committed: https://crrev.com/83013584d091473d3a5fee6a823bc63b223a472c
> Cr-Commit-Position: refs/heads/master@{#379574}
TBR=jochen@chromium.org,adamk@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=585949
Review URL: https://codereview.chromium.org/1765423004
Cr-Commit-Position: refs/heads/master@{#379781}
Diffstat (limited to 'chrome/test/base/v8_unit_test.cc')
| -rw-r--r-- | chrome/test/base/v8_unit_test.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/chrome/test/base/v8_unit_test.cc b/chrome/test/base/v8_unit_test.cc index 392ff45..9f52f06 100644 --- a/chrome/test/base/v8_unit_test.cc +++ b/chrome/test/base/v8_unit_test.cc @@ -11,7 +11,6 @@ #include "base/strings/stringprintf.h" #include "chrome/common/chrome_paths.h" #include "third_party/WebKit/public/web/WebKit.h" -#include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h" namespace { @@ -96,7 +95,6 @@ bool V8UnitTest::RunJavascriptTestF(const std::string& test_fixture, v8::Local<v8::Context> context = v8::Local<v8::Context>::New(isolate, context_); v8::Context::Scope context_scope(context); - blink::WebScopedMicrotaskSuppression microtasks_scope; v8::Local<v8::Value> function_property = context->Global()->Get(v8::String::NewFromUtf8(isolate, "runTest")); @@ -211,7 +209,6 @@ void V8UnitTest::ExecuteScriptInContext(const base::StringPiece& script_source, v8::Local<v8::Context> context = v8::Local<v8::Context>::New(isolate, context_); v8::Context::Scope context_scope(context); - blink::WebScopedMicrotaskSuppression microtasks_scope; v8::Local<v8::String> source = v8::String::NewFromUtf8(isolate, script_source.data(), @@ -260,7 +257,6 @@ void V8UnitTest::TestFunction(const std::string& function_name) { v8::Local<v8::Context> context = v8::Local<v8::Context>::New(isolate, context_); v8::Context::Scope context_scope(context); - blink::WebScopedMicrotaskSuppression microtasks_scope; v8::Local<v8::Value> function_property = context->Global()->Get( v8::String::NewFromUtf8(isolate, function_name.c_str())); |