diff options
author | marja@chromium.org <marja@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-06 12:21:03 +0000 |
---|---|---|
committer | marja@chromium.org <marja@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-06 12:21:03 +0000 |
commit | dc3d06e0df22f5684692d025c155dfadc66f56d9 (patch) | |
tree | 3bf1c50bae4b3107a26a69c0941965db3d0310d2 /chrome/test/base/v8_unit_test.cc | |
parent | c93c9c3259784978aa5db248fb0f36a7a04031b1 (diff) | |
download | chromium_src-dc3d06e0df22f5684692d025c155dfadc66f56d9.zip chromium_src-dc3d06e0df22f5684692d025c155dfadc66f56d9.tar.gz chromium_src-dc3d06e0df22f5684692d025c155dfadc66f56d9.tar.bz2 |
Remove more calls to HandleScope default ctor.
It's replaced by a version which takes an isolate. The default ctor will be
removed soon.
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/23679004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221689 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/base/v8_unit_test.cc')
-rw-r--r-- | chrome/test/base/v8_unit_test.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/test/base/v8_unit_test.cc b/chrome/test/base/v8_unit_test.cc index d2aea99..5523c48 100644 --- a/chrome/test/base/v8_unit_test.cc +++ b/chrome/test/base/v8_unit_test.cc @@ -19,7 +19,7 @@ std::string LogArgs2String(const v8::FunctionCallbackInfo<v8::Value>& args) { std::string message; bool first = true; for (int i = 0; i < args.Length(); i++) { - v8::HandleScope handle_scope; + v8::HandleScope handle_scope(v8::Isolate::GetCurrent()); if (first) first = false; else @@ -212,7 +212,7 @@ void V8UnitTest::ExecuteScriptInContext(const base::StringPiece& script_source, std::string V8UnitTest::ExceptionToString(const v8::TryCatch& try_catch) { std::string str; - v8::HandleScope handle_scope; + v8::HandleScope handle_scope(v8::Isolate::GetCurrent()); v8::String::Utf8Value exception(try_catch.Exception()); v8::Local<v8::Message> message(try_catch.Message()); if (message.IsEmpty()) { @@ -260,7 +260,7 @@ void V8UnitTest::Error(const v8::FunctionCallbackInfo<v8::Value>& args) { } void V8UnitTest::ChromeSend(const v8::FunctionCallbackInfo<v8::Value>& args) { - v8::HandleScope handle_scope; + v8::HandleScope handle_scope(v8::Isolate::GetCurrent()); // We expect to receive 2 args: ("testResult", [ok, message]). However, // chrome.send may pass only one. Therefore we need to ensure we have at least // 1, then ensure that the first is "testResult" before checking again for 2. |