summaryrefslogtreecommitdiffstats
path: root/chrome/test/chromedriver
diff options
context:
space:
mode:
authorsamuong <samuong@chromium.org>2015-07-29 14:11:21 -0700
committerCommit bot <commit-bot@chromium.org>2015-07-29 21:11:49 +0000
commit46155b242dc2d31f7fcf699d3b93a9e2781492c7 (patch)
tree81dfadd12d5ec3232d3eb66b7ee6b0c5c4623d88 /chrome/test/chromedriver
parentf2fee6f797514f59269ede88590b3e4ab716d988 (diff)
downloadchromium_src-46155b242dc2d31f7fcf699d3b93a9e2781492c7.zip
chromium_src-46155b242dc2d31f7fcf699d3b93a9e2781492c7.tar.gz
chromium_src-46155b242dc2d31f7fcf699d3b93a9e2781492c7.tar.bz2
[chromedriver] Fix broken testConsoleLogSources test and disable testWaitsForExtensionToLoad.
BUG=chromedriver:1167 Review URL: https://codereview.chromium.org/1266523003 Cr-Commit-Position: refs/heads/master@{#340985}
Diffstat (limited to 'chrome/test/chromedriver')
-rwxr-xr-xchrome/test/chromedriver/test/run_py_tests.py11
1 files changed, 6 insertions, 5 deletions
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index f3241c6..3748731 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -57,6 +57,7 @@ _NEGATIVE_FILTER = [
'ChromeDriverTest.testTouchPinch',
# https://code.google.com/p/chromedriver/issues/detail?id=1167
'ChromeDriverTest.testShouldHandleNewWindowLoadingProperly',
+ 'ChromeExtensionsCapabilityTest.testWaitsForExtensionToLoad',
]
_VERSION_SPECIFIC_FILTER = {}
@@ -721,12 +722,12 @@ class ChromeDriverTest(ChromeDriverBaseTest):
self._driver.Load(self.GetHttpUrlForFile('/chromedriver/console_log.html'))
logs = self._driver.GetLog('browser')
- self.assertEqual('network', logs[0]['source'])
- self.assertTrue('nonexistent.png' in logs[0]['message'])
- self.assertTrue('404' in logs[0]['message'])
+ self.assertEqual('javascript', logs[0]['source'])
+ self.assertTrue('TypeError' in logs[0]['message'])
- self.assertEqual('javascript', logs[1]['source'])
- self.assertTrue('TypeError' in logs[1]['message'])
+ self.assertEqual('network', logs[1]['source'])
+ self.assertTrue('nonexistent.png' in logs[1]['message'])
+ self.assertTrue('404' in logs[1]['message'])
# Sometimes, we also get an error for a missing favicon.
if len(logs) > 2: