summaryrefslogtreecommitdiffstats
path: root/chrome/test/chromedriver
diff options
context:
space:
mode:
authorsamuong <samuong@chromium.org>2015-07-30 00:27:42 -0700
committerCommit bot <commit-bot@chromium.org>2015-07-30 07:28:36 +0000
commit7264ab04772dae793a8137202c2d9199d3610d24 (patch)
tree1661ef72ad4130a96f737ee09884d57268c21371 /chrome/test/chromedriver
parent2384c822ac23e8bd427c65ff5e7edd28d07f8b61 (diff)
downloadchromium_src-7264ab04772dae793a8137202c2d9199d3610d24.zip
chromium_src-7264ab04772dae793a8137202c2d9199d3610d24.tar.gz
chromium_src-7264ab04772dae793a8137202c2d9199d3610d24.tar.bz2
[chromedriver] Enable synthetic gesture tests for chrome_stable on Android.
BUG=448182 TBR=jbudorick@chromium.org Review URL: https://codereview.chromium.org/1262273002 Cr-Commit-Position: refs/heads/master@{#341078}
Diffstat (limited to 'chrome/test/chromedriver')
-rwxr-xr-xchrome/test/chromedriver/test/run_py_tests.py19
1 files changed, 4 insertions, 15 deletions
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index 6c667b68..d8301d6 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -152,16 +152,7 @@ _ANDROID_NEGATIVE_FILTER['chrome'] = (
]
)
_ANDROID_NEGATIVE_FILTER['chrome_stable'] = (
- _ANDROID_NEGATIVE_FILTER['chrome'] + [
- # The stable channel Chrome for Android does not yet support Synthetic
- # Gesture DevTools commands.
- # TODO(samuong): reenable when it does.
- 'ChromeDriverTest.testHasTouchScreen',
- 'ChromeDriverTest.testTouchScrollElement',
- 'ChromeDriverTest.testTouchDoubleTapElement',
- 'ChromeDriverTest.testTouchLongPressElement',
- 'ChromeDriverTest.testTouchPinch',
- ])
+ _ANDROID_NEGATIVE_FILTER['chrome'])
_ANDROID_NEGATIVE_FILTER['chrome_beta'] = (
_ANDROID_NEGATIVE_FILTER['chrome'])
_ANDROID_NEGATIVE_FILTER['chrome_shell'] = (
@@ -1084,14 +1075,12 @@ class ChromeDriverTest(ChromeDriverBaseTest):
self.assertAlmostEqual(2.0, float(width_before_pinch) / width_after_pinch)
def testBrowserDoesntSupportSyntheticGestures(self):
- # The current stable channel Chrome for Android does not support synthetic
- # gesture commands in DevTools, so touch action tests have been disabled for
- # chrome_stable and chromedriver_webview_shell.
+ # WebView on KitKat does not support synthetic gesture commands in DevTools,
+ # so touch action tests have been disabled for chromedriver_webview_shell.
# TODO(samuong): when this test starts failing, re-enable touch tests and
# delete this test.
if _ANDROID_PACKAGE_KEY:
- packages = ['chrome_stable', 'chromedriver_webview_shell']
- if _ANDROID_PACKAGE_KEY in packages:
+ if _ANDROID_PACKAGE_KEY == 'chromedriver_webview_shell':
self.assertFalse(self._driver.capabilities['hasTouchScreen'])
def testHasTouchScreen(self):