summaryrefslogtreecommitdiffstats
path: root/chrome/test/functional/chromeos_basic.py
diff options
context:
space:
mode:
authorpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-29 18:22:55 +0000
committerpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-29 18:22:55 +0000
commita3ed17f804bd3860e1185de139b2d92af1581a1d (patch)
treecacf4de640be2303c3cfa9941a27a7e55e8ae88f /chrome/test/functional/chromeos_basic.py
parent33ad0cecd72a47bdc3f44b85e07189ca7d8c212b (diff)
downloadchromium_src-a3ed17f804bd3860e1185de139b2d92af1581a1d.zip
chromium_src-a3ed17f804bd3860e1185de139b2d92af1581a1d.tar.gz
chromium_src-a3ed17f804bd3860e1185de139b2d92af1581a1d.tar.bz2
ContentSettingImageView cleanup, phase 1.
* Parent classes in alphabetical order. * Overrides as private as possible, and in same order as parent classes. We also keep the .cc file order matching the .h file. * Remove AlwaysDrawText() entirely as it was never called. This also means we can remove |force_draw_text_|. * Inline SetImage(), SetTooltipText(), StartLabelAnimation(), PauseAnimation(), and UnpauseAnimation() into their lone callers. Inline AnimationOnClick() into OnClick() since the two were always called together. * Remove the scoped_ptr<> on |slide_animator_| and initialize it in the constructor, instead of the first time we want to animate. * Eliminate |font_color_| since it was never used. (We will eventually use the color the parent supplies us, so the constructor arg sticks around.) * Separate out three other members that will be going away in the future. Put the other ones into some sort of hopefully-logical order. * DISALLOW_IMPLICIT_CONSTRUCTORS -> DISALLOW_COPY_AND_ASSIGN. The changes in the .cc file are basically just deleting and reordering code, plus "->" to "." conversions for |slide_animator_|. I avoided doing any other cleanup/rewriting, to keep this change "basically mechanical". BUG=none TEST=none R=sky@chromium.org Review URL: https://codereview.chromium.org/15732018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202917 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/functional/chromeos_basic.py')
0 files changed, 0 insertions, 0 deletions