diff options
| author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-21 02:39:43 +0000 |
|---|---|---|
| committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-21 02:39:43 +0000 |
| commit | d550ce0e73f31f84efd7be83309e913a97ca60e5 (patch) | |
| tree | 81b25fd9c4f5d49d8a44c7d40b7187fd70ed180f /chrome/test/functional/test_utils.py | |
| parent | 6652074712f84591150721953f6ed8049145256e (diff) | |
| download | chromium_src-d550ce0e73f31f84efd7be83309e913a97ca60e5.zip chromium_src-d550ce0e73f31f84efd7be83309e913a97ca60e5.tar.gz chromium_src-d550ce0e73f31f84efd7be83309e913a97ca60e5.tar.bz2 | |
Change definition of about:sync summary
The old syner status definition has outlived its usefulness. After a
series of refactorings in the status summary reporting classes, it
provides practically no useful and non-redundant information.
The new syncer status is based on the information available to the
ProfileSyncService. It attempts to indicate what level of
initialization the sync service has reached, and therefore what sort of
service a user ought to expect from it.
This has a significant impact on some tests, which have come to rely on
the summary as a means of inspecting internal state. I consider this to
be a bad idea, since most of these tests should be testing behaviour,
not internal state. In an attempt to discourage tests from relying on
this summary in the future, the summary is now available only as an
std::string.
This change breaks the python functional sync tests. However, these
test were already broken prior to this change. Fixing and re-enabling
these tests is a job best left ot a future CL.
BUG=112229,98346
TEST=
Review URL: http://codereview.chromium.org/9724012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127886 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/functional/test_utils.py')
| -rw-r--r-- | chrome/test/functional/test_utils.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/test/functional/test_utils.py b/chrome/test/functional/test_utils.py index 4769e1d..5322216 100644 --- a/chrome/test/functional/test_utils.py +++ b/chrome/test/functional/test_utils.py @@ -338,10 +338,8 @@ def SignInToSyncAndVerifyState(test, account_key): creds = test.GetPrivateInfo()[account_key] username = creds['username'] password = creds['password'] - test.assertTrue(test.GetSyncInfo()['summary'] == 'OFFLINE_UNUSABLE') test.assertTrue(test.GetSyncInfo()['last synced'] == 'Never') test.assertTrue(test.SignInToSync(username, password)) - test.assertTrue(test.GetSyncInfo()['summary'] == 'READY') test.assertTrue(test.GetSyncInfo()['last synced'] == 'Just now') |