diff options
| author | mseaborn <mseaborn@chromium.org> | 2015-02-10 13:20:01 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-10 21:20:26 +0000 |
| commit | 3cf62d9ade1564df31b3887b01df5afad745a124 (patch) | |
| tree | 54636e698bf72d4e6cf0ed269ea8c88d89771906 /chrome/test/nacl | |
| parent | 8a9231d90a62da8563ea983336d5c73d0b210dd1 (diff) | |
| download | chromium_src-3cf62d9ade1564df31b3887b01df5afad745a124.zip chromium_src-3cf62d9ade1564df31b3887b01df5afad745a124.tar.gz chromium_src-3cf62d9ade1564df31b3887b01df5afad745a124.tar.bz2 | |
NaCl cleanup: Move ppb_nacl_private.h into components/nacl/renderer/
Since PPB_NaCl_Private is both implemented and consumed in
components/nacl/renderer/, there's no need for the interface to be
defined in ppapi/. The fact that this is a PPAPI interface at all is
just a holdover from when the code for the NaCl trusted plugin lived
outside the Chromium repo.
We can drop the ppb_nacl_private.idl file.
Benefits:
* This reduces the friction for changing ppb_nacl_private.h. It's no
longer necessary to change ppb_nacl_private.idl and re-run the
generator.
* This removes PPB_NaCl_Private from the PPAPI shims, reducing code
size.
* ppb_nacl_private.h no longer has to follow the PPAPI C header
style. For example, it would no longer need to define its own
"struct PP_NaClFileInfo" type -- it could share a definition that's
marshallable over Chrome IPC.
Changes to ppb_nacl_private.h:
* Add comment to explain the status of this interface.
* Remove unused "*_1_0" variants of #define and typedef.
BUG=239656
BUG=251460
TEST=trybots
Review URL: https://codereview.chromium.org/911463003
Cr-Commit-Position: refs/heads/master@{#315641}
Diffstat (limited to 'chrome/test/nacl')
| -rw-r--r-- | chrome/test/nacl/nacl_browsertest_uma.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/test/nacl/nacl_browsertest_uma.cc b/chrome/test/nacl/nacl_browsertest_uma.cc index 366417b..dcc3dc68 100644 --- a/chrome/test/nacl/nacl_browsertest_uma.cc +++ b/chrome/test/nacl/nacl_browsertest_uma.cc @@ -5,9 +5,9 @@ #include "base/test/histogram_tester.h" #include "chrome/test/nacl/nacl_browsertest_util.h" #include "components/nacl/browser/nacl_browser.h" +#include "components/nacl/renderer/ppb_nacl_private.h" #include "content/public/test/browser_test_utils.h" #include "native_client/src/trusted/service_runtime/nacl_error_code.h" -#include "ppapi/c/private/ppb_nacl_private.h" namespace { |