summaryrefslogtreecommitdiffstats
path: root/chrome/test/nacl
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2014-10-27 17:09:06 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-28 00:09:20 +0000
commitd002275ed3495e7080befa77c687ef768cf2488c (patch)
treec35f5edcea3294bba61bcabe91b776040078064a /chrome/test/nacl
parent5e6a48d31985ea106aec4d3c3dc9269ef47cd5cf (diff)
downloadchromium_src-d002275ed3495e7080befa77c687ef768cf2488c.zip
chromium_src-d002275ed3495e7080befa77c687ef768cf2488c.tar.gz
chromium_src-d002275ed3495e7080befa77c687ef768cf2488c.tar.bz2
Standardize usage of virtual/override/final specifiers.
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=thestig@chromium.org Review URL: https://codereview.chromium.org/679273002 Cr-Commit-Position: refs/heads/master@{#301498}
Diffstat (limited to 'chrome/test/nacl')
-rw-r--r--chrome/test/nacl/nacl_browsertest_util.h2
-rw-r--r--chrome/test/nacl/pnacl_header_test.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/chrome/test/nacl/nacl_browsertest_util.h b/chrome/test/nacl/nacl_browsertest_util.h
index 13ebf8c..4a7c3c6 100644
--- a/chrome/test/nacl/nacl_browsertest_util.h
+++ b/chrome/test/nacl/nacl_browsertest_util.h
@@ -59,7 +59,7 @@ class LoadTestMessageHandler : public StructuredMessageHandler {
class NaClBrowserTestBase : public InProcessBrowserTest {
public:
NaClBrowserTestBase();
- virtual ~NaClBrowserTestBase();
+ ~NaClBrowserTestBase() override;
void SetUpCommandLine(base::CommandLine* command_line) override;
diff --git a/chrome/test/nacl/pnacl_header_test.h b/chrome/test/nacl/pnacl_header_test.h
index f81862c..1509b4a 100644
--- a/chrome/test/nacl/pnacl_header_test.h
+++ b/chrome/test/nacl/pnacl_header_test.h
@@ -49,7 +49,7 @@ class TestDispatcherHostDelegate : public ResourceDispatcherHostDelegate {
class PnaclHeaderTest : public InProcessBrowserTest {
public:
PnaclHeaderTest();
- virtual ~PnaclHeaderTest();
+ ~PnaclHeaderTest() override;
// Run a simple test that checks that the NaCl plugin sends the right
// headers when doing |expected_noncors| same origin pexe load requests