diff options
| author | phoglund <phoglund@chromium.org> | 2015-10-01 00:26:28 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-01 07:27:10 +0000 |
| commit | 228108b741fdb508793a383a33d4e7ad8b8f3f5c (patch) | |
| tree | 14acff2ac153073c578e302bca444c4908d1fee0 /chrome/test/ppapi | |
| parent | 052b913492d2a1371ed5d2a014fd57be8103a29a (diff) | |
| download | chromium_src-228108b741fdb508793a383a33d4e7ad8b8f3f5c.zip chromium_src-228108b741fdb508793a383a33d4e7ad8b8f3f5c.tar.gz chromium_src-228108b741fdb508793a383a33d4e7ad8b8f3f5c.tar.bz2 | |
Revert of PPAPI regression test for NaCl x86-32 IRT stack alignment sensitivity (patchset #3 id:40001 of https://codereview.chromium.org/1380853002/ )
Reason for revert:
The new test fails on Linux.
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/20294/steps/browser_tests/logs/PPAPINaClPNaClNonSfiTest.NaClIRTStackAlignment
Original issue's description:
> PPAPI regression test for NaCl x86-32 IRT stack alignment sensitivity
>
> The bug with IRT stack alignment sensitivity can manifest in two ways.
> The issue of the stack being aligned properly at callbacks from the
> IRT is tested on the NaCl side (irt_stack_alignment test). The other
> issue is alignment-sensitive SSE instructions being used to copy
> 16-byte arguments from the stack, assuming they will be properly
> aligned on the stack. That situation only comes up with the PPAPI
> interfaces that use a 16-byte argument type such as PP_Var. So test
> that case here.
>
> BUG= https://code.google.com/p/nativeclient/issues/detail?id=3935
> TEST= browser_tests --gtest_filter=PPAPINaClNewlibTest.NaClIRTStackAlignment on x86-32
> R=bbudge@chromium.org, dschuff@chromium.org
>
> Committed: https://crrev.com/7c6a2aec822f5a9a25f9750a4ac934fc9e6d3910
> Cr-Commit-Position: refs/heads/master@{#351644}
TBR=bbudge@chromium.org,dschuff@chromium.org,mcgrathr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3935
Review URL: https://codereview.chromium.org/1379023003
Cr-Commit-Position: refs/heads/master@{#351746}
Diffstat (limited to 'chrome/test/ppapi')
| -rw-r--r-- | chrome/test/ppapi/ppapi_browsertest.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/chrome/test/ppapi/ppapi_browsertest.cc b/chrome/test/ppapi/ppapi_browsertest.cc index d6de8fc..3cc2716 100644 --- a/chrome/test/ppapi/ppapi_browsertest.cc +++ b/chrome/test/ppapi/ppapi_browsertest.cc @@ -540,10 +540,6 @@ TEST_PPAPI_NACL(Var) TEST_PPAPI_NACL(VarResource) -#if defined(__i386__) -TEST_PPAPI_NACL(NaClIRTStackAlignment) -#endif - // PostMessage tests. #define RUN_POSTMESSAGE_SUBTESTS \ RunTestViaHTTP( \ |