summaryrefslogtreecommitdiffstats
path: root/chrome/test/testing_profile.h
diff options
context:
space:
mode:
authorerg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-22 18:05:22 +0000
committererg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-22 18:05:22 +0000
commit18280378d78cc83d8e83de21f28411cb4fa777bc (patch)
treea820592ddb8899a850e75061fc2e4e533e8b149e /chrome/test/testing_profile.h
parent33a85f181bf099afe9067d50277ea0e85e35f302 (diff)
downloadchromium_src-18280378d78cc83d8e83de21f28411cb4fa777bc.zip
chromium_src-18280378d78cc83d8e83de21f28411cb4fa777bc.tar.gz
chromium_src-18280378d78cc83d8e83de21f28411cb4fa777bc.tar.bz2
Profile shouldn't own BrowserThemeProviders; A ThemeService should and should give back a BTP when presented with a Profile.
This removes all Profile methods that deal with themes. A profile is now just the key that ThemeService maps to a BrowserThemeProvider. Any user of a BrowserThemeProvider asks ThemeService::GetForProfile() instead of the now deleted Profile::GetThemeProvider() method. Why do this? Because this will drastically reduce coupling. Right now, the Profile knows about pretty much every major object in chrome/browser/. This should allow easier compile time removal of certain systems. BUG=profile effort TEST=existing tests Review URL: http://codereview.chromium.org/6714003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79001 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/test/testing_profile.h')
-rw-r--r--chrome/test/testing_profile.h10
1 files changed, 0 insertions, 10 deletions
diff --git a/chrome/test/testing_profile.h b/chrome/test/testing_profile.h
index 7c3ae2bb..befc5a6 100644
--- a/chrome/test/testing_profile.h
+++ b/chrome/test/testing_profile.h
@@ -185,12 +185,6 @@ class TestingProfile : public Profile {
virtual fileapi::FileSystemContext* GetFileSystemContext();
virtual BrowserSignin* GetBrowserSignin();
virtual bool HasCreatedDownloadManager() const;
- virtual void InitThemes();
- virtual void SetTheme(const Extension* extension) {}
- virtual void SetNativeTheme() {}
- virtual void ClearTheme() {}
- virtual const Extension* GetTheme();
- virtual BrowserThemeProvider* GetThemeProvider();
// Returns a testing ContextGetter (if one has been created via
// CreateRequestContext) or NULL. This is not done on-demand for two reasons:
@@ -345,10 +339,6 @@ class TestingProfile : public Profile {
// The SessionService. Defaults to NULL, but can be set using the setter.
scoped_refptr<SessionService> session_service_;
- // The theme provider. Created lazily by GetThemeProvider()/InitThemes().
- scoped_ptr<BrowserThemeProvider> theme_provider_;
- bool created_theme_provider_;
-
// Internally, this is a TestURLRequestContextGetter that creates a dummy
// request context. Currently, only the CookieMonster is hooked up.
scoped_refptr<URLRequestContextGetter> request_context_;