Make all pdb file names follow the same naming convention.

The new naming scheme simply appends .pdb to the target (e.g. foo.dll.pdb and
foo.exe.pdb). This is beneficial for a couple reasons:
  * no more chrome_dll.pdb and chrome_exe.pdb silliness
    * also avoids this issue if we end up with similarly named targets in the
      future (target.dll and target.exe)
  * ninja already does this, and, by extension, either ninja needs to be broken
    to use the old scheme, or the we fix the broken in the existing system.
    One less difference between msvs and ninja.

Fixes for chrome-internal stuff: https://chromereviews.googleplex.com/5681015

BUG=

Review URL: https://codereview.chromium.org/11384003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168341 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 25 insertions, 25 deletions

diff --git a/chrome/tools/build/win/FILES.cfg b/chrome/tools/build/win/FILES.cfg
index 52a0df3..afdf0ef 100644
--- a/chrome/tools/build/win/FILES.cfg
+++ b/chrome/tools/build/win/FILES.cfg
@@ -459,7 +459,7 @@ FILES = [
     'filegroup': ['symsrc'],
   },
   {
-    'filename': 'remoting_controller.pdb',
+    'filename': 'remoting_controller.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['official'],
     'archive': 'remoting-win32.zip',
@@ -472,7 +472,7 @@ FILES = [
     'filegroup': ['symsrc'],
   },
   {
-    'filename': 'remoting_daemon.pdb',
+    'filename': 'remoting_daemon.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['official'],
     'archive': 'remoting-win32.zip',
@@ -485,7 +485,7 @@ FILES = [
     'filegroup': ['symsrc'],
   },
   {
-    'filename': 'remoting_host.pdb',
+    'filename': 'remoting_host.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['official'],
     'archive': 'remoting-win32.zip',
@@ -498,7 +498,7 @@ FILES = [
     'filegroup': ['symsrc'],
   },
   {
-    'filename': 'remoting_host_plugin.pdb',
+    'filename': 'remoting_host_plugin.dll.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['official'],
     'archive': 'remoting-win32.zip',
@@ -617,13 +617,13 @@ FILES = [
     'filegroup': ['default', 'symsrc'],
   },
   {
-    'filename': 'metro_driver.pdb',
+    'filename': 'metro_driver.dll.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'delegate_execute.pdb',
+    'filename': 'delegate_execute.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['official'],
     'archive': 'chrome-win32-syms.zip',
@@ -671,109 +671,109 @@ FILES = [
     'archive': 'courgette64.exe',
   },
   {
-    'filename': 'app_host.pdb',
+    'filename': 'app_host.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'chrome_dll.pdb',
+    'filename': 'chrome.dll.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'chrome_exe.pdb',
+    'filename': 'chrome.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'libEGL.pdb',
+    'filename': 'libEGL.dll.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'libGLESv2.pdb',
+    'filename': 'libGLESv2.dll.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'mini_installer.pdb',
+    'filename': 'mini_installer.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'nacl64_exe.pdb',
+    'filename': 'nacl64.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'ppGoogleNaClPluginChrome.pdb',
+    'filename': 'ppGoogleNaClPluginChrome.dll.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'setup.pdb',
+    'filename': 'setup.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'gcp_portmon.pdb',
+    'filename': 'gcp_portmon.dll.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'gcp_portmon64.pdb',
+    'filename': 'gcp_portmon64.dll.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'virtual_driver_setup.pdb',
+    'filename': 'virtual_driver_setup.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'npchrome_frame.pdb',
+    'filename': 'npchrome_frame.dll.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'chrome_launcher.pdb',
+    'filename': 'chrome_launcher.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'chrome_frame_helper.pdb',
+    'filename': 'chrome_frame_helper.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'chrome_frame_helper_dll.pdb',
+    'filename': 'chrome_frame_helper.dll.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['dev', 'official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'syzygy/chrome_dll.pdb',
+    'filename': 'syzygy/chrome.dll.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['official'],
     'archive': 'chrome-win32-syms.zip',
   },
   {
-    'filename': 'syzygy/mini_installer.pdb',
+    'filename': 'syzygy/mini_installer.exe.pdb',
     'arch': ['32bit', '64bit'],
     'buildtype': ['official'],
     'archive': 'chrome-win32-syms.zip',
diff --git a/chrome/tools/build/win/make_chromebot_zip.sh b/chrome/tools/build/win/make_chromebot_zip.sh
index 4e5f4c5..c4d0f15 100755
--- a/chrome/tools/build/win/make_chromebot_zip.sh
+++ b/chrome/tools/build/win/make_chromebot_zip.sh
@@ -47,7 +47,7 @@ popd
 zip -r $output.zip $output
 
 # Create chrome symbol zip file
-sym_files=( chrome_dll.pdb chrome_exe.pdb )
+sym_files=( chrome.dll.pdb chrome.exe.pdb )
 
 sym_output=${2:-chrome-win32-syms}
 rm -fr $sym_output $sym_output.zip