summaryrefslogtreecommitdiffstats
path: root/chrome/tools
diff options
context:
space:
mode:
authorkaznacheev@chromium.org <kaznacheev@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-11-16 15:24:28 +0000
committerkaznacheev@chromium.org <kaznacheev@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-11-16 15:24:28 +0000
commitf3f8ffb3562a0af1d393b160a9388d42bc8be0d3 (patch)
tree1478f2a1298d08d450d88e9c0a04de7212f7a3b7 /chrome/tools
parent837897f2b514eb09d179338bb38a75462c40b66b (diff)
downloadchromium_src-f3f8ffb3562a0af1d393b160a9388d42bc8be0d3.zip
chromium_src-f3f8ffb3562a0af1d393b160a9388d42bc8be0d3.tar.gz
chromium_src-f3f8ffb3562a0af1d393b160a9388d42bc8be0d3.tar.bz2
ChromeOS should record FileBrowser.CreateNewFolder.... events
Added UMA user action implemented in http://codereview.chromium.org/8490014/ to extract_actions.py, updated chromeactions.txt. Note: when I ran extract_actions.py --hash I saw a number of new actions show up in chromeactions.txt. Someone has probably forgot to update it. I am only adding the one line related to my action in this patch. BUG=chromium-os:22860 TEST= Review URL: http://codereview.chromium.org/8537008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110303 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/tools')
-rw-r--r--chrome/tools/chromeactions.txt6
-rwxr-xr-xchrome/tools/extract_actions.py10
2 files changed, 16 insertions, 0 deletions
diff --git a/chrome/tools/chromeactions.txt b/chrome/tools/chromeactions.txt
index f72d048..4c25b5f 100644
--- a/chrome/tools/chromeactions.txt
+++ b/chrome/tools/chromeactions.txt
@@ -206,6 +206,10 @@
0x2aeb39c03cc86464 CreateLink
0x1225d110ef7fba17 CreateProfile
0x30604f84327d0ae5 CreateShortcut
+0x8b83a029888765ac CriticalNotificationShown
+0x3811e868a8b2639a CriticalNotification_AutoRestart
+0x74d29a646c3b335c CriticalNotification_Ignore
+0x417f35273c2e009b CriticalNotification_Restart
0xfdf6ee64a0588855 Cryptohome.PKCS11InitFail
0xeb334dca00e390e0 Cut
0xb94d8a074eddd267 Debugger
@@ -246,7 +250,9 @@
0xfef46e5063ce3dc7 Exit
0xdf56dffe242f621a Extensions.ExtensionInstalled
0x4f07c158c8047ab9 Extensions.ExtensionUninstalled
+0x08566bf746b7f665 Extensions.IDChangedError
0xa295e3ad39bbacc0 Extensions.WebStoreLaunch
+0x4268aeb48d5c0d1e FileBrowser.CreateNewFolder
0x4cfa6c981549e990 Find
0x058404d575478e31 FindNext
0xca56592cf013fc40 FindPrevious
diff --git a/chrome/tools/extract_actions.py b/chrome/tools/extract_actions.py
index 739e3ee..650f6e4 100755
--- a/chrome/tools/extract_actions.py
+++ b/chrome/tools/extract_actions.py
@@ -223,6 +223,15 @@ def AddChromeOSActions(actions):
# Actions sent by Chrome OS cryptohome.
actions.add('Cryptohome.PKCS11InitFail')
+def AddExtensionActions(actions):
+ """Add actions reported by extensions via chrome.experimental.metrics API.
+
+ Arguments:
+ actions: set of actions to add to.
+ """
+ # Actions sent by Chrome OS File Browser.
+ actions.add('FileBrowser.CreateNewFolder')
+
def GrepForActions(path, actions):
"""Grep a source file for calls to UserMetrics functions.
@@ -413,6 +422,7 @@ def main(argv):
AddClosedSourceActions(actions)
AddChromeOSActions(actions)
+ AddExtensionActions(actions)
if hash_output:
f = open(chromeactions_path, "w")