diff options
| author | rsesek@chromium.org <rsesek@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-25 07:58:17 +0000 |
|---|---|---|
| committer | rsesek@chromium.org <rsesek@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-25 07:58:17 +0000 |
| commit | 31af2abddfa0c05ee19de5b4646197fa552c7e49 (patch) | |
| tree | 2c9efbd2c3b8d4846230a7cb9cb8f8be7c4da2dd /chrome/worker/webworker_stub.h | |
| parent | 49fa9d59bca4ba0118a3e65f7cad5886cc4d5c3e (diff) | |
| download | chromium_src-31af2abddfa0c05ee19de5b4646197fa552c7e49.zip chromium_src-31af2abddfa0c05ee19de5b4646197fa552c7e49.tar.gz chromium_src-31af2abddfa0c05ee19de5b4646197fa552c7e49.tar.bz2 | |
Revert r39951 - Broke Valgrind - "Make sure the workers are given a chance to terminate their thread when the IPC channel fails.
Usually, the ChildThread::OnChannelError() simply kills the message loop. we want to give workers
an opportunity to get out of their threads to avoid crashes when main thread destroys globals.
BUG=35963
TEST=WorkerTest.StressJSExecution
Review URL: http://codereview.chromium.org/647064"
Revert r39997 - Attempted Fix - "Fix a conditional jump depending on an uninitialized value by setting it to false in the ctor."
TBR=dimich
BUG=none
TEST=Valgrind
Review URL: http://codereview.chromium.org/661068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39999 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/worker/webworker_stub.h')
| -rw-r--r-- | chrome/worker/webworker_stub.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome/worker/webworker_stub.h b/chrome/worker/webworker_stub.h index dab69d0..59a46f1 100644 --- a/chrome/worker/webworker_stub.h +++ b/chrome/worker/webworker_stub.h @@ -21,7 +21,6 @@ class WebWorkerStub : public WebWorkerStubBase { // IPC::Channel::Listener implementation. virtual void OnMessageReceived(const IPC::Message& message); - virtual void OnChannelError(); private: virtual ~WebWorkerStub(); |