diff options
author | dimich <dimich@chromium.org> | 2016-03-02 15:15:32 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-02 23:16:58 +0000 |
commit | 08ebff81c084613192bd3e0b79613e394ffb2aa7 (patch) | |
tree | 6fbe8938e1ecb4187e219ccad9dcb90d861cd89f /chrome | |
parent | 53eccbc71cfc0b6f715d595888d6850d38b013c0 (diff) | |
download | chromium_src-08ebff81c084613192bd3e0b79613e394ffb2aa7.zip chromium_src-08ebff81c084613192bd3e0b79613e394ffb2aa7.tar.gz chromium_src-08ebff81c084613192bd3e0b79613e394ffb2aa7.tar.bz2 |
Revert of Mustash: Move GURL ParamTraits to url/ipc (patchset #18 id:330001 of https://codereview.chromium.org/1722773002/ )
Reason for revert:
Broke compile on iOS_Simulator_GN_(dbg): https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_GN_%28dbg%29/builds/1777
Original issue's description:
> Move GURL ParamTraits to url/ipc
>
> As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on
> content/. One such dependency is GURL. As per discussion here:
> https://codereview.chromium.org/1703163002/, the plan of record is to move
> GURL ParamTraits out of content/ and into url/.
>
> BUG=586368
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
> Cr-Commit-Position: refs/heads/master@{#378859}
TBR=fsamuel@chromium.org,piman@chromium.org,brettw@chromium.org,tsepez@chromium.org,thakis@chromium.org,markdittmer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=586368
Review URL: https://codereview.chromium.org/1755363003
Cr-Commit-Position: refs/heads/master@{#378869}
Diffstat (limited to 'chrome')
-rw-r--r-- | chrome/browser/chrome_content_browser_client.cc | 1 | ||||
-rw-r--r-- | chrome/chrome_common.gypi | 6 | ||||
-rw-r--r-- | chrome/common/common_message_generator.cc | 1 | ||||
-rw-r--r-- | chrome/common/common_message_generator.h | 4 | ||||
-rw-r--r-- | chrome/common/importer/profile_import_process_messages.h | 2 | ||||
-rw-r--r-- | chrome/common/prerender_messages.h | 2 | ||||
-rw-r--r-- | chrome/common/render_messages.h | 8 | ||||
-rw-r--r-- | chrome/renderer/chrome_render_frame_observer.cc | 2 |
8 files changed, 7 insertions, 19 deletions
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc index c90d3e6..3e884bb 100644 --- a/chrome/browser/chrome_content_browser_client.cc +++ b/chrome/browser/chrome_content_browser_client.cc @@ -18,7 +18,6 @@ #include "base/macros.h" #include "base/path_service.h" #include "base/strings/string_number_conversions.h" -#include "base/strings/string_split.h" #include "base/strings/string_util.h" #include "base/strings/stringprintf.h" #include "base/strings/utf_string_conversions.h" diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi index 9328cf7..dc732b1 100644 --- a/chrome/chrome_common.gypi +++ b/chrome/chrome_common.gypi @@ -358,7 +358,6 @@ '<(DEPTH)/ui/gfx/ipc/gfx_ipc.gyp:gfx_ipc', '<(DEPTH)/ui/resources/ui_resources.gyp:ui_resources', '<(DEPTH)/url/url.gyp:url_lib', - '<(DEPTH)/url/ipc/url_ipc.gyp:url_ipc', ], 'sources': [ '<@(chrome_common_sources)' @@ -497,10 +496,7 @@ ], }, { # Non-Android. - 'sources': [ '<@(chrome_common_importer_sources)' ], - 'dependencies': [ - '<(DEPTH)/url/ipc/url_ipc.gyp:url_ipc', - ], + 'sources': [ '<@(chrome_common_importer_sources)' ] }], ['OS=="win"', { 'include_dirs': [ diff --git a/chrome/common/common_message_generator.cc b/chrome/common/common_message_generator.cc index eb1dda2..959f148 100644 --- a/chrome/common/common_message_generator.cc +++ b/chrome/common/common_message_generator.cc @@ -36,3 +36,4 @@ namespace IPC { namespace IPC { #include "chrome/common/common_message_generator.h" } // namespace IPC + diff --git a/chrome/common/common_message_generator.h b/chrome/common/common_message_generator.h index 13238da..e7a3f68 100644 --- a/chrome/common/common_message_generator.h +++ b/chrome/common/common_message_generator.h @@ -6,14 +6,11 @@ #include "chrome/common/benchmarking_messages.h" #include "chrome/common/chrome_utility_messages.h" -#include "chrome/common/common_param_traits_macros.h" #include "chrome/common/mac/app_shim_messages.h" #include "chrome/common/prerender_messages.h" #include "chrome/common/render_messages.h" #include "chrome/common/safe_browsing/safebrowsing_messages.h" #include "chrome/common/tts_messages.h" -#include "content/public/common/common_param_traits.h" -#include "content/public/common/common_param_traits_macros.h" #if defined(ENABLE_EXTENSIONS) #include "chrome/common/cast_messages.h" @@ -36,3 +33,4 @@ #if defined(ENABLE_WEBRTC) #include "chrome/common/media/webrtc_logging_messages.h" #endif + diff --git a/chrome/common/importer/profile_import_process_messages.h b/chrome/common/importer/profile_import_process_messages.h index e53c171..63e3708 100644 --- a/chrome/common/importer/profile_import_process_messages.h +++ b/chrome/common/importer/profile_import_process_messages.h @@ -18,9 +18,9 @@ #include "components/autofill/content/common/autofill_param_traits_macros.h" #include "components/autofill/core/common/password_form.h" #include "components/favicon_base/favicon_usage_data.h" +#include "content/public/common/common_param_traits.h" #include "ipc/ipc_message_macros.h" #include "ipc/ipc_message_utils.h" -#include "url/ipc/url_param_traits.h" // Force multiple inclusion of the param traits file to generate all methods. #undef CHROME_COMMON_IMPORTER_PROFILE_IMPORT_PROCESS_PARAM_TRAITS_MACROS_H_ diff --git a/chrome/common/prerender_messages.h b/chrome/common/prerender_messages.h index a9ca9f6..fc373fe 100644 --- a/chrome/common/prerender_messages.h +++ b/chrome/common/prerender_messages.h @@ -6,13 +6,13 @@ #include <stdint.h> +#include "content/public/common/common_param_traits.h" #include "content/public/common/referrer.h" #include "ipc/ipc_message.h" #include "ipc/ipc_message_macros.h" #include "ipc/ipc_param_traits.h" #include "ui/gfx/geometry/size.h" #include "url/gurl.h" -#include "url/ipc/url_param_traits.h" #define IPC_MESSAGE_START PrerenderMsgStart diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h index 74efb68..a34683a 100644 --- a/chrome/common/render_messages.h +++ b/chrome/common/render_messages.h @@ -11,23 +11,19 @@ #include "base/strings/string16.h" #include "base/time/time.h" #include "build/build_config.h" +#include "chrome/common/common_param_traits.h" #include "chrome/common/instant_types.h" #include "chrome/common/ntp_logging_events.h" #include "chrome/common/search_provider.h" #include "chrome/common/web_application_info.h" -#include "components/content_settings/core/common/content_settings.h" -#include "components/content_settings/core/common/content_settings_pattern.h" #include "components/omnibox/common/omnibox_focus_state.h" +#include "content/public/common/common_param_traits.h" #include "content/public/common/top_controls_state.h" -#include "content/public/common/webplugininfo.h" #include "ipc/ipc_channel_handle.h" #include "ipc/ipc_message_macros.h" #include "ipc/ipc_platform_file.h" #include "third_party/WebKit/public/platform/modules/app_banner/WebAppBannerPromptReply.h" #include "third_party/WebKit/public/web/WebConsoleMessage.h" -#include "third_party/WebKit/public/web/WebWindowFeatures.h" -#include "ui/base/window_open_disposition.h" -#include "url/ipc/url_param_traits.h" // Singly-included section for enums and custom IPC traits. #ifndef CHROME_COMMON_RENDER_MESSAGES_H_ diff --git a/chrome/renderer/chrome_render_frame_observer.cc b/chrome/renderer/chrome_render_frame_observer.cc index b49f1be..af94139 100644 --- a/chrome/renderer/chrome_render_frame_observer.cc +++ b/chrome/renderer/chrome_render_frame_observer.cc @@ -12,7 +12,6 @@ #include "base/command_line.h" #include "base/metrics/histogram.h" -#include "base/strings/string_number_conversions.h" #include "base/strings/utf_string_conversions.h" #include "build/build_config.h" #include "chrome/common/chrome_isolated_world_ids.h" @@ -23,7 +22,6 @@ #include "chrome/renderer/prerender/prerender_helper.h" #include "chrome/renderer/safe_browsing/phishing_classifier_delegate.h" #include "components/translate/content/renderer/translate_helper.h" -#include "content/public/common/ssl_status.h" #include "content/public/renderer/render_frame.h" #include "content/public/renderer/render_view.h" #include "extensions/common/constants.h" |