summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authorandybons@chromium.org <andybons@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-30 16:11:26 +0000
committerandybons@chromium.org <andybons@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-30 16:11:26 +0000
commit4db2dd8dbe0ada3bfee486e507096723f15b7d82 (patch)
tree239e4cd9d11d4742dab4cdda9a3dfef11f7f9835 /chrome
parent05a81412f30cc6ee91dc2ffb3205f24deaaac54d (diff)
downloadchromium_src-4db2dd8dbe0ada3bfee486e507096723f15b7d82.zip
chromium_src-4db2dd8dbe0ada3bfee486e507096723f15b7d82.tar.gz
chromium_src-4db2dd8dbe0ada3bfee486e507096723f15b7d82.tar.bz2
Fix clang warnings/errors by un-inlining virtual methods.
BUG=none TEST=linux clang compiles. Review URL: http://codereview.chromium.org/6759034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79836 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/browser/webdata/autofill_table.cc4
-rw-r--r--chrome/browser/webdata/autofill_table.h2
-rw-r--r--chrome/browser/webdata/keyword_table.cc4
-rw-r--r--chrome/browser/webdata/keyword_table.h2
4 files changed, 10 insertions, 2 deletions
diff --git a/chrome/browser/webdata/autofill_table.cc b/chrome/browser/webdata/autofill_table.cc
index 0433b44..33e0483 100644
--- a/chrome/browser/webdata/autofill_table.cc
+++ b/chrome/browser/webdata/autofill_table.cc
@@ -32,6 +32,10 @@ bool AutofillTable::Init() {
InitProfileTrashTable());
}
+bool AutofillTable::IsSyncable() {
+ return true;
+}
+
bool AutofillTable::AddFormFieldValues(const std::vector<FormField>& elements,
std::vector<AutofillChange>* changes) {
return AddFormFieldValuesTime(elements, changes, Time::Now());
diff --git a/chrome/browser/webdata/autofill_table.h b/chrome/browser/webdata/autofill_table.h
index 584b949..af7648f 100644
--- a/chrome/browser/webdata/autofill_table.h
+++ b/chrome/browser/webdata/autofill_table.h
@@ -114,7 +114,7 @@ class AutofillTable : public WebDatabaseTable {
: WebDatabaseTable(db, meta_table) {}
virtual ~AutofillTable() {}
virtual bool Init();
- virtual bool IsSyncable() { return true; }
+ virtual bool IsSyncable();
// Records the form elements in |elements| in the database in the
// autofill table. A list of all added and updated autofill entries
diff --git a/chrome/browser/webdata/keyword_table.cc b/chrome/browser/webdata/keyword_table.cc
index f0d30e4..35edb56 100644
--- a/chrome/browser/webdata/keyword_table.cc
+++ b/chrome/browser/webdata/keyword_table.cc
@@ -86,6 +86,10 @@ bool KeywordTable::Init() {
return true;
}
+bool KeywordTable::IsSyncable() {
+ return true;
+}
+
bool KeywordTable::AddKeyword(const TemplateURL& url) {
DCHECK(url.id());
// Be sure to change kUrlIdPosition if you add columns
diff --git a/chrome/browser/webdata/keyword_table.h b/chrome/browser/webdata/keyword_table.h
index 5b43ea6..feae019 100644
--- a/chrome/browser/webdata/keyword_table.h
+++ b/chrome/browser/webdata/keyword_table.h
@@ -54,7 +54,7 @@ class KeywordTable : public WebDatabaseTable {
: WebDatabaseTable(db, meta_table) {}
virtual ~KeywordTable();
virtual bool Init();
- virtual bool IsSyncable() { return true; }
+ virtual bool IsSyncable();
// Adds a new keyword, updating the id field on success.
// Returns true if successful.