diff options
| author | mmoss@chromium.org <mmoss@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-25 20:50:30 +0000 |
|---|---|---|
| committer | mmoss@chromium.org <mmoss@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-25 20:50:30 +0000 |
| commit | 569a274a7644fc5afb86ec49fef7a2a78b8e1e41 (patch) | |
| tree | 15dc42df8dde4737f1359a0442f6e568d04ade4a /chrome | |
| parent | 3e34f9b81967742052e2a4f38cd22d3bc0713b95 (diff) | |
| download | chromium_src-569a274a7644fc5afb86ec49fef7a2a78b8e1e41.zip chromium_src-569a274a7644fc5afb86ec49fef7a2a78b8e1e41.tar.gz chromium_src-569a274a7644fc5afb86ec49fef7a2a78b8e1e41.tar.bz2 | |
Add a gyp "buildtype" variable to differentiate official release builds.
This notion was previously overloaded on "branding", but as implied, that
variable should really just control the "Google Chrome" vs. "Chromium"
branding. We need a separate setting to distinguish between "release" builds
(which get special handling, like breakpad symbol processing), and "everyday"
builds, like the buildbot continuous builds or personal developer builds.
This fixes a problem where the "Google Chrome" continuous builder was
unnecessarily trying to upload breakpad symbols for every single build.
Review URL: http://codereview.chromium.org/132038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19283 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/chrome.gyp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index 570f3c7..3c287dc 100644 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -2417,7 +2417,9 @@ 'conditions': [ ['OS=="linux"', { 'conditions': [ - ['branding=="Chrome"', { + # All Chrome builds have breakpad symbols, but only process the + # symbols from official builds. + ['branding=="Chrome" and buildtype=="Official"', { 'actions': [ { 'action_name': 'dump_symbols', @@ -3892,6 +3894,7 @@ }], ['OS=="linux"', { 'conditions': [ + # Only Chrome builds get breakpad since crash processing is internal. ['branding=="Chrome"', { 'variables': { 'linux_breakpad%': 1, |