summaryrefslogtreecommitdiffstats
path: root/chrome
diff options
context:
space:
mode:
authoravi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-31 18:51:04 +0000
committeravi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-31 18:51:04 +0000
commit612a2ca54f460ddf58f3bbcf6c399ec16bf0d315 (patch)
tree7197713021aa15e33bd9472898efd498ac85face /chrome
parentda2e871ccc23c51e9e1301168cd47944c3c3cca1 (diff)
downloadchromium_src-612a2ca54f460ddf58f3bbcf6c399ec16bf0d315.zip
chromium_src-612a2ca54f460ddf58f3bbcf6c399ec16bf0d315.tar.gz
chromium_src-612a2ca54f460ddf58f3bbcf6c399ec16bf0d315.tar.bz2
Use real KVO notification for the default browser text.
BUG=none TEST=make sure the default browser explanatory text stays working. Review URL: http://codereview.chromium.org/159708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22164 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
-rw-r--r--chrome/browser/cocoa/preferences_window_controller.mm11
1 files changed, 3 insertions, 8 deletions
diff --git a/chrome/browser/cocoa/preferences_window_controller.mm b/chrome/browser/cocoa/preferences_window_controller.mm
index 5f5d68e..57edccd 100644
--- a/chrome/browser/cocoa/preferences_window_controller.mm
+++ b/chrome/browser/cocoa/preferences_window_controller.mm
@@ -64,7 +64,6 @@ std::wstring GetNewTabUIURLString() {
- (void)setRestoreOnStartupIndex:(NSInteger)type;
- (void)setShowHomeButton:(BOOL)value;
- (void)setShowPageOptionsButtons:(BOOL)value;
-- (void)setDefaultBrowser:(BOOL)value;
- (void)setPasswordManagerEnabledIndex:(NSInteger)value;
- (void)setFormAutofillEnabledIndex:(NSInteger)value;
- (void)setShowAlternateErrorPages:(BOOL)value;
@@ -544,6 +543,8 @@ enum { kHomepageNewTabPage, kHomepageURL };
// Called when the user clicks the button to make Chromium the default
// browser. Registers http and https.
- (IBAction)makeDefaultBrowser:(id)sender {
+ [self willChangeValueForKey:@"defaultBrowser"];
+
ShellIntegration::SetAsDefaultBrowser();
[self recordUserAction:L"Options_SetAsDefaultBrowser"];
// If the user made Chrome the default browser, then he/she arguably wants
@@ -551,13 +552,7 @@ enum { kHomepageNewTabPage, kHomepageURL };
prefs_->SetBoolean(prefs::kCheckDefaultBrowser, true);
// Tickle KVO so that the UI updates.
- [self setDefaultBrowser:YES];
-}
-
-// A stub setter so that we can trick KVO into thinking the UI needs
-// to be updated.
-- (void)setDefaultBrowser:(BOOL)ignore {
- // Do nothing.
+ [self didChangeValueForKey:@"defaultBrowser"];
}
// Returns if Chromium is the default browser.