diff options
| author | nirnimesh@chromium.org <nirnimesh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-29 00:17:54 +0000 |
|---|---|---|
| committer | nirnimesh@chromium.org <nirnimesh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-29 00:17:54 +0000 |
| commit | 909bfc5222557f8280ac09170897e0968ce63b98 (patch) | |
| tree | 1c08cb5dd6581b895454bb780528e212e222c791 /chrome | |
| parent | 43e58d0bc3e7ba36acf145c6d8e753d530b15599 (diff) | |
| download | chromium_src-909bfc5222557f8280ac09170897e0968ce63b98.zip chromium_src-909bfc5222557f8280ac09170897e0968ce63b98.tar.gz chromium_src-909bfc5222557f8280ac09170897e0968ce63b98.tar.bz2 | |
Do not call GetBrowserInfo() in testGeolocationPref
GetBrowserInfo() fails after fetching geolocation. Working around until it's
resolved.
R=dennisjeffrey@chromium.org
BUG=89000
TEST=
Review URL: https://chromiumcodereview.appspot.com/9518010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124066 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rwxr-xr-x | chrome/test/functional/prefs.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/chrome/test/functional/prefs.py b/chrome/test/functional/prefs.py index 1501cea..19b9dbf 100755 --- a/chrome/test/functional/prefs.py +++ b/chrome/test/functional/prefs.py @@ -141,6 +141,9 @@ class PrefsTest(pyauto.PyUITest): Checks for the geolocation infobar. """ + # GetBrowserInfo() call seems to fail later on in this test. Call it early. + # crbug.com/89000 + branding = self.GetBrowserInfo()['properties']['branding'] from webdriver_pages import settings from webdriver_pages.settings import Behaviors, ContentTypes driver = self.NewWebDriver() @@ -157,8 +160,7 @@ class PrefsTest(pyauto.PyUITest): self.GetPrefsInfo().Prefs(pyauto.kGeolocationDefaultContentSetting)) self.GetBrowserWindow(0).GetTab(0).Reload() # Fails on Win7/Vista Chromium bots. crbug.com/89000 - if ((self.IsWin7() or self.IsWinVista()) and - self.GetBrowserInfo()['properties']['branding'] == 'Chromium'): + if (self.IsWin7() or self.IsWinVista()) and branding == 'Chromium': return behavior = driver.execute_async_script( 'triggerGeoWithCallback(arguments[arguments.length - 1]);') |