diff options
| author | dominich@chromium.org <dominich@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-02 16:00:37 +0000 |
|---|---|---|
| committer | dominich@chromium.org <dominich@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-02 16:00:37 +0000 |
| commit | 919bd4359ea852c0955931be55349378d274f933 (patch) | |
| tree | 327f3df49a8b02de22500a1a725113e5c288ddbc /chrome | |
| parent | fb9069d24ec3f0a234d3a256ac5fc8d5d49bbdcc (diff) | |
| download | chromium_src-919bd4359ea852c0955931be55349378d274f933.zip chromium_src-919bd4359ea852c0955931be55349378d274f933.tar.gz chromium_src-919bd4359ea852c0955931be55349378d274f933.tar.bz2 | |
Add recording of when a prerender actually starts to prerender histograms. This allows us to remove any trivially rejected prerenders from some counts.
BUG=105733
Review URL: http://codereview.chromium.org/8776011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112708 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/prerender/prerender_histograms.cc | 2 | ||||
| -rw-r--r-- | chrome/browser/prerender/prerender_histograms.h | 3 | ||||
| -rw-r--r-- | chrome/browser/prerender/prerender_manager.cc | 2 |
3 files changed, 7 insertions, 0 deletions
diff --git a/chrome/browser/prerender/prerender_histograms.cc b/chrome/browser/prerender/prerender_histograms.cc index 9e772f9..1eaa5e4 100644 --- a/chrome/browser/prerender/prerender_histograms.cc +++ b/chrome/browser/prerender/prerender_histograms.cc @@ -153,7 +153,9 @@ void PrerenderHistograms::RecordPrerender(Origin origin, const GURL& url) { last_prerender_seen_time_ = GetCurrentTimeTicks(); seen_any_pageload_ = false; seen_pageload_started_after_prerender_ = false; +} +void PrerenderHistograms::RecordPrerenderStarted(Origin origin) const { if (OriginIsOmnibox(origin)) { UMA_HISTOGRAM_COUNTS("Prerender.OmniboxPrerenderCount_" + GetOmniboxHistogramSuffix(), 1); diff --git a/chrome/browser/prerender/prerender_histograms.h b/chrome/browser/prerender/prerender_histograms.h index a4453a48..69c61fe 100644 --- a/chrome/browser/prerender/prerender_histograms.h +++ b/chrome/browser/prerender/prerender_histograms.h @@ -55,6 +55,9 @@ class PrerenderHistograms { // To be called when a new prerender is added. void RecordPrerender(Origin origin, const GURL& url); + // To be called when a new prerender is started. + void RecordPrerenderStarted(Origin origin) const; + // Called when we swap in a prerender. void RecordUsedPrerender(Origin origin) const; diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc index 323d202..b4f7225 100644 --- a/chrome/browser/prerender/prerender_manager.cc +++ b/chrome/browser/prerender/prerender_manager.cc @@ -447,6 +447,8 @@ bool PrerenderManager::AddPrerender( if (!prerender_contents || !prerender_contents->Init()) return false; + histograms_->RecordPrerenderStarted(origin); + // TODO(cbentzel): Move invalid checks here instead of PrerenderContents? PrerenderContentsData data(prerender_contents, GetCurrentTime()); |