diff options
author | cpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-14 05:24:44 +0000 |
---|---|---|
committer | cpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-14 05:24:44 +0000 |
commit | 91d9f3d52a1e55a9938416b258e08d3cc445eae4 (patch) | |
tree | 41a281011d4ba9e327fb4e167528c99e0faec018 /chrome | |
parent | 3c8f946c38d15238f5b0793123c06859a8bc2352 (diff) | |
download | chromium_src-91d9f3d52a1e55a9938416b258e08d3cc445eae4.zip chromium_src-91d9f3d52a1e55a9938416b258e08d3cc445eae4.tar.gz chromium_src-91d9f3d52a1e55a9938416b258e08d3cc445eae4.tar.bz2 |
Make WebPluginInfo more generic
- To account for pepper plugins, it grows a type field
- move WebPluginInfo from webkit::npapi to webkit:: and move the files as well.
This will allow us to remove hacks to get pepper plugins to load soon
BUG=89248
TEST=none
Review URL: http://codereview.chromium.org/7648017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96718 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
22 files changed, 86 insertions, 93 deletions
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc index 354a560..ff6b7de 100644 --- a/chrome/browser/automation/testing_automation_provider.cc +++ b/chrome/browser/automation/testing_automation_provider.cc @@ -3401,10 +3401,10 @@ void TestingAutomationProvider::GetPluginsInfo( this, browser, args, reply_message)); return; } - std::vector<webkit::npapi::WebPluginInfo> plugins; + std::vector<webkit::WebPluginInfo> plugins; webkit::npapi::PluginList::Singleton()->GetPlugins(&plugins); ListValue* items = new ListValue; - for (std::vector<webkit::npapi::WebPluginInfo>::const_iterator it = + for (std::vector<webkit::WebPluginInfo>::const_iterator it = plugins.begin(); it != plugins.end(); ++it) { @@ -3413,10 +3413,10 @@ void TestingAutomationProvider::GetPluginsInfo( item->SetString("path", it->path.value()); item->SetString("version", it->version); item->SetString("desc", it->desc); - item->SetBoolean("enabled", webkit::npapi::IsPluginEnabled(*it)); + item->SetBoolean("enabled", webkit::IsPluginEnabled(*it)); // Add info about mime types. ListValue* mime_types = new ListValue(); - for (std::vector<webkit::npapi::WebPluginMimeType>::const_iterator type_it = + for (std::vector<webkit::WebPluginMimeType>::const_iterator type_it = it->mime_types.begin(); type_it != it->mime_types.end(); ++type_it) { diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc index 9745341..ea28611 100644 --- a/chrome/browser/browser_about_handler.cc +++ b/chrome/browser/browser_about_handler.cc @@ -60,7 +60,7 @@ #include "ui/base/resource/resource_bundle.h" #include "webkit/glue/webkit_glue.h" #include "webkit/plugins/npapi/plugin_list.h" -#include "webkit/plugins/npapi/webplugininfo.h" +#include "webkit/plugins/webplugininfo.h" #ifdef CHROME_V8 #include "v8/include/v8.h" @@ -1108,13 +1108,13 @@ std::string AboutVersionStrings(DictionaryValue* localized_strings, localized_strings->SetString("js_version", js_version); // Obtain the version of the first enabled Flash plugin. - std::vector<webkit::npapi::WebPluginInfo> info_array; + std::vector<webkit::WebPluginInfo> info_array; webkit::npapi::PluginList::Singleton()->GetPluginInfoArray( GURL(), "application/x-shockwave-flash", false, NULL, &info_array, NULL); string16 flash_version = l10n_util::GetStringUTF16(IDS_PLUGINS_DISABLED_PLUGIN); for (size_t i = 0; i < info_array.size(); ++i) { - if (webkit::npapi::IsPluginEnabled(info_array[i])) { + if (webkit::IsPluginEnabled(info_array[i])) { flash_version = info_array[i].version; break; } diff --git a/chrome/browser/chromeos/gview_request_interceptor.cc b/chrome/browser/chromeos/gview_request_interceptor.cc index bfa5eae..3beab22 100644 --- a/chrome/browser/chromeos/gview_request_interceptor.cc +++ b/chrome/browser/chromeos/gview_request_interceptor.cc @@ -65,11 +65,11 @@ net::URLRequestJob* GViewRequestInterceptor::MaybeInterceptResponse( // redirect PDF files to Google Document Viewer. if (mime_type == kPdfMimeType) { FilePath pdf_path; - webkit::npapi::WebPluginInfo info; + webkit::WebPluginInfo info; PathService::Get(chrome::FILE_PDF_PLUGIN, &pdf_path); if (webkit::npapi::PluginList::Singleton()->GetPluginInfoByPath( pdf_path, &info) && - webkit::npapi::IsPluginEnabled(info)) + webkit::IsPluginEnabled(info)) return NULL; } // If supported, build the URL to the Google Document Viewer diff --git a/chrome/browser/chromeos/gview_request_interceptor_unittest.cc b/chrome/browser/chromeos/gview_request_interceptor_unittest.cc index 5e573fe..4e4d204 100644 --- a/chrome/browser/chromeos/gview_request_interceptor_unittest.cc +++ b/chrome/browser/chromeos/gview_request_interceptor_unittest.cc @@ -72,9 +72,9 @@ class GViewRequestInterceptorTest : public testing::Test { } void RegisterPDFPlugin() { - webkit::npapi::WebPluginInfo info; + webkit::WebPluginInfo info; info.path = pdf_path_; - info.enabled = webkit::npapi::WebPluginInfo::USER_ENABLED_POLICY_UNMANAGED; + info.enabled = webkit::WebPluginInfo::USER_ENABLED_POLICY_UNMANAGED; webkit::npapi::PluginList::Singleton()->RegisterInternalPlugin(info); webkit::npapi::PluginList::Singleton()->RefreshPlugins(); } @@ -85,7 +85,7 @@ class GViewRequestInterceptorTest : public testing::Test { } void SetPDFPluginLoadedState(bool want_loaded, bool* out_is_enabled) { - webkit::npapi::WebPluginInfo info; + webkit::WebPluginInfo info; bool is_loaded = webkit::npapi::PluginList::Singleton()->GetPluginInfoByPath( pdf_path_, &info); @@ -102,7 +102,7 @@ class GViewRequestInterceptorTest : public testing::Test { pdf_path_, &info); } EXPECT_EQ(want_loaded, is_loaded); - *out_is_enabled = webkit::npapi::IsPluginEnabled(info); + *out_is_enabled = webkit::IsPluginEnabled(info); } protected: diff --git a/chrome/browser/extensions/extension_content_settings_apitest.cc b/chrome/browser/extensions/extension_content_settings_apitest.cc index 11411df..ee3b2cc 100644 --- a/chrome/browser/extensions/extension_content_settings_apitest.cc +++ b/chrome/browser/extensions/extension_content_settings_apitest.cc @@ -206,15 +206,15 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, webkit::npapi::MockPluginList plugin_list(kPluginDefinitions, arraysize(kPluginDefinitions)); plugin_list.AddPluginToLoad( - webkit::npapi::WebPluginInfo(ASCIIToUTF16(kFooName), - FilePath(kFooPath), - ASCIIToUTF16("1.2.3"), - ASCIIToUTF16("foo"))); + webkit::WebPluginInfo(ASCIIToUTF16(kFooName), + FilePath(kFooPath), + ASCIIToUTF16("1.2.3"), + ASCIIToUTF16("foo"))); plugin_list.AddPluginToLoad( - webkit::npapi::WebPluginInfo(ASCIIToUTF16(kBarName), - FilePath(kBarPath), - ASCIIToUTF16("2.3.4"), - ASCIIToUTF16("bar"))); + webkit::WebPluginInfo(ASCIIToUTF16(kBarName), + FilePath(kBarPath), + ASCIIToUTF16("2.3.4"), + ASCIIToUTF16("bar"))); GetResourceIdentifiersFunction::SetPluginListForTesting(&plugin_list); EXPECT_TRUE(RunExtensionTest("content_settings/getresourceidentifiers")) diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc index c55a7f6..4f393d0 100644 --- a/chrome/browser/extensions/extension_service.cc +++ b/chrome/browser/extensions/extension_service.cc @@ -2561,7 +2561,7 @@ void ExtensionService::UpdatePluginListWithNaClModules() { for (size_t i = 0; i < plugins.size(); ++i) { pepper_info = &plugins[i]; CHECK(pepper_info); - std::vector<webkit::npapi::WebPluginMimeType>::const_iterator mime_iter; + std::vector<webkit::WebPluginMimeType>::const_iterator mime_iter; // Check each MIME type the plugins handle for the NaCl MIME type. for (mime_iter = pepper_info->mime_types.begin(); mime_iter != pepper_info->mime_types.end(); ++mime_iter) { @@ -2571,7 +2571,7 @@ void ExtensionService::UpdatePluginListWithNaClModules() { webkit::npapi::PluginList::Singleton()-> UnregisterInternalPlugin(pepper_info->path); - webkit::npapi::WebPluginInfo info = pepper_info->ToWebPluginInfo(); + webkit::WebPluginInfo info = pepper_info->ToWebPluginInfo(); for (ExtensionService::NaClModuleInfoList::const_iterator iter = nacl_module_list_.begin(); @@ -2579,7 +2579,7 @@ void ExtensionService::UpdatePluginListWithNaClModules() { // Add the MIME type specified in the extension to this NaCl plugin, // With an extra "nacl" argument to specify the location of the NaCl // manifest file. - webkit::npapi::WebPluginMimeType mime_type_info; + webkit::WebPluginMimeType mime_type_info; mime_type_info.mime_type = iter->mime_type; mime_type_info.additional_param_names.push_back(UTF8ToUTF16("nacl")); mime_type_info.additional_param_values.push_back( diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc index c826923..ce82634 100644 --- a/chrome/browser/metrics/metrics_log.cc +++ b/chrome/browser/metrics/metrics_log.cc @@ -26,7 +26,7 @@ #include "chrome/common/pref_names.h" #include "content/browser/gpu/gpu_data_manager.h" #include "googleurl/src/gurl.h" -#include "webkit/plugins/npapi/webplugininfo.h" +#include "webkit/plugins/webplugininfo.h" #define OPEN_ELEMENT_FOR_SCOPE(name) ScopedElement scoped_element(this, name) @@ -270,12 +270,12 @@ void MetricsLog::WriteRealtimeStabilityAttributes(PrefService* pref) { } void MetricsLog::WritePluginList( - const std::vector<webkit::npapi::WebPluginInfo>& plugin_list) { + const std::vector<webkit::WebPluginInfo>& plugin_list) { DCHECK(!locked_); OPEN_ELEMENT_FOR_SCOPE("plugins"); - for (std::vector<webkit::npapi::WebPluginInfo>::const_iterator iter = + for (std::vector<webkit::WebPluginInfo>::const_iterator iter = plugin_list.begin(); iter != plugin_list.end(); ++iter) { OPEN_ELEMENT_FOR_SCOPE("plugin"); @@ -291,7 +291,7 @@ void MetricsLog::WritePluginList( #endif WriteAttribute("filename", CreateBase64Hash(filename_bytes)); WriteAttribute("version", UTF16ToUTF8(iter->version)); - WriteIntAttribute("disabled", !webkit::npapi::IsPluginEnabled(*iter)); + WriteIntAttribute("disabled", !webkit::IsPluginEnabled(*iter)); } } @@ -302,7 +302,7 @@ void MetricsLog::WriteInstallElement() { } void MetricsLog::RecordEnvironment( - const std::vector<webkit::npapi::WebPluginInfo>& plugin_list, + const std::vector<webkit::WebPluginInfo>& plugin_list, const DictionaryValue* profile_metrics) { DCHECK(!locked_); diff --git a/chrome/browser/metrics/metrics_log.h b/chrome/browser/metrics/metrics_log.h index 36f2ec5..fbab92e 100644 --- a/chrome/browser/metrics/metrics_log.h +++ b/chrome/browser/metrics/metrics_log.h @@ -22,10 +22,8 @@ class DictionaryValue; } namespace webkit { -namespace npapi { struct WebPluginInfo; } -} class MetricsLog : public MetricsLogBase { public: @@ -44,7 +42,7 @@ class MetricsLog : public MetricsLogBase { // that are to be recorded. Each value in profile_metrics should be a // dictionary giving the metrics for the profile. void RecordEnvironment( - const std::vector<webkit::npapi::WebPluginInfo>& plugin_list, + const std::vector<webkit::WebPluginInfo>& plugin_list, const base::DictionaryValue* profile_metrics); // Records the input text, available choices, and selected entry when the @@ -92,7 +90,7 @@ class MetricsLog : public MetricsLogBase { // Writes the list of installed plugins. void WritePluginList( - const std::vector<webkit::npapi::WebPluginInfo>& plugin_list); + const std::vector<webkit::WebPluginInfo>& plugin_list); // Within the profile group, write basic install info including appversion. void WriteInstallElement(); diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc index 281905b..aec969f 100644 --- a/chrome/browser/metrics/metrics_service.cc +++ b/chrome/browser/metrics/metrics_service.cc @@ -191,7 +191,7 @@ #include "content/common/child_process_info.h" #include "content/common/notification_service.h" #include "webkit/plugins/npapi/plugin_list.h" -#include "webkit/plugins/npapi/webplugininfo.h" +#include "webkit/plugins/webplugininfo.h" // TODO(port): port browser_distribution.h. #if !defined(OS_POSIX) @@ -321,7 +321,7 @@ class MetricsService::InitTaskComplete : public Task { public: explicit InitTaskComplete( const std::string& hardware_class, - const std::vector<webkit::npapi::WebPluginInfo>& plugins) + const std::vector<webkit::WebPluginInfo>& plugins) : hardware_class_(hardware_class), plugins_(plugins) {} virtual void Run() { @@ -331,7 +331,7 @@ class MetricsService::InitTaskComplete : public Task { private: std::string hardware_class_; - std::vector<webkit::npapi::WebPluginInfo> plugins_; + std::vector<webkit::WebPluginInfo> plugins_; }; class MetricsService::InitTask : public Task { @@ -340,7 +340,7 @@ class MetricsService::InitTask : public Task { : callback_loop_(callback_loop) {} virtual void Run() { - std::vector<webkit::npapi::WebPluginInfo> plugins; + std::vector<webkit::WebPluginInfo> plugins; webkit::npapi::PluginList::Singleton()->GetPlugins(&plugins); std::string hardware_class; // Empty string by default. #if defined(OS_CHROMEOS) @@ -794,7 +794,7 @@ void MetricsService::InitializeMetricsState() { void MetricsService::OnInitTaskComplete( const std::string& hardware_class, - const std::vector<webkit::npapi::WebPluginInfo>& plugins) { + const std::vector<webkit::WebPluginInfo>& plugins) { DCHECK(state_ == INIT_TASK_SCHEDULED); hardware_class_ = hardware_class; plugins_ = plugins; diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h index 8d38f99..8e477a6 100644 --- a/chrome/browser/metrics/metrics_service.h +++ b/chrome/browser/metrics/metrics_service.h @@ -40,11 +40,8 @@ class ListValue; } namespace webkit { -namespace npapi { struct WebPluginInfo; } -} - class MetricsService : public NotificationObserver, public URLFetcher::Delegate, @@ -156,7 +153,7 @@ class MetricsService : public NotificationObserver, // Callback to let us know that the init task is done. void OnInitTaskComplete( const std::string& hardware_class, - const std::vector<webkit::npapi::WebPluginInfo>& plugins); + const std::vector<webkit::WebPluginInfo>& plugins); // When we start a new version of Chromium (different from our last run), we // need to discard the old crash stats so that we don't attribute crashes etc. @@ -356,7 +353,7 @@ class MetricsService : public NotificationObserver, std::string hardware_class_; // The list of plugins which was retrieved on the file thread. - std::vector<webkit::npapi::WebPluginInfo> plugins_; + std::vector<webkit::WebPluginInfo> plugins_; // The outstanding transmission appears as a URL Fetch operation. scoped_ptr<URLFetcher> current_fetch_; diff --git a/chrome/browser/pdf_unsupported_feature.cc b/chrome/browser/pdf_unsupported_feature.cc index 172f4fb..9190ffc 100644 --- a/chrome/browser/pdf_unsupported_feature.cc +++ b/chrome/browser/pdf_unsupported_feature.cc @@ -27,11 +27,11 @@ #include "ui/base/resource/resource_bundle.h" #include "webkit/plugins/npapi/plugin_group.h" #include "webkit/plugins/npapi/plugin_list.h" -#include "webkit/plugins/npapi/webplugininfo.h" +#include "webkit/plugins/webplugininfo.h" using webkit::npapi::PluginGroup; using webkit::npapi::PluginList; -using webkit::npapi::WebPluginInfo; +using webkit::WebPluginInfo; namespace { diff --git a/chrome/browser/plugin_data_remover.cc b/chrome/browser/plugin_data_remover.cc index e17254e..2046a79 100644 --- a/chrome/browser/plugin_data_remover.cc +++ b/chrome/browser/plugin_data_remover.cc @@ -87,7 +87,7 @@ bool PluginDataRemover::OffTheRecord() { } void PluginDataRemover::SetPluginInfo( - const webkit::npapi::WebPluginInfo& info) { + const webkit::WebPluginInfo& info) { } void PluginDataRemover::OnChannelOpened(const IPC::ChannelHandle& handle) { @@ -168,10 +168,10 @@ void PluginDataRemover::SignalDone() { bool PluginDataRemover::IsSupported() { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); bool allow_wildcard = false; - std::vector<webkit::npapi::WebPluginInfo> plugins; + std::vector<webkit::WebPluginInfo> plugins; webkit::npapi::PluginList::Singleton()->GetPluginInfoArray( GURL(), kFlashMimeType, allow_wildcard, NULL, &plugins, NULL); - std::vector<webkit::npapi::WebPluginInfo>::iterator plugin = plugins.begin(); + std::vector<webkit::WebPluginInfo>::iterator plugin = plugins.begin(); if (plugin == plugins.end()) return false; scoped_ptr<Version> version( @@ -181,7 +181,7 @@ bool PluginDataRemover::IsSupported() { switches::kMinClearSiteDataFlashVersion))); if (!min_version.get()) min_version.reset(Version::GetVersionFromString(kMinFlashVersion)); - return webkit::npapi::IsPluginEnabled(*plugin) && + return webkit::IsPluginEnabled(*plugin) && version.get() && min_version->CompareTo(*version) == -1; } diff --git a/chrome/browser/plugin_data_remover.h b/chrome/browser/plugin_data_remover.h index c455704..fa7d331 100644 --- a/chrome/browser/plugin_data_remover.h +++ b/chrome/browser/plugin_data_remover.h @@ -47,7 +47,7 @@ class PluginDataRemover : public base::RefCountedThreadSafe<PluginDataRemover>, // PluginProcessHost::Client methods. virtual int ID(); virtual bool OffTheRecord(); - virtual void SetPluginInfo(const webkit::npapi::WebPluginInfo& info); + virtual void SetPluginInfo(const webkit::WebPluginInfo& info); virtual void OnChannelOpened(const IPC::ChannelHandle& handle); virtual void OnError(); diff --git a/chrome/browser/plugin_exceptions_table_model.h b/chrome/browser/plugin_exceptions_table_model.h index 77fbee8..9f37621 100644 --- a/chrome/browser/plugin_exceptions_table_model.h +++ b/chrome/browser/plugin_exceptions_table_model.h @@ -15,8 +15,6 @@ #include "content/common/notification_observer.h" #include "webkit/plugins/npapi/plugin_list.h" -struct WebPluginInfo; - class PluginExceptionsTableModel : public RemoveRowsTableModel, public NotificationObserver { public: diff --git a/chrome/browser/plugin_exceptions_table_model_unittest.cc b/chrome/browser/plugin_exceptions_table_model_unittest.cc index 47c3bfc..3163b04 100644 --- a/chrome/browser/plugin_exceptions_table_model_unittest.cc +++ b/chrome/browser/plugin_exceptions_table_model_unittest.cc @@ -14,7 +14,7 @@ #include "testing/gtest/include/gtest/gtest.h" #include "ui/base/models/table_model_observer.h" #include "webkit/plugins/npapi/plugin_group.h" -#include "webkit/plugins/npapi/webplugininfo.h" +#include "webkit/plugins/webplugininfo.h" // Can't be an internal namespace because PluginExceptionsTableModel declares // as a friend. @@ -91,20 +91,20 @@ class PluginExceptionsTableModelTest : public TestingBrowserProcessTest { table_model_.reset(new MockPluginExceptionsTableModel(map, NULL)); std::vector<webkit::npapi::PluginGroup> plugins; - webkit::npapi::WebPluginInfo foo_plugin; + webkit::WebPluginInfo foo_plugin; foo_plugin.path = FilePath(FILE_PATH_LITERAL("a-foo")); foo_plugin.name = ASCIIToUTF16("FooPlugin"); foo_plugin.enabled = - webkit::npapi::WebPluginInfo::USER_ENABLED_POLICY_UNMANAGED; + webkit::WebPluginInfo::USER_ENABLED_POLICY_UNMANAGED; scoped_ptr<webkit::npapi::PluginGroup> foo_group( webkit::npapi::PluginGroup::FromWebPluginInfo(foo_plugin)); plugins.push_back(*foo_group); - webkit::npapi::WebPluginInfo bar_plugin; + webkit::WebPluginInfo bar_plugin; bar_plugin.path = FilePath(FILE_PATH_LITERAL("b-bar")); bar_plugin.name = ASCIIToUTF16("BarPlugin"); bar_plugin.enabled = - webkit::npapi::WebPluginInfo::USER_ENABLED_POLICY_UNMANAGED; + webkit::WebPluginInfo::USER_ENABLED_POLICY_UNMANAGED; scoped_ptr<webkit::npapi::PluginGroup> bar_group( webkit::npapi::PluginGroup::FromWebPluginInfo(bar_plugin)); plugins.push_back(*bar_group); diff --git a/chrome/browser/plugin_observer.cc b/chrome/browser/plugin_observer.cc index ce0c849..0519d8a 100644 --- a/chrome/browser/plugin_observer.cc +++ b/chrome/browser/plugin_observer.cc @@ -24,7 +24,7 @@ #include "webkit/plugins/npapi/default_plugin_shared.h" #include "webkit/plugins/npapi/plugin_group.h" #include "webkit/plugins/npapi/plugin_list.h" -#include "webkit/plugins/npapi/webplugininfo.h" +#include "webkit/plugins/webplugininfo.h" namespace { @@ -335,7 +335,7 @@ void PluginObserver::OnCrashedPlugin(const FilePath& plugin_path) { DCHECK(!plugin_path.value().empty()); string16 plugin_name = plugin_path.LossyDisplayName(); - webkit::npapi::WebPluginInfo plugin_info; + webkit::WebPluginInfo plugin_info; if (webkit::npapi::PluginList::Singleton()->GetPluginInfoByPath( plugin_path, &plugin_info) && !plugin_info.name.empty()) { diff --git a/chrome/browser/plugin_updater.cc b/chrome/browser/plugin_updater.cc index 887fba8..0fa0420b 100644 --- a/chrome/browser/plugin_updater.cc +++ b/chrome/browser/plugin_updater.cc @@ -22,7 +22,7 @@ #include "content/browser/browser_thread.h" #include "content/common/notification_service.h" #include "webkit/plugins/npapi/plugin_list.h" -#include "webkit/plugins/npapi/webplugininfo.h" +#include "webkit/plugins/webplugininfo.h" // How long to wait to save the plugin enabled information, which might need to // go to disk. @@ -33,12 +33,12 @@ PluginUpdater::PluginUpdater() } DictionaryValue* PluginUpdater::CreatePluginFileSummary( - const webkit::npapi::WebPluginInfo& plugin) { + const webkit::WebPluginInfo& plugin) { DictionaryValue* data = new DictionaryValue(); data->SetString("path", plugin.path.value()); data->SetString("name", plugin.name); data->SetString("version", plugin.version); - data->SetBoolean("enabled", webkit::npapi::IsPluginEnabled(plugin)); + data->SetBoolean("enabled", webkit::IsPluginEnabled(plugin)); return data; } @@ -263,7 +263,7 @@ void PluginUpdater::UpdatePreferences(Profile* profile, int delay_ms) { } void PluginUpdater::GetPreferencesDataOnFileThread(void* profile) { - std::vector<webkit::npapi::WebPluginInfo> plugins; + std::vector<webkit::WebPluginInfo> plugins; webkit::npapi::PluginList::Singleton()->GetPlugins(&plugins); std::vector<webkit::npapi::PluginGroup> groups; @@ -279,7 +279,7 @@ void PluginUpdater::GetPreferencesDataOnFileThread(void* profile) { void PluginUpdater::OnUpdatePreferences( Profile* profile, - const std::vector<webkit::npapi::WebPluginInfo>& plugins, + const std::vector<webkit::WebPluginInfo>& plugins, const std::vector<webkit::npapi::PluginGroup>& groups) { ListPrefUpdate update(profile->GetPrefs(), prefs::kPluginsPluginsList); ListValue* plugins_list = update.Get(); @@ -295,10 +295,10 @@ void PluginUpdater::OnUpdatePreferences( DictionaryValue* summary = CreatePluginFileSummary(plugins[i]); // If the plugin is managed by policy, store the user preferred state // instead. - if (plugins[i].enabled & webkit::npapi::WebPluginInfo::MANAGED_MASK) { + if (plugins[i].enabled & webkit::WebPluginInfo::MANAGED_MASK) { bool user_enabled = - (plugins[i].enabled & webkit::npapi::WebPluginInfo::USER_MASK) == - webkit::npapi::WebPluginInfo::USER_ENABLED; + (plugins[i].enabled & webkit::WebPluginInfo::USER_MASK) == + webkit::WebPluginInfo::USER_ENABLED; summary->SetBoolean("enabled", user_enabled); } plugins_list->Append(summary); diff --git a/chrome/browser/plugin_updater.h b/chrome/browser/plugin_updater.h index dc9cfaf..cbc885d 100644 --- a/chrome/browser/plugin_updater.h +++ b/chrome/browser/plugin_updater.h @@ -25,9 +25,9 @@ class ListValue; } namespace webkit { +struct WebPluginInfo; namespace npapi { class PluginGroup; -struct WebPluginInfo; } } @@ -73,7 +73,7 @@ class PluginUpdater : public NotificationObserver { // Called on the UI thread with the plugin data to save the preferences. static void OnUpdatePreferences( Profile* profile, - const std::vector<webkit::npapi::WebPluginInfo>& plugins, + const std::vector<webkit::WebPluginInfo>& plugins, const std::vector<webkit::npapi::PluginGroup>& groups); // Queues sending the notification that plugin data has changed. This is done @@ -84,7 +84,7 @@ class PluginUpdater : public NotificationObserver { static void OnNotifyPluginStatusChanged(); static base::DictionaryValue* CreatePluginFileSummary( - const webkit::npapi::WebPluginInfo& plugin); + const webkit::WebPluginInfo& plugin); // Force plugins to be enabled or disabled due to policy. // |disabled_list| contains the list of StringValues of the names of the diff --git a/chrome/browser/ui/cocoa/drag_util.mm b/chrome/browser/ui/cocoa/drag_util.mm index 88c746b..1e059c8 100644 --- a/chrome/browser/ui/cocoa/drag_util.mm +++ b/chrome/browser/ui/cocoa/drag_util.mm @@ -82,11 +82,11 @@ static BOOL IsSupportedFileURL(const GURL& url) { // TODO(bauerb): This possibly uses stale information, but it's guaranteed not // to do disk access. bool stale = false; - std::vector<webkit::npapi::WebPluginInfo> info_array; + std::vector<webkit::WebPluginInfo> info_array; webkit::npapi::PluginList::Singleton()->GetPluginInfoArray( url, mime_type, false, &stale, &info_array, NULL); for (size_t i = 0; i < info_array.size(); ++i) { - if (webkit::npapi::IsPluginEnabled(info_array[i])) + if (webkit::IsPluginEnabled(info_array[i])) return true; } diff --git a/chrome/browser/ui/webui/flash_ui.cc b/chrome/browser/ui/webui/flash_ui.cc index 188bf73..a8a2793 100644 --- a/chrome/browser/ui/webui/flash_ui.cc +++ b/chrome/browser/ui/webui/flash_ui.cc @@ -27,7 +27,7 @@ #include "ui/base/l10n/l10n_util.h" #include "ui/base/resource/resource_bundle.h" #include "webkit/plugins/npapi/plugin_list.h" -#include "webkit/plugins/npapi/webplugininfo.h" +#include "webkit/plugins/webplugininfo.h" #if defined(OS_WIN) #include "base/win/windows_version.h" @@ -221,7 +221,7 @@ void FlashDOMHandler::MaybeRespondToPage() { AddPair(list, l10n_util::GetStringUTF16(IDS_ABOUT_VERSION_OS), os_label); // Obtain the version of the Flash plugins. - std::vector<webkit::npapi::WebPluginInfo> info_array; + std::vector<webkit::WebPluginInfo> info_array; webkit::npapi::PluginList::Singleton()->GetPluginInfoArray( GURL(), "application/x-shockwave-flash", false, NULL, &info_array, NULL); string16 flash_version; @@ -229,7 +229,7 @@ void FlashDOMHandler::MaybeRespondToPage() { AddPair(list, ASCIIToUTF16("Flash plugin"), "Disabled"); } else { for (size_t i = 0; i < info_array.size(); ++i) { - if (webkit::npapi::IsPluginEnabled(info_array[i])) { + if (webkit::IsPluginEnabled(info_array[i])) { flash_version = info_array[i].version + ASCIIToUTF16(" ") + info_array[i].path.LossyDisplayName(); if (i != 0) diff --git a/chrome/common/chrome_content_client.cc b/chrome/common/chrome_content_client.cc index 1adc397..c355815 100644 --- a/chrome/common/chrome_content_client.cc +++ b/chrome/common/chrome_content_client.cc @@ -85,10 +85,10 @@ void ComputeBuiltInPlugins(std::vector<PepperPluginInfo>* plugins) { PepperPluginInfo pdf; pdf.path = path; pdf.name = kPDFPluginName; - webkit::npapi::WebPluginMimeType pdf_mime_type(kPDFPluginMimeType, - kPDFPluginExtension, - kPDFPluginDescription); - webkit::npapi::WebPluginMimeType print_preview_pdf_mime_type( + webkit::WebPluginMimeType pdf_mime_type(kPDFPluginMimeType, + kPDFPluginExtension, + kPDFPluginDescription); + webkit::WebPluginMimeType print_preview_pdf_mime_type( kPDFPluginPrintPreviewMimeType, kPDFPluginExtension, kPDFPluginDescription); @@ -110,9 +110,9 @@ void ComputeBuiltInPlugins(std::vector<PepperPluginInfo>* plugins) { PepperPluginInfo nacl; nacl.path = path; nacl.name = kNaClPluginName; - webkit::npapi::WebPluginMimeType nacl_mime_type(kNaClPluginMimeType, - kNaClPluginExtension, - kNaClPluginDescription); + webkit::WebPluginMimeType nacl_mime_type(kNaClPluginMimeType, + kNaClPluginExtension, + kNaClPluginDescription); nacl.mime_types.push_back(nacl_mime_type); plugins->push_back(nacl); @@ -126,12 +126,12 @@ void ComputeBuiltInPlugins(std::vector<PepperPluginInfo>* plugins) { info.is_internal = true; info.name = kRemotingViewerPluginName; info.path = FilePath(kRemotingViewerPluginPath); - webkit::npapi::WebPluginMimeType remoting_mime_type( + webkit::WebPluginMimeType remoting_mime_type( kRemotingViewerPluginMimeType, std::string(), std::string()); info.mime_types.push_back(remoting_mime_type); - webkit::npapi::WebPluginMimeType old_remoting_mime_type( + webkit::WebPluginMimeType old_remoting_mime_type( kRemotingViewerPluginOldMimeType, std::string(), std::string()); @@ -183,13 +183,13 @@ void AddOutOfProcessFlash(std::vector<PepperPluginInfo>* plugins) { plugin.description = plugin.name + " " + flash_version_numbers[0] + "." + flash_version_numbers[1] + " r" + flash_version_numbers[2]; plugin.version = JoinString(flash_version_numbers, '.'); - webkit::npapi::WebPluginMimeType swf_mime_type(kFlashPluginSwfMimeType, - kFlashPluginSwfExtension, - kFlashPluginSwfDescription); + webkit::WebPluginMimeType swf_mime_type(kFlashPluginSwfMimeType, + kFlashPluginSwfExtension, + kFlashPluginSwfDescription); plugin.mime_types.push_back(swf_mime_type); - webkit::npapi::WebPluginMimeType spl_mime_type(kFlashPluginSplMimeType, - kFlashPluginSplExtension, - kFlashPluginSplDescription); + webkit::WebPluginMimeType spl_mime_type(kFlashPluginSplMimeType, + kFlashPluginSplExtension, + kFlashPluginSplDescription); plugin.mime_types.push_back(spl_mime_type); plugins->push_back(plugin); } diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc index 2a03c82..31db342 100644 --- a/chrome/renderer/chrome_content_renderer_client.cc +++ b/chrome/renderer/chrome_content_renderer_client.cc @@ -282,7 +282,7 @@ WebPlugin* ChromeContentRendererClient::CreatePluginImpl( bool found = false; *is_default_plugin = false; CommandLine* cmd = CommandLine::ForCurrentProcess(); - webkit::npapi::WebPluginInfo info; + webkit::WebPluginInfo info; GURL url(original_params.url); std::string orig_mime_type = original_params.mimeType.utf8(); std::string actual_mime_type; @@ -292,7 +292,7 @@ WebPlugin* ChromeContentRendererClient::CreatePluginImpl( if (!found) return NULL; - if (!webkit::npapi::IsPluginEnabled(info)) + if (!webkit::IsPluginEnabled(info)) return NULL; *is_default_plugin = @@ -410,7 +410,7 @@ WebPlugin* ChromeContentRendererClient::CreatePluginImpl( string16 nacl_attr = ASCIIToUTF16(kNaClPluginManifestAttribute); for (size_t i = 0; i < info.mime_types.size(); ++i) { if (info.mime_types[i].mime_type == actual_mime_type) { - const webkit::npapi::WebPluginMimeType& content_type = + const webkit::WebPluginMimeType& content_type = info.mime_types[i]; for (size_t i = 0; i < content_type.additional_param_names.size(); ++i) { |