diff options
| author | tbansal <tbansal@chromium.org> | 2015-06-01 13:24:18 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-06-01 20:25:21 +0000 |
| commit | a1caf96152e70ce6ccaebf3ad8fb770712e30b3d (patch) | |
| tree | 6707916bf1f3b5ee94a84ca817049261526a4dbb /chrome | |
| parent | fdab0b6ab8f795ec7d8cecd8bf696586de2eb7c7 (diff) | |
| download | chromium_src-a1caf96152e70ce6ccaebf3ad8fb770712e30b3d.zip chromium_src-a1caf96152e70ce6ccaebf3ad8fb770712e30b3d.tar.gz chromium_src-a1caf96152e70ce6ccaebf3ad8fb770712e30b3d.tar.bz2 | |
Fix two NetworkQualityEstimator tests that were failing
on Windows.
Current guess is that timer on Windows is low resolution
(~16 msec).
This can cause request.creation_time to be equal to
last_connection_change_. This was causing following
2 tests to fail on Windows:
(1) NetworkQualityEstimatorTest.TestPeakKbpsFastestRTTUpdates
(2) URLRequestTestHTTP.NetworkQualityEstimator
If the guess is correct, these tests could potentially fail
on other platforms too.
Trying a fix which makes this check less stringent. Now,
if request creation time is exactly equal to time of last
connection change, the request is still used to
estimate the network quality (unlike before, when the
former was required to be strictly larger than the latter).
BUG=492410
Review URL: https://codereview.chromium.org/1153023003
Cr-Commit-Position: refs/heads/master@{#332259}
Diffstat (limited to 'chrome')
0 files changed, 0 insertions, 0 deletions