diff options
| author | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-11 17:17:13 +0000 |
|---|---|---|
| committer | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-11 17:17:13 +0000 |
| commit | c19ba104272c5444354f4b22c1411e634c935c83 (patch) | |
| tree | 6e30fdfe3ad22e562c2c134993487ed3609fb7ac /chrome | |
| parent | 2201708e3cb773d707bd92f496b61033650ca0fa (diff) | |
| download | chromium_src-c19ba104272c5444354f4b22c1411e634c935c83.zip chromium_src-c19ba104272c5444354f4b22c1411e634c935c83.tar.gz chromium_src-c19ba104272c5444354f4b22c1411e634c935c83.tar.bz2 | |
Add UMA action InstantExtended.ShowSRP.
chromeactions.txt also picked up some hashes for other actions
that were added but didn't update the file.
BUG=178525
TEST=Click on a clickable doodle or search through
the omnibox and check that the new UMA action is
shown on chrome://user-actions.
Review URL: https://chromiumcodereview.appspot.com/12546011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187308 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/browser/ui/browser_instant_controller.cc | 11 | ||||
| -rw-r--r-- | chrome/tools/chromeactions.txt | 3 |
2 files changed, 13 insertions, 1 deletions
diff --git a/chrome/browser/ui/browser_instant_controller.cc b/chrome/browser/ui/browser_instant_controller.cc index d1628b1..5ffb7f0 100644 --- a/chrome/browser/ui/browser_instant_controller.cc +++ b/chrome/browser/ui/browser_instant_controller.cc @@ -107,7 +107,6 @@ bool BrowserInstantController::MaybeSwapInInstantNTPContents( // inserting instant_ntp into the tabstrip and will take ownership. ignore_result(instant_ntp.release()); } - content::RecordAction(UserMetricsAction("InstantExtended.ShowNTP")); return true; } @@ -239,6 +238,16 @@ void BrowserInstantController::ResetInstant(const std::string& pref_name) { void BrowserInstantController::ModeChanged(const search::Mode& old_mode, const search::Mode& new_mode) { + if (search::IsInstantExtendedAPIEnabled()) { + // Record some actions corresponding to the mode change. Note that to get + // the full story, it's necessary to look at other UMA actions as well, + // such as tab switches. + if (new_mode.is_search_results()) + content::RecordAction(UserMetricsAction("InstantExtended.ShowSRP")); + else if (new_mode.is_ntp()) + content::RecordAction(UserMetricsAction("InstantExtended.ShowNTP")); + } + // If mode is now |NTP|, send theme-related information to Instant. if (new_mode.is_ntp()) UpdateThemeInfo(); diff --git a/chrome/tools/chromeactions.txt b/chrome/tools/chromeactions.txt index f439266..b3a82aa 100644 --- a/chrome/tools/chromeactions.txt +++ b/chrome/tools/chromeactions.txt @@ -126,6 +126,7 @@ 0x878b28b309d1205e BadMessageTerminate_AOF 0xec6518c4af50b7ac BadMessageTerminate_BMF 0x1f57dc66c6c91837 BadMessageTerminate_BPE +0x0eba05c9a1e2be6a BadMessageTerminate_BPGM 0x5a858938e484c903 BadMessageTerminate_BRPH 0x6f41bf748eb54008 BadMessageTerminate_DBMF 0xd910b7f4e1b53c11 BadMessageTerminate_DSMF @@ -252,6 +253,7 @@ 0xe1b2d67ea37c5ba0 ClickToPlay_InfobarShown 0xcfe5a8d495d7df34 ClickToPlay_LoadAll_Bubble 0xb30dcb1850e21bce ClickToPlay_LoadAll_Infobar +0x9cd1157e30fc2b55 ClickedBookmarkBarAppsShortcutButton 0x57b3678b429935ee ClickedBookmarkBarFolder 0x55c851e7c3d9a792 ClickedBookmarkBarURLButton 0x4f667771b8f484b1 CloseAllSuppressedPopups @@ -496,6 +498,7 @@ 0x1342e1e52f335f69 InsertUnorderedList 0xb7c371f7dd19c6fd InstallSite 0x3545f6127f5688ab InstantExtended.ShowNTP +0x67ae87c0c5a6f55d InstantExtended.ShowSRP 0x1d874710ccdcd46b Italic 0x5569092107ae9fb0 JustifyCenter 0xb2e54b8c7671e92e JustifyLeft |