diff options
| author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-19 22:16:20 +0000 |
|---|---|---|
| committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-19 22:16:20 +0000 |
| commit | e804e052523e23df3881132ab2e31791e0c0d1b6 (patch) | |
| tree | 265c66d614f19e25164be714c94764eeed5e6e0c /chrome | |
| parent | d53b58c0c7e6e15446fd431e06d8f57c5fdc4734 (diff) | |
| download | chromium_src-e804e052523e23df3881132ab2e31791e0c0d1b6.zip chromium_src-e804e052523e23df3881132ab2e31791e0c0d1b6.tar.gz chromium_src-e804e052523e23df3881132ab2e31791e0c0d1b6.tar.bz2 | |
Two purify supression changes:
* Supress UMR in RSAPrivateKey::ExportPrivateKey(). From
what I can see, this really is a false positive. The
byte is 0xCD, at the exact place the error is reported
n Purify. Other supporting evidence is that it doesn't
always occur in the same place. Since we are generating
random keys, you'd expect to see the error show up
every so often wherever we are reading that memory.
* Remove supression of MOZ_Z_Deflate. Purify says this no
longer occurs. Not sure why.
Review URL: http://codereview.chromium.org/131097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18863 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/test/data/purify/unit_tests.exe_UMR.txt | 18 | ||||
| -rw-r--r-- | chrome/test/data/purify/unit_tests.exe_UMR_flakey.txt | 18 |
2 files changed, 18 insertions, 18 deletions
diff --git a/chrome/test/data/purify/unit_tests.exe_UMR.txt b/chrome/test/data/purify/unit_tests.exe_UMR.txt index da8abe0..e69de29 100644 --- a/chrome/test/data/purify/unit_tests.exe_UMR.txt +++ b/chrome/test/data/purify/unit_tests.exe_UMR.txt @@ -1,18 +0,0 @@ -Uninitialized memory read in MOZ_Z_deflate -Error Location - third_party/zlib/deflate.c MOZ_Z_deflate - third_party/zlib/contrib/minizip/zip.c zipCloseFileInZipRaw - third_party/zlib/contrib/minizip/zip.c zipCloseFileInZip - chrome/common/zip.cc AddEntryToZip - chrome/common/zip.cc Zip(FilePath const&,FilePath const&) - chrome/common/zip_unittest.cc ZipTest_Zip_Test::TestBody(void) - testing/gtest/src/gtest.cc testing::Test::Run(void) - ^^^ -Alloc Location - ... - third_party/zlib/contrib/minizip/zip.c zipOpen2 - chrome/common/zip.cc Zip(FilePath const&,FilePath const&) - chrome/common/zip_unittest.cc ZipTest_Zip_Test::TestBody(void) - testing/gtest/src/gtest.cc testing::Test::Run(void) - ^^^ - diff --git a/chrome/test/data/purify/unit_tests.exe_UMR_flakey.txt b/chrome/test/data/purify/unit_tests.exe_UMR_flakey.txt index a737c34..7065cad 100644 --- a/chrome/test/data/purify/unit_tests.exe_UMR_flakey.txt +++ b/chrome/test/data/purify/unit_tests.exe_UMR_flakey.txt @@ -98,3 +98,21 @@ Alloc Location testing/gtest/src/gtest.cc testing::Test::Run(void) ^^^ +Uninitialized memory read in `anonymous namespace'::PrependInteger +Error Location + base/crypto/rsa_private_key_win.cc `anonymous namespace'::PrependInteger + base/crypto/rsa_private_key_win.cc base::RSAPrivateKey::ExportPrivateKey(vector::std *) + chrome/browser/extensions/extension_creator.cc ExtensionCreator::GenerateKey(FilePath const&) + chrome/browser/extensions/extension_creator.cc ExtensionCreator::Run(FilePath const&,FilePath const&,FilePath const&,FilePath const&) + chrome/browser/extensions/extensions_service_unittest.cc ExtensionsServiceTest_PackExtension_Test::TestBody(void) + testing/gtest/src/gtest.cc testing::Test::Run(void) + ^^^ +Alloc Location + ... + base/crypto/rsa_private_key_win.cc base::RSAPrivateKey::ExportPrivateKey(vector::std *) + chrome/browser/extensions/extension_creator.cc ExtensionCreator::GenerateKey(FilePath const&) + chrome/browser/extensions/extension_creator.cc ExtensionCreator::Run(FilePath const&,FilePath const&,FilePath const&,FilePath const&) + chrome/browser/extensions/extensions_service_unittest.cc ExtensionsServiceTest_PackExtension_Test::TestBody(void) + testing/gtest/src/gtest.cc testing::Test::Run(void) + ^^^ + |