diff options
author | mnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-05 07:57:10 +0000 |
---|---|---|
committer | mnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-05 07:57:10 +0000 |
commit | f861719588545d92ba979f491f4cd10cbf544016 (patch) | |
tree | 5f5a64d4ba48a8d884ee360a562fb08371404ed6 /chrome | |
parent | 84aa957953cf6eb36c4e8886a28aede5fd98f748 (diff) | |
download | chromium_src-f861719588545d92ba979f491f4cd10cbf544016.zip chromium_src-f861719588545d92ba979f491f4cd10cbf544016.tar.gz chromium_src-f861719588545d92ba979f491f4cd10cbf544016.tar.bz2 |
Re-land r51526
Auto-size the views version of the options dialog.
This adds support for auto-sizing tab controls, adjusts the options dialog to
use it and takes care of any fallout due to the new layout handling. Also fixes
a couple of small bugs in the views Layout() machinery and sanitizes layouting
of options pages.
BUG=36497
TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language.
original issuse: http://codereview.chromium.org/2812026/show
Review URL: http://codereview.chromium.org/2883022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51628 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome')
60 files changed, 95 insertions, 217 deletions
diff --git a/chrome/app/resources/locale_settings.grd b/chrome/app/resources/locale_settings.grd index bc8ccf7..2256e0f 100644 --- a/chrome/app/resources/locale_settings.grd +++ b/chrome/app/resources/locale_settings.grd @@ -243,18 +243,6 @@ en-US </message> - <!-- The width of the Options dialog box, in characters (character width = --> - <!-- average character width for default dialog box font) --> - <message name="IDS_OPTIONS_DIALOG_WIDTH_CHARS" use_name_for_id="true"> - 98 - </message> - - <!-- The height of the Options dialog box, in lines (line height = character --> - <!-- height for default dialog box font) --> - <message name="IDS_OPTIONS_DIALOG_HEIGHT_LINES" use_name_for_id="true"> - 36 - </message> - <!-- The width of the title column of the Options dialog box, in characters (see --> <!-- above for defn of character width) --> <message name="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS" use_name_for_id="true"> diff --git a/chrome/app/resources/locale_settings_am.xtb b/chrome/app/resources/locale_settings_am.xtb index d5720c8..9dd35eb3 100644 --- a/chrome/app/resources/locale_settings_am.xtb +++ b/chrome/app/resources/locale_settings_am.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-GB</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">36</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">23</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_ar.xtb b/chrome/app/resources/locale_settings_ar.xtb index 185561c..56d567f 100644 --- a/chrome/app/resources/locale_settings_ar.xtb +++ b/chrome/app/resources/locale_settings_ar.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1256</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">105</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_bg.xtb b/chrome/app/resources/locale_settings_bg.xtb index 312ed32..d66d8c9 100644 --- a/chrome/app/resources/locale_settings_bg.xtb +++ b/chrome/app/resources/locale_settings_bg.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1251</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">bg-BG</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">120</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">24</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_bn.xtb b/chrome/app/resources/locale_settings_bn.xtb index f6fadf9..ae611a3 100644 --- a/chrome/app/resources/locale_settings_bn.xtb +++ b/chrome/app/resources/locale_settings_bn.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">33</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_ca.xtb b/chrome/app/resources/locale_settings_ca.xtb index 7a24dac..4f839e6 100644 --- a/chrome/app/resources/locale_settings_ca.xtb +++ b/chrome/app/resources/locale_settings_ca.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">ca</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">106</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_cs.xtb b/chrome/app/resources/locale_settings_cs.xtb index e6c0b2e..23fb131 100644 --- a/chrome/app/resources/locale_settings_cs.xtb +++ b/chrome/app/resources/locale_settings_cs.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1250</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">cs</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">102</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">38</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_da.xtb b/chrome/app/resources/locale_settings_da.xtb index ae1ccda..672c0e6 100644 --- a/chrome/app/resources/locale_settings_da.xtb +++ b/chrome/app/resources/locale_settings_da.xtb @@ -5,13 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">da</translation> -<if expr="pp_if('chromeos')"> - <translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">118</translation> -</if> -<if expr="not pp_if('chromeos')"> - <translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -</if> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">23</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_de.xtb b/chrome/app/resources/locale_settings_de.xtb index 8f0fa3b..68ad69e 100644 --- a/chrome/app/resources/locale_settings_de.xtb +++ b/chrome/app/resources/locale_settings_de.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">de</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">108</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_el.xtb b/chrome/app/resources/locale_settings_el.xtb index 50e7e23..ce3214f 100644 --- a/chrome/app/resources/locale_settings_el.xtb +++ b/chrome/app/resources/locale_settings_el.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-7</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">el</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">106</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">41</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">20</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_en-GB.xtb b/chrome/app/resources/locale_settings_en-GB.xtb index 074849e..a879f7d 100644 --- a/chrome/app/resources/locale_settings_en-GB.xtb +++ b/chrome/app/resources/locale_settings_en-GB.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-GB</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">23</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_es-419.xtb b/chrome/app/resources/locale_settings_es-419.xtb index a57d6a1..deeb693 100644 --- a/chrome/app/resources/locale_settings_es-419.xtb +++ b/chrome/app/resources/locale_settings_es-419.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">es</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">104</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">24</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_es.xtb b/chrome/app/resources/locale_settings_es.xtb index 9d89f10..bcb3afa 100644 --- a/chrome/app/resources/locale_settings_es.xtb +++ b/chrome/app/resources/locale_settings_es.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">es</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">104</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">24</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_et.xtb b/chrome/app/resources/locale_settings_et.xtb index c023344..1a2bed8 100644 --- a/chrome/app/resources/locale_settings_et.xtb +++ b/chrome/app/resources/locale_settings_et.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1257</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">et</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">102</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_fi.xtb b/chrome/app/resources/locale_settings_fi.xtb index fd25c04..96b5866 100644 --- a/chrome/app/resources/locale_settings_fi.xtb +++ b/chrome/app/resources/locale_settings_fi.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_fil.xtb b/chrome/app/resources/locale_settings_fil.xtb index 17f2568..fabcb7d 100644 --- a/chrome/app/resources/locale_settings_fil.xtb +++ b/chrome/app/resources/locale_settings_fil.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">106</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">41</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_fr.xtb b/chrome/app/resources/locale_settings_fr.xtb index ac86bf0..0d4cc13 100644 --- a/chrome/app/resources/locale_settings_fr.xtb +++ b/chrome/app/resources/locale_settings_fr.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">fr</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">112</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">24</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_gu.xtb b/chrome/app/resources/locale_settings_gu.xtb index 66b719d..909f704 100644 --- a/chrome/app/resources/locale_settings_gu.xtb +++ b/chrome/app/resources/locale_settings_gu.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">102</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_he.xtb b/chrome/app/resources/locale_settings_he.xtb index a832f7f..2ddc8a8 100644 --- a/chrome/app/resources/locale_settings_he.xtb +++ b/chrome/app/resources/locale_settings_he.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1255</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">true</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">he</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">25</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_hi.xtb b/chrome/app/resources/locale_settings_hi.xtb index 79b98a7..bb26525 100644 --- a/chrome/app/resources/locale_settings_hi.xtb +++ b/chrome/app/resources/locale_settings_hi.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">hi</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">34</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_hr.xtb b/chrome/app/resources/locale_settings_hr.xtb index c581fd0..e4c9aa2 100644 --- a/chrome/app/resources/locale_settings_hr.xtb +++ b/chrome/app/resources/locale_settings_hr.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1250</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">hr</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">102</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">38</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_hu.xtb b/chrome/app/resources/locale_settings_hu.xtb index de89fc7..2cf74f8 100644 --- a/chrome/app/resources/locale_settings_hu.xtb +++ b/chrome/app/resources/locale_settings_hu.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-2</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">hu-HU</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">106</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_id.xtb b/chrome/app/resources/locale_settings_id.xtb index 4202bda..a384576 100644 --- a/chrome/app/resources/locale_settings_id.xtb +++ b/chrome/app/resources/locale_settings_id.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">id</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_it.xtb b/chrome/app/resources/locale_settings_it.xtb index 6ec00f6..46a86a0 100644 --- a/chrome/app/resources/locale_settings_it.xtb +++ b/chrome/app/resources/locale_settings_it.xtb @@ -5,13 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">it</translation> -<if expr="pp_if('chromeos')"> - <translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">114</translation> -</if> -<if expr="not pp_if('chromeos')"> - <translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -</if> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_ja.xtb b/chrome/app/resources/locale_settings_ja.xtb index 1a531e7..8adf02e 100644 --- a/chrome/app/resources/locale_settings_ja.xtb +++ b/chrome/app/resources/locale_settings_ja.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">Shift_JIS</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">104</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">25</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_kn.xtb b/chrome/app/resources/locale_settings_kn.xtb index f813251..490c366 100644 --- a/chrome/app/resources/locale_settings_kn.xtb +++ b/chrome/app/resources/locale_settings_kn.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">106</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">34</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_ko.xtb b/chrome/app/resources/locale_settings_ko.xtb index 33474c8..a27126f 100644 --- a/chrome/app/resources/locale_settings_ko.xtb +++ b/chrome/app/resources/locale_settings_ko.xtb @@ -9,8 +9,6 @@ <translation id="IDS_MINIMUM_LOGICAL_FONT_SIZE">10</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_lt.xtb b/chrome/app/resources/locale_settings_lt.xtb index 532ec55..b9b3890 100644 --- a/chrome/app/resources/locale_settings_lt.xtb +++ b/chrome/app/resources/locale_settings_lt.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1257</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">lt</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">104</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">38</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_lv.xtb b/chrome/app/resources/locale_settings_lv.xtb index 113a216..4870327 100644 --- a/chrome/app/resources/locale_settings_lv.xtb +++ b/chrome/app/resources/locale_settings_lv.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1257</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">lv</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">102</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">38</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_ml.xtb b/chrome/app/resources/locale_settings_ml.xtb index 96523fd..4195bd1 100644 --- a/chrome/app/resources/locale_settings_ml.xtb +++ b/chrome/app/resources/locale_settings_ml.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">114</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">36</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">87</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_mr.xtb b/chrome/app/resources/locale_settings_mr.xtb index fbcac2e..818c06c 100644 --- a/chrome/app/resources/locale_settings_mr.xtb +++ b/chrome/app/resources/locale_settings_mr.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">34</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_nb.xtb b/chrome/app/resources/locale_settings_nb.xtb index ef4109c..2d3fe94 100644 --- a/chrome/app/resources/locale_settings_nb.xtb +++ b/chrome/app/resources/locale_settings_nb.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">nb</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">104</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">25</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_nl.xtb b/chrome/app/resources/locale_settings_nl.xtb index 10f94a1..9cd360f 100644 --- a/chrome/app/resources/locale_settings_nl.xtb +++ b/chrome/app/resources/locale_settings_nl.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">nl</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">108</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">30</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_or.xtb b/chrome/app/resources/locale_settings_or.xtb index 9ab3eb6..f615091 100644 --- a/chrome/app/resources/locale_settings_or.xtb +++ b/chrome/app/resources/locale_settings_or.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">34</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_pl.xtb b/chrome/app/resources/locale_settings_pl.xtb index 1558d8e..d130b01 100644 --- a/chrome/app/resources/locale_settings_pl.xtb +++ b/chrome/app/resources/locale_settings_pl.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-2</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">pl</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">105</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">38</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">25</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_pt-BR.xtb b/chrome/app/resources/locale_settings_pt-BR.xtb index e0d3a64..fa74574 100644 --- a/chrome/app/resources/locale_settings_pt-BR.xtb +++ b/chrome/app/resources/locale_settings_pt-BR.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">pt-BR</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">110</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">30</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_pt-PT.xtb b/chrome/app/resources/locale_settings_pt-PT.xtb index 30da552..0f275cb 100644 --- a/chrome/app/resources/locale_settings_pt-PT.xtb +++ b/chrome/app/resources/locale_settings_pt-PT.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">pt-PT</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">110</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">30</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_ro.xtb b/chrome/app/resources/locale_settings_ro.xtb index 11c1ca4..1ce3d43 100644 --- a/chrome/app/resources/locale_settings_ro.xtb +++ b/chrome/app/resources/locale_settings_ro.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-2</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">ro</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">104</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_ru.xtb b/chrome/app/resources/locale_settings_ru.xtb index c837201..78c8730 100644 --- a/chrome/app/resources/locale_settings_ru.xtb +++ b/chrome/app/resources/locale_settings_ru.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1251</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">ru</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">122</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_sk.xtb b/chrome/app/resources/locale_settings_sk.xtb index 147a656..211ef79 100644 --- a/chrome/app/resources/locale_settings_sk.xtb +++ b/chrome/app/resources/locale_settings_sk.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1250</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">sk</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">104</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">38</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_sl.xtb b/chrome/app/resources/locale_settings_sl.xtb index 1329afa..ec7d084 100644 --- a/chrome/app/resources/locale_settings_sl.xtb +++ b/chrome/app/resources/locale_settings_sl.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-2</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">sl</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_sr.xtb b/chrome/app/resources/locale_settings_sr.xtb index 04a1b4e..3be27ea 100644 --- a/chrome/app/resources/locale_settings_sr.xtb +++ b/chrome/app/resources/locale_settings_sr.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1251</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">106</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_sv.xtb b/chrome/app/resources/locale_settings_sv.xtb index d49037d..48c286b 100644 --- a/chrome/app/resources/locale_settings_sv.xtb +++ b/chrome/app/resources/locale_settings_sv.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">sv</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">100</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">25</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_sw.xtb b/chrome/app/resources/locale_settings_sw.xtb index a70cdde..c323604 100644 --- a/chrome/app/resources/locale_settings_sw.xtb +++ b/chrome/app/resources/locale_settings_sw.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-GB</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">23</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_ta.xtb b/chrome/app/resources/locale_settings_ta.xtb index 61edcd1..41c0005 100644 --- a/chrome/app/resources/locale_settings_ta.xtb +++ b/chrome/app/resources/locale_settings_ta.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">120</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">41</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_te.xtb b/chrome/app/resources/locale_settings_te.xtb index 6a53c74..f39635a 100644 --- a/chrome/app/resources/locale_settings_te.xtb +++ b/chrome/app/resources/locale_settings_te.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-1</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">106</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">32</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_th.xtb b/chrome/app/resources/locale_settings_th.xtb index cd538d9..a373609 100644 --- a/chrome/app/resources/locale_settings_th.xtb +++ b/chrome/app/resources/locale_settings_th.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-874</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_tr.xtb b/chrome/app/resources/locale_settings_tr.xtb index 8213ddd..ce582db 100644 --- a/chrome/app/resources/locale_settings_tr.xtb +++ b/chrome/app/resources/locale_settings_tr.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">ISO-8859-9</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">tr</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">100</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_uk.xtb b/chrome/app/resources/locale_settings_uk.xtb index 696323f..7cb7a1d 100644 --- a/chrome/app/resources/locale_settings_uk.xtb +++ b/chrome/app/resources/locale_settings_uk.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1251</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">108</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">40</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_vi.xtb b/chrome/app/resources/locale_settings_vi.xtb index 6246dd7..d7f626f 100644 --- a/chrome/app/resources/locale_settings_vi.xtb +++ b/chrome/app/resources/locale_settings_vi.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">windows-1258</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">vi</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">41</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_zh-CN.xtb b/chrome/app/resources/locale_settings_zh-CN.xtb index 5d2fc0d..a8efab8 100644 --- a/chrome/app/resources/locale_settings_zh-CN.xtb +++ b/chrome/app/resources/locale_settings_zh-CN.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">GBK</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">98</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">26</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/app/resources/locale_settings_zh-TW.xtb b/chrome/app/resources/locale_settings_zh-TW.xtb index fa8b3ba..3ccbf87 100644 --- a/chrome/app/resources/locale_settings_zh-TW.xtb +++ b/chrome/app/resources/locale_settings_zh-TW.xtb @@ -5,8 +5,6 @@ <translation id="IDS_DEFAULT_ENCODING">Big5</translation> <translation id="IDS_USES_UNIVERSAL_DETECTOR">false</translation> <translation id="IDS_SPELLCHECK_DICTIONARY">en-US</translation> -<translation id="IDS_OPTIONS_DIALOG_WIDTH_CHARS">95</translation> -<translation id="IDS_OPTIONS_DIALOG_HEIGHT_LINES">39</translation> <translation id="IDS_OPTIONS_DIALOG_LEFT_COLUMN_WIDTH_CHARS">25</translation> <translation id="IDS_OPTIONS_RESET_CONFIRM_BOX_WIDTH_CHARS">80</translation> <translation id="IDS_URLPICKER_DIALOG_WIDTH_CHARS">80</translation> diff --git a/chrome/browser/chromeos/options/options_window_view.cc b/chrome/browser/chromeos/options/options_window_view.cc index d284ce3..4535e8b 100644 --- a/chrome/browser/chromeos/options/options_window_view.cc +++ b/chrome/browser/chromeos/options/options_window_view.cc @@ -35,6 +35,48 @@ namespace chromeos { /////////////////////////////////////////////////////////////////////////////// +// GtkPreferencePageHost +// +// Hosts a GTK preference page and takes care of sizing it appropriately. +// +class GtkPreferencePageHost : public views::NativeViewHost { + public: + explicit GtkPreferencePageHost(GtkWidget* widget); + + private: + // views::View overrides: + virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child); + virtual gfx::Size GetPreferredSize(); + + GtkWidget* widget_; + + DISALLOW_COPY_AND_ASSIGN(GtkPreferencePageHost); +}; + +GtkPreferencePageHost::GtkPreferencePageHost(GtkWidget* widget) + : widget_(widget) { + set_background(views::Background::CreateSolidBackground(SK_ColorWHITE)); +} + +void GtkPreferencePageHost::ViewHierarchyChanged(bool is_add, + View* parent, + View* child) { + NativeViewHost::ViewHierarchyChanged(is_add, parent, child); + if (is_add && child == this) + Attach(widget_); +} + +gfx::Size GtkPreferencePageHost::GetPreferredSize() { + // We need to show the widget and its children since otherwise containers like + // gtk_box don't compute the correct size. + gtk_widget_show_all(widget_); + GtkRequisition requisition = { 0, 0 }; + gtk_widget_size_request(GTK_WIDGET(widget_), &requisition); + GtkRequisition& size(widget_->requisition); + return gfx::Size(size.width, size.height); +} + +/////////////////////////////////////////////////////////////////////////////// // OptionsWindowView // // The contents of the Options dialog window. @@ -214,9 +256,9 @@ void OptionsWindowView::Layout() { } gfx::Size OptionsWindowView::GetPreferredSize() { - return gfx::Size(views::Window::GetLocalizedContentsSize( - IDS_OPTIONS_DIALOG_WIDTH_CHARS, - IDS_OPTIONS_DIALOG_HEIGHT_LINES)); + gfx::Size size(tabs_->GetPreferredSize()); + size.Enlarge(2 * kDialogPadding, 2 * kDialogPadding); + return size; } void OptionsWindowView::ViewHierarchyChanged(bool is_add, @@ -263,29 +305,23 @@ void OptionsWindowView::Init() { l10n_util::GetString(IDS_OPTIONS_INTERNET_TAB_LABEL), internet_page, false); - views::NativeViewHost* general_page_view = new views::NativeViewHost(); - general_page_view->set_background(views::Background::CreateSolidBackground( - SK_ColorWHITE)); tabs_->AddTabAtIndex(tab_index++, l10n_util::GetString(IDS_OPTIONS_GENERAL_TAB_LABEL), - general_page_view, false); - general_page_view->Attach(general_page_.get_page_widget()); + new GtkPreferencePageHost( + general_page_.get_page_widget()), + false); - views::NativeViewHost* content_page_view = new views::NativeViewHost(); - content_page_view->set_background(views::Background::CreateSolidBackground( - SK_ColorWHITE)); tabs_->AddTabAtIndex(tab_index++, l10n_util::GetString(IDS_OPTIONS_CONTENT_TAB_LABEL), - content_page_view, false); - content_page_view->Attach(content_page_.get_page_widget()); + new GtkPreferencePageHost( + content_page_.get_page_widget()), + false); - views::NativeViewHost* advanced_page_view = new views::NativeViewHost(); - advanced_page_view->set_background(views::Background::CreateSolidBackground( - SK_ColorWHITE)); tabs_->AddTabAtIndex(tab_index++, l10n_util::GetString(IDS_OPTIONS_ADVANCED_TAB_LABEL), - advanced_page_view, false); - advanced_page_view->Attach(advanced_page_.get_page_widget()); + new GtkPreferencePageHost( + advanced_page_.get_page_widget()), + false); DCHECK(tabs_->GetTabCount() == OPTIONS_PAGE_COUNT); @@ -344,4 +380,3 @@ void ShowOptionsWindow(OptionsPage page, OptionsWindowView::instance_->ShowOptionsPage(page, highlight_group); } - diff --git a/chrome/browser/views/options/advanced_contents_view.cc b/chrome/browser/views/options/advanced_contents_view.cc index 9ee6485e..bbe232f 100644 --- a/chrome/browser/views/options/advanced_contents_view.cc +++ b/chrome/browser/views/options/advanced_contents_view.cc @@ -287,7 +287,6 @@ AdvancedSection::AdvancedSection(Profile* profile, void AdvancedSection::DidChangeBounds(const gfx::Rect& previous, const gfx::Rect& current) { Layout(); - contents_->Layout(); } //////////////////////////////////////////////////////////////////////////////// @@ -434,9 +433,6 @@ class PrivacySection : public AdvancedSection, // Overridden from views::LinkController: virtual void LinkActivated(views::Link* source, int event_flags); - // Overridden from views::View: - virtual void Layout(); - protected: // OptionsPageView overrides: virtual void InitControlLayout(); @@ -549,22 +545,6 @@ void PrivacySection::LinkActivated(views::Link* source, int event_flags) { } } -void PrivacySection::Layout() { - if (reporting_enabled_checkbox_) { - // We override this to try and set the width of the enable logging checkbox - // to the width of the parent less some fudging since the checkbox's - // preferred size calculation code is dependent on its width, and if we - // don't do this then it will return 0 as a preferred width when GridLayout - // (called from View::Layout) tries to access it. - views::View* parent = GetParent(); - if (parent && parent->width()) { - const int parent_width = parent->width(); - reporting_enabled_checkbox_->SetBounds(0, 0, parent_width - 20, 0); - } - } - View::Layout(); -} - void PrivacySection::InitControlLayout() { AdvancedSection::InitControlLayout(); @@ -636,8 +616,8 @@ void PrivacySection::InitControlLayout() { reporting_enabled_checkbox_ != NULL); // The "Help make Google Chrome better" checkbox. if (reporting_enabled_checkbox_) { - AddLeadingControl(layout, reporting_enabled_checkbox_, indented_view_set_id, - false); + AddWrappingCheckboxRow(layout, reporting_enabled_checkbox_, + indented_view_set_id, false); } // Init member prefs so we can update the controls if prefs change. @@ -1421,5 +1401,4 @@ void AdvancedScrollViewContainer::Layout() { gfx::NativeTheme::LIST); lb.Inset(border.width(), border.height()); scroll_view_->SetBounds(lb); - scroll_view_->Layout(); } diff --git a/chrome/browser/views/options/content_page_view.cc b/chrome/browser/views/options/content_page_view.cc index add146e..04ccf65 100644 --- a/chrome/browser/views/options/content_page_view.cc +++ b/chrome/browser/views/options/content_page_view.cc @@ -41,8 +41,10 @@ namespace { -const int kPasswordSavingRadioGroup = 1; -const int kFormAutofillRadioGroup = 2; +// All the options pages are in the same view hierarchy. This means we need to +// make sure group identifiers don't collide across different pages. +const int kPasswordSavingRadioGroup = 201; +const int kFormAutofillRadioGroup = 202; // Background color for the status label when it's showing an error. static const SkColor kSyncLabelErrorBgColor = SkColorSetRGB(0xff, 0x9a, 0x9a); @@ -252,17 +254,6 @@ void ContentPageView::NotifyPrefChanged(const std::wstring* pref_name) { void ContentPageView::Layout() { if (is_initialized()) UpdateSyncControls(); - // We need to Layout twice - once to get the width of the contents box... - View::Layout(); - passwords_asktosave_radio_->SetBounds( - 0, 0, passwords_group_->GetContentsWidth(), 0); - passwords_neversave_radio_->SetBounds( - 0, 0, passwords_group_->GetContentsWidth(), 0); - if (is_initialized()) { - sync_status_label_->SetBounds( - 0, 0, sync_group_->GetContentsWidth(), 0); - } - // ... and twice to get the height of multi-line items correct. View::Layout(); } @@ -308,10 +299,12 @@ void ContentPageView::InitPasswordSavingGroup() { GridLayout::USE_PREF, 0, 0); layout->StartRow(0, single_column_view_set_id); - layout->AddView(passwords_asktosave_radio_); + layout->AddView(passwords_asktosave_radio_, 1, 1, + GridLayout::FILL, GridLayout::LEADING); layout->AddPaddingRow(0, kRelatedControlVerticalSpacing); layout->StartRow(0, single_column_view_set_id); - layout->AddView(passwords_neversave_radio_); + layout->AddView(passwords_neversave_radio_, 1, 1, + GridLayout::FILL, GridLayout::LEADING); layout->AddPaddingRow(0, kUnrelatedControlVerticalSpacing); layout->StartRow(0, single_column_view_set_id); layout->AddView(show_passwords_button_); @@ -356,10 +349,12 @@ void ContentPageView::InitFormAutofillGroup() { GridLayout::USE_PREF, 0, 0); layout->StartRow(0, fill_column_view_set_id); - layout->AddView(form_autofill_enable_radio_); + layout->AddView(form_autofill_enable_radio_, 1, 1, + GridLayout::FILL, GridLayout::LEADING); layout->AddPaddingRow(0, kRelatedControlVerticalSpacing); layout->StartRow(0, fill_column_view_set_id); - layout->AddView(form_autofill_disable_radio_); + layout->AddView(form_autofill_disable_radio_, 1, 1, + GridLayout::FILL, GridLayout::LEADING); layout->AddPaddingRow(0, kRelatedControlVerticalSpacing); layout->StartRow(0, leading_column_view_set_id); layout->AddView(change_autofill_settings_button_); @@ -457,7 +452,8 @@ void ContentPageView::InitSyncGroup() { GridLayout::USE_PREF, 0, 0); layout->StartRow(0, single_column_view_set_id); - layout->AddView(sync_status_label_, 3, 1); + layout->AddView(sync_status_label_, 3, 1, + GridLayout::FILL, GridLayout::LEADING); layout->StartRow(0, single_column_view_set_id); layout->AddView(sync_action_link_, 3, 1); layout->AddPaddingRow(0, kRelatedControlVerticalSpacing); diff --git a/chrome/browser/views/options/general_page_view.cc b/chrome/browser/views/options/general_page_view.cc index 20504c9..f836ea4 100644 --- a/chrome/browser/views/options/general_page_view.cc +++ b/chrome/browser/views/options/general_page_view.cc @@ -35,10 +35,13 @@ namespace { -const int kStartupRadioGroup = 1; -const int kHomePageRadioGroup = 2; +// All the options pages are in the same view hierarchy. This means we need to +// make sure group identifiers don't collide across different pages. +const int kStartupRadioGroup = 101; +const int kHomePageRadioGroup = 102; const SkColor kDefaultBrowserLabelColor = SkColorSetRGB(0, 135, 0); const SkColor kNotDefaultBrowserLabelColor = SkColorSetRGB(135, 0, 0); +const int kHomePageTextfieldWidthChars = 40; } // namespace @@ -402,24 +405,6 @@ void GeneralPageView::HighlightGroup(OptionsGroup highlight_group) { } /////////////////////////////////////////////////////////////////////////////// -// GeneralPageView, views::View overrides: - -void GeneralPageView::Layout() { - // We need to Layout twice - once to get the width of the contents box... - View::Layout(); - startup_last_session_radio_->SetBounds( - 0, 0, startup_group_->GetContentsWidth(), 0); - homepage_use_newtab_radio_->SetBounds( - 0, 0, homepage_group_->GetContentsWidth(), 0); - homepage_show_home_button_checkbox_->SetBounds( - 0, 0, homepage_group_->GetContentsWidth(), 0); - default_browser_status_label_->SetBounds( - 0, 0, default_browser_group_->GetContentsWidth(), 0); - // ... and twice to get the height of multi-line items correct. - View::Layout(); -} - -/////////////////////////////////////////////////////////////////////////////// // GeneralPageView, private: void GeneralPageView::SetDefaultBrowserUIState( @@ -512,14 +497,16 @@ void GeneralPageView::InitStartupGroup() { layout->AddView(startup_homepage_radio_); layout->AddPaddingRow(0, kRelatedControlVerticalSpacing); layout->StartRow(0, single_column_view_set_id); - layout->AddView(startup_last_session_radio_); + layout->AddView(startup_last_session_radio_, 1, 1, + GridLayout::FILL, GridLayout::LEADING); layout->AddPaddingRow(0, kRelatedControlVerticalSpacing); layout->StartRow(0, single_column_view_set_id); layout->AddView(startup_custom_radio_); layout->AddPaddingRow(0, kRelatedControlVerticalSpacing); layout->StartRow(0, double_column_view_set_id); - layout->AddView(startup_custom_pages_table_); + layout->AddView(startup_custom_pages_table_, 1, 1, + GridLayout::FILL, GridLayout::FILL); views::View* button_stack = new views::View; GridLayout* button_stack_layout = new GridLayout(button_stack); @@ -558,6 +545,8 @@ void GeneralPageView::InitHomepageGroup() { homepage_use_url_radio_->set_listener(this); homepage_use_url_textfield_ = new views::Textfield; homepage_use_url_textfield_->SetController(this); + homepage_use_url_textfield_->set_default_width_in_chars( + kHomePageTextfieldWidthChars); homepage_show_home_button_checkbox_ = new views::Checkbox( l10n_util::GetString(IDS_OPTIONS_HOMEPAGE_SHOW_BUTTON)); homepage_show_home_button_checkbox_->set_listener(this); @@ -584,14 +573,16 @@ void GeneralPageView::InitHomepageGroup() { GridLayout::USE_PREF, 0, 0); layout->StartRow(0, single_column_view_set_id); - layout->AddView(homepage_use_newtab_radio_); + layout->AddView(homepage_use_newtab_radio_, 1, 1, + GridLayout::FILL, GridLayout::LEADING); layout->AddPaddingRow(0, kRelatedControlVerticalSpacing); layout->StartRow(0, double_column_view_set_id); layout->AddView(homepage_use_url_radio_); layout->AddView(homepage_use_url_textfield_); layout->AddPaddingRow(0, kRelatedControlVerticalSpacing); layout->StartRow(0, single_column_view_set_id); - layout->AddView(homepage_show_home_button_checkbox_); + layout->AddView(homepage_show_home_button_checkbox_, 1, 1, + GridLayout::FILL, GridLayout::LEADING); homepage_group_ = new OptionsGroupView( contents, l10n_util::GetString(IDS_OPTIONS_HOMEPAGE_GROUP_NAME), @@ -657,7 +648,8 @@ void GeneralPageView::InitDefaultBrowserGroup() { GridLayout::USE_PREF, 0, 0); layout->StartRow(0, single_column_view_set_id); - layout->AddView(default_browser_status_label_); + layout->AddView(default_browser_status_label_, 1, 1, + GridLayout::FILL, GridLayout::LEADING); layout->AddPaddingRow(0, kRelatedControlVerticalSpacing); layout->StartRow(0, single_column_view_set_id); layout->AddView(default_browser_use_as_default_button_); diff --git a/chrome/browser/views/options/general_page_view.h b/chrome/browser/views/options/general_page_view.h index 7838fbe..6cc4911 100644 --- a/chrome/browser/views/options/general_page_view.h +++ b/chrome/browser/views/options/general_page_view.h @@ -62,9 +62,6 @@ class GeneralPageView : public OptionsPageView, virtual void NotifyPrefChanged(const std::wstring* pref_name); virtual void HighlightGroup(OptionsGroup highlight_group); - // views::View overrides: - virtual void Layout(); - private: // ShellIntegration::DefaultBrowserObserver implementation: // Updates the UI state to reflect the current default browser state. diff --git a/chrome/browser/views/options/options_window_view.cc b/chrome/browser/views/options/options_window_view.cc index 76c219b..70a043d 100644 --- a/chrome/browser/views/options/options_window_view.cc +++ b/chrome/browser/views/options/options_window_view.cc @@ -183,9 +183,9 @@ void OptionsWindowView::Layout() { } gfx::Size OptionsWindowView::GetPreferredSize() { - return gfx::Size(views::Window::GetLocalizedContentsSize( - IDS_OPTIONS_DIALOG_WIDTH_CHARS, - IDS_OPTIONS_DIALOG_HEIGHT_LINES)); + gfx::Size size(tabs_->GetPreferredSize()); + size.Enlarge(2 * kDialogPadding, 2 * kDialogPadding); + return size; } void OptionsWindowView::ViewHierarchyChanged(bool is_add, diff --git a/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc b/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc index b3e8194d..b7915b1 100644 --- a/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc +++ b/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc @@ -217,8 +217,10 @@ void TabContentsViewGtk::GetContainerBounds(gfx::Rect* out) const { // Callers expect the requested bounds not the actual bounds. For example, // during init callers expect 0x0, but Gtk layout enforces a min size of 1x1. - out->set_width(GetNativeView()->requisition.width); - out->set_height(GetNativeView()->requisition.height); + GtkRequisition requisition; + gtk_widget_get_child_requisition(GetNativeView(), &requisition); + out->set_width(requisition.width); + out->set_height(requisition.height); } void TabContentsViewGtk::StartDragging(const WebDropData& drop_data, diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index bba32d2..e1d2434 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -23,6 +23,7 @@ '../views/focus/focus_manager_unittest.cc', '../views/controls/label_unittest.cc', '../views/controls/progress_bar_unittest.cc', + '../views/controls/tabbed_pane/tabbed_pane_unittest.cc', '../views/controls/table/table_view_unittest.cc', '../views/grid_layout_unittest.cc', ], |