diff options
| author | henrika@chromium.org <henrika@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-15 13:59:58 +0000 |
|---|---|---|
| committer | henrika@chromium.org <henrika@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-15 13:59:58 +0000 |
| commit | 043181264edd6c7082ba5bcc6b30ac3d777da557 (patch) | |
| tree | 7eae5bcb4154d6392dfcf27bce02d20a2883836c /chrome_elf | |
| parent | 70d8e45aca22559569203a8c1c5444f508dccada (diff) | |
| download | chromium_src-043181264edd6c7082ba5bcc6b30ac3d777da557.zip chromium_src-043181264edd6c7082ba5bcc6b30ac3d777da557.tar.gz chromium_src-043181264edd6c7082ba5bcc6b30ac3d777da557.tar.bz2 | |
Revert of Blacklists virtualCamera.ax (https://codereview.chromium.org/325323003/)
Reason for revert:
No crashes have been found after 37.0.2046.2 and Canary on Windows is now on 37.0.2051.2, hence it looks good. Not sure if was the blacklisting or the "calling CoInitializeEx twice" patch which did the trick here.
I would like to revert the blacklisting patch to see if we can cope with the CoInitializeEx patch only. It would be great if we could avoid adding another DLL to the blacklist.
Original issue's description:
> Blacklists virtualCamera.ax.
>
> Tries to avoid crash in media::CoreAudioUtil::CreateDeviceEnumerator by blacklisting a DLL which accounts for a large amount of crashes we see in CreateDeviceEnumerator.
>
> BUG=383715, 378465
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276946
TBR=tommi@chromium.org,robertshield@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383715, 378465
Review URL: https://codereview.chromium.org/335073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277320 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_elf')
| -rw-r--r-- | chrome_elf/blacklist/blacklist.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome_elf/blacklist/blacklist.cc b/chrome_elf/blacklist/blacklist.cc index 00bea08..8107ffc 100644 --- a/chrome_elf/blacklist/blacklist.cc +++ b/chrome_elf/blacklist/blacklist.cc @@ -39,8 +39,6 @@ const wchar_t* g_troublesome_dlls[kTroublesomeDllsMaxCount] = { L"windowsapihookdll32.dll", // Lenovo One Key Theater. L"activedetect64.dll", // Lenovo One Key Theater. L"windowsapihookdll64.dll", // Lenovo One Key Theater. - L"virtualCamera.ax", // %PROGRAMFILES%\ASUS\VirtualCamera. - // See crbug.com/383715. // Keep this null pointer here to mark the end of the list. NULL, }; |