diff options
| author | jam <jam@chromium.org> | 2015-05-27 10:49:50 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-27 17:50:14 +0000 |
| commit | 4abcd6edd7dd5c672436496774686fbdda858569 (patch) | |
| tree | 362709a7794baee382ef28adcc606caace624ef4 /chrome_elf | |
| parent | a7208987e5b66ad22e467cd57a70975060c3219f (diff) | |
| download | chromium_src-4abcd6edd7dd5c672436496774686fbdda858569.zip chromium_src-4abcd6edd7dd5c672436496774686fbdda858569.tar.gz chromium_src-4abcd6edd7dd5c672436496774686fbdda858569.tar.bz2 | |
Fix mojo apptest crash and renable the tests.
The tests regressed in r331193. The reason is that ViewManagerInit's error handler could be called after the object is deleted, on app shutdown when the message loop's destruction leads to (the passed) service_'s error handler to be called. This was unnoticed before when ViewManagerInit::OnConnectionError() didn't access member variables.
When I renabled the tests, I had reverted the revert which disabled them (for the dependency error that was fixed). Unfortunately this meant that the change didn't go through trybots.
BUG=478244
Review URL: https://codereview.chromium.org/1155743005
Cr-Commit-Position: refs/heads/master@{#331601}
Diffstat (limited to 'chrome_elf')
0 files changed, 0 insertions, 0 deletions